From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thien-Thi Nguyen Newsgroups: gmane.emacs.devel Subject: Re: [elpa] 01/03: [gnugo frolic int] Regularize keymap decl + init. Date: Wed, 09 Apr 2014 20:57:06 +0200 Message-ID: <877g6yjpq5.fsf@zigzag.favinet> References: <20140409121712.31423.53123@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Trace: ger.gmane.org 1397069602 17853 80.91.229.3 (9 Apr 2014 18:53:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 9 Apr 2014 18:53:22 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 09 20:53:15 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WXxcY-0001qb-IF for ged-emacs-devel@m.gmane.org; Wed, 09 Apr 2014 20:53:14 +0200 Original-Received: from localhost ([::1]:47638 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXxcY-0000fR-6p for ged-emacs-devel@m.gmane.org; Wed, 09 Apr 2014 14:53:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59569) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXxcP-0000du-N4 for emacs-devel@gnu.org; Wed, 09 Apr 2014 14:53:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WXxcJ-0003Uz-Q5 for emacs-devel@gnu.org; Wed, 09 Apr 2014 14:53:05 -0400 Original-Received: from smtp206.alice.it ([82.57.200.102]:50309) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXxcJ-0003Ty-DL for emacs-devel@gnu.org; Wed, 09 Apr 2014 14:52:59 -0400 Original-Received: from zigzag.favinet (79.45.20.174) by smtp206.alice.it (8.6.060.28) id 529A678F19B82556; Wed, 9 Apr 2014 20:52:53 +0200 Original-Received: from ttn by zigzag.favinet with local (Exim 4.80) (envelope-from ) id 1WXxgT-0005XB-8T; Wed, 09 Apr 2014 20:57:17 +0200 In-Reply-To: (Stefan Monnier's message of "Wed, 09 Apr 2014 09:45:48 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 82.57.200.102 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:171377 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable () Stefan Monnier () Wed, 09 Apr 2014 09:45:48 -0400 > +(unless gnugo-frolic-mode-map > + (setq gnugo-frolic-mode-map (make-sparse-keymap)) > + [...]) Any reason not to use the standard (defvar gnugo-frolic-mode-map (let ((map (make-sparse-keymap))) [...] map)) Or even using pcase-dolist: (defvar gnugo-frolic-mode-map (let ((map (make-sparse-keymap))) (suppress-keymap map) (pcase-dolist [...]) map)) Well, the latter is still scary to this pre-=E2=80=98dolist=E2=80=99-w/o-cl= .el dinosaur, although it certainly looks sveltely attractive (modulo backticks, but i suppose they are unavoidable for =E2=80=98pcase=E2=80=99). More disturbing is seeing a huge form early in the file, w/ many forward references; i prefer to maintain top-level forms topo-sorted as much as possible (surely a sign of C/Scheme braindamage -- call a doctor!). But anyway, i'll stew on it for a while; thanks for the suggestion. =2D-=20 Thien-Thi Nguyen GPG key: 4C807502 (if you're human and you know it) read my lisp: (responsep (questions 'technical) (not (via 'mailing-list))) =3D> nil --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlNFmAYACgkQZwMiJEyAdQKpyACeKTe6jljVqPhKRh06wu38GiMj b3UAoLOq9gyt74WJXXRj3Y8Z71jPMBhb =xvFd -----END PGP SIGNATURE----- --=-=-=--