From: Thien-Thi Nguyen <ttn@gnu.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: emacs-devel@gnu.org
Subject: Re: [elpa] 01/03: [gnugo frolic int] Regularize keymap decl + init.
Date: Wed, 09 Apr 2014 20:57:06 +0200 [thread overview]
Message-ID: <877g6yjpq5.fsf@zigzag.favinet> (raw)
In-Reply-To: <jwva9buwrfi.fsf-monnier+emacsdiffs@gnu.org> (Stefan Monnier's message of "Wed, 09 Apr 2014 09:45:48 -0400")
[-- Attachment #1: Type: text/plain, Size: 1270 bytes --]
() Stefan Monnier <monnier@IRO.UMontreal.CA>
() Wed, 09 Apr 2014 09:45:48 -0400
> +(unless gnugo-frolic-mode-map
> + (setq gnugo-frolic-mode-map (make-sparse-keymap))
> + [...])
Any reason not to use the standard
(defvar gnugo-frolic-mode-map
(let ((map (make-sparse-keymap)))
[...]
map))
Or even using pcase-dolist:
(defvar gnugo-frolic-mode-map
(let ((map (make-sparse-keymap)))
(suppress-keymap map)
(pcase-dolist [...])
map))
Well, the latter is still scary to this pre-‘dolist’-w/o-cl.el dinosaur,
although it certainly looks sveltely attractive (modulo backticks, but i
suppose they are unavoidable for ‘pcase’).
More disturbing is seeing a huge form early in the file, w/ many forward
references; i prefer to maintain top-level forms topo-sorted as much as
possible (surely a sign of C/Scheme braindamage -- call a doctor!).
But anyway, i'll stew on it for a while; thanks for the suggestion.
--
Thien-Thi Nguyen
GPG key: 4C807502
(if you're human and you know it)
read my lisp: (responsep (questions 'technical)
(not (via 'mailing-list)))
=> nil
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2014-04-09 18:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140409121712.31423.53123@vcs.savannah.gnu.org>
[not found] ` <E1WXrRK-0008Bt-55@vcs.savannah.gnu.org>
2014-04-09 13:45 ` [elpa] 01/03: [gnugo frolic int] Regularize keymap decl + init Stefan Monnier
2014-04-09 14:12 ` Juanma Barranquero
2014-04-09 18:57 ` Thien-Thi Nguyen [this message]
2014-04-10 13:12 ` Stefan Monnier
2014-04-10 20:39 ` Thien-Thi Nguyen
2014-04-10 22:25 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877g6yjpq5.fsf@zigzag.favinet \
--to=ttn@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).