From: Ted Zlatanov <tzz@lifelogs.com>
To: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] scratch/bug19328/custom-prompt-customize-unsaved-options-rc2 e9e8f01: Provide custom-prompt-customize-unsaved-options.
Date: Sun, 14 Dec 2014 12:09:07 -0500 [thread overview]
Message-ID: <877fxuxioc.fsf@lifelogs.com> (raw)
In-Reply-To: jwvd27mmhg5.fsf-monnier+emacsdiffs@gnu.org
On Sun, 14 Dec 2014 09:36:00 -0500 Stefan Monnier <monnier@iro.umontreal.ca> wrote:
SM> Looks good, with the following nitpicks
>> * lisp/cus-edit.el (custom-prompt-customize-unsaved-options): Add a
>> mechanism for prompting user about unsaved customizations.
SM> These two lines mean "change the custom-prompt-customize-unsaved-options
SM> by adding a mechanism for ...", which is not what the patch does.
SM> Instead, they should just say
SM> * lisp/cus-edit.el (custom-prompt-customize-unsaved-options): New function.
SM> Additionally, this text fails to mention custom-unsaved-options or the
SM> fact that customize-unsaved has been modified, so I'd write:
SM> * lisp/cus-edit.el (custom-unsaved-options): New function, extracted
SM> from customize-unsaved.
SM> (custom-unsaved): Use it.
SM> (custom-prompt-customize-unsaved-options): New function.
OK, I installed it earlier and have now added a commit to just fix that
ChangeLog entry.
FWIW, I think your version does not explain what the change provides,
only that it was made (it basically restates the diff). I don't know if
that's what you intended.
Ted
next prev parent reply other threads:[~2014-12-14 17:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20141214114850.13638.56381@vcs.savannah.gnu.org>
[not found] ` <E1Y07fP-0003ZA-N8@vcs.savannah.gnu.org>
2014-12-14 14:36 ` [Emacs-diffs] scratch/bug19328/custom-prompt-customize-unsaved-options-rc2 e9e8f01: Provide custom-prompt-customize-unsaved-options Stefan Monnier
2014-12-14 17:09 ` Ted Zlatanov [this message]
2014-12-14 23:36 ` Stefan Monnier
2014-12-15 1:07 ` Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fxuxioc.fsf@lifelogs.com \
--to=tzz@lifelogs.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).