From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: Re: moving some indentation tests Date: Fri, 07 Apr 2017 16:51:21 +0100 Message-ID: <877f2ww70m.fsf@russet.org.uk> References: <878tnj2lap.fsf@tromey.com> <874ly6ft50.fsf@russet.org.uk> <87y3vhd9ud.fsf@russet.org.uk> <874ly5cuob.fsf@russet.org.uk> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1491580477 24830 195.159.176.226 (7 Apr 2017 15:54:37 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 7 Apr 2017 15:54:37 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) Cc: Tom Tromey , Emacs discussions To: Noam Postavsky Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 07 17:54:29 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cwWDM-0004a6-Ba for ged-emacs-devel@m.gmane.org; Fri, 07 Apr 2017 17:54:21 +0200 Original-Received: from localhost ([::1]:51543 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cwWDQ-0002q7-OR for ged-emacs-devel@m.gmane.org; Fri, 07 Apr 2017 11:54:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56321) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cwWBF-0001wm-KO for emacs-devel@gnu.org; Fri, 07 Apr 2017 11:52:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cwWBB-0002gy-Me for emacs-devel@gnu.org; Fri, 07 Apr 2017 11:52:09 -0400 Original-Received: from cloud103.planethippo.com ([78.129.138.110]:32768) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cwWBB-0002XV-De for emacs-devel@gnu.org; Fri, 07 Apr 2017 11:52:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=845b932McZx+oZbYeud80FbWGwbM2b+9+/pbs3iiBeg=; b=QZcJPvpF/iVBMmhP+8BAW6N6C dFtL+szfMJgRpDbYq0go+DoXSyrLqeMOBZ26lDH/Zq+cZrB9+s2ac/6/ACIphoCiqDyj3X8UAEfEy zIQYG0khBXwcoTKRTx+/2iY544t5xknHqPAePN4N5rjLda1/X8wgFr7DF0/DUsZgw0S6HQ7QHQazf CNULXw3h4S0EqhEjtTGKCKF3yMih/TXz4tvwEZRb44DsC2N67T3Yx2KvsHqtGqeiTJbIBb6qk06hl UoMJSY2RPRoBSqwYN3Lhgt2GTCllEnggZT+enXnheyMsHL2pEqNGy0ThxfhkC8uGEStKf2UK8SgCg 1MGzkTiYg==; Original-Received: from janus-nat-128-240-225-75.ncl.ac.uk ([128.240.225.75]:36804 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.88) (envelope-from ) id 1cwWAU-0000SM-5l; Fri, 07 Apr 2017 15:51:22 +0000 In-Reply-To: (Noam Postavsky's message of "Mon, 3 Apr 2017 16:38:03 -0400") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-Source: X-Source-Args: X-Source-Dir: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 78.129.138.110 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213756 Archived-At: Noam Postavsky writes: > On Mon, Apr 3, 2017 at 12:39 PM, Phillip Lord > wrote: >> >> Ah, so you put in some relatively random indentation (well, not random), >> and then reindent it, rather than starting from totally unindented. > > Yes, exactly. Arbitrary, but not random because if you have a test > failure it would be annoying to debug it with different indentation > each time! > >> >> Although I think emacs-lisp-mode is not working correctly here. In my hands: >> >> " >> (hello >> (world)) >> " >> >> indents to >> >> " >> (hello >> (world)) >> " >> >> in emacs-lisp mode. So I'm not 100% sure this is assess not working. > > Ah, because lisp-indent-line doesn't check the parse context. > `indent-sexp' does the right thing, if called outside the string (and > also inside since #21343 was fixed). > > I believe my patches at > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25122#77 will fix this > for `indent-region' (since I happened to copy the syntax-ppss fix from > #21343). Probably `lisp-indent-line' should also use syntax-ppss to > get the correct parse context. So, in this case, assess is working? lisp-indent-line is, effectively, broken? Phil