From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.devel Subject: Re: master 941a2e7: todo-mode: don't assume an ordering of tests Date: Tue, 30 May 2017 21:52:03 +0200 Message-ID: <877f0y9l7g.fsf@rosalinde> References: <20170530005055.14646.47570@vcs0.savannah.gnu.org> <20170530005057.4720C20ACA@vcs0.savannah.gnu.org> <87vaoiafgf.fsf@rosalinde> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1496173951 6373 195.159.176.226 (30 May 2017 19:52:31 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 30 May 2017 19:52:31 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 30 21:52:25 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFnBf-00016S-7g for ged-emacs-devel@m.gmane.org; Tue, 30 May 2017 21:52:15 +0200 Original-Received: from localhost ([::1]:56006 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFnBk-0004Bx-Hc for ged-emacs-devel@m.gmane.org; Tue, 30 May 2017 15:52:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36364) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFnBd-0004Ad-Dz for emacs-devel@gnu.org; Tue, 30 May 2017 15:52:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dFnBb-00017Z-S0 for emacs-devel@gnu.org; Tue, 30 May 2017 15:52:13 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:53605) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dFnBV-00016f-WD; Tue, 30 May 2017 15:52:06 -0400 Original-Received: from rosalinde ([83.135.25.138]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0Lp7d2-1dsALP3weK-00eu8h; Tue, 30 May 2017 21:52:04 +0200 In-Reply-To: (Glenn Morris's message of "Tue, 30 May 2017 11:35:33 -0400") X-Provags-ID: V03:K0:UQdiwrwNIKdvIvAyvsFCmjFjC+xXx7wIqmIg6koWdLGVZ9jZn0N okri6hqWTZQ4B9MET2er3uSeCVjgquyNhWcFhT+1tB6h0RMU2rUZQGDQGUuS6LhFmoegJM5 xQI/Zx3k+201WLb1I7bCjPD/7w2Lvsyw4mZcoMRVwwk7Bpu6RzeWtb39+vnWvH+HzIPUiug YbCFldufIWTw+AgMru8gQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:0raD75ptv6c=:HAaMYEHYIElogxCF/wXUCl 0zv2iwwc3x6fU+WcPLzAQDYjdFWoEur3NLv9axdQTBkm437wAThAMgh7Cujh0hn8x6RTfbyqT k+B4AzS2IJyVRJGjTZ3qPTRO2FAVcet7fRJ/2lPgqF/uxMFMPkx+/aoRm2gX0N1OXkEkbf/cv XUf15YfT2D+dCfl3QS2TtioiaCt822clP5hoa2zK58ZUxOlmcN6JHij54tGF5Lx+la9n2zyZj sZuBaB7U1kXiwZtNuy2EIsp29i2Em/0Krx6wcDY7zyVlY4WeKO2sk1gJ2+MvKTkYdWV79U2bD L0Px7OiRHSU50xVrFLhJ3ttv+BlmRyFXIqn9wFRVflZF4j+t5J0usVZKDVtW56QR1g/CLB2nf UgyudIHHuajZGkKifC4JvJKk4jLhj3+xNclwhT2zxBAvhzGQ5cGVGylr6Lil/2qGNFwR1hxV2 zg6SoW4QqhTW2DwoZ+HMXvuym/ZBBw2Psk4CQZE6uYDgSc8hJwWnJd6tnaw1QNHHfklQMDo0Y 8fRXYN6QDFFeq1ncLZeCP5LsgTABLLtSW7jPFcfDQ5MPjZfs/86Xvfwh23dQppCtuWhevXttt o5vFTu8Tyf12iPnC7OnfeLL4wNo5nF1a6JU2WQ6Zus7PGlyD2D5yySGhiXEGluJAUyzsZ0FuZ 1dLgvTk+ihC81kytRhy3hmbBAU2LIw+HF4SU14/n3JRR0mPrntsI7v+t5BM3z58NwfJCg0MNH W8RwIBTjXHaY6A4GgKzBtgSrISx7y4pH73JEhqtCgCuAx8cf3O9mEiUHEa/iQGcIzcqREiuL X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.17.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:215354 Archived-At: On Tue, 30 May 2017 11:35:33 -0400 Glenn Morris wrote: > Stephen Berman wrote: > >> How did you run the tests such that you got prompted for a file > > make check Hmm. I cannot reproduce the failure. I commented out your changes to todo-mode-tests.el, deleted the .elc file, ran make check, and all the tests in todo-mode-tests.el passed. Do you have any idea why our results differ? >> and what was the prompt? > > "Enter name of new todo file (TAB or SPC to see current names):" > > Ref: http://hydra.nixos.org/build/53544385 > > Testing lisp/calendar/todo-mode-tests.el > Running 3 tests (2017-05-29 22:44:07+0000) > Enter name of new todo file (TAB or SPC to see current names): Test > todo-test-item-highlighting backtrace: > completing-read("Enter name of new todo file (TAB or SPC to see curr > todo-read-file-name("Enter name of new todo file (TAB or SPC to see > todo-add-file() > todo-show() This backtrace means that the variables todo-current-todo-file, todo-global-current-todo-file, and todo-default-todo-file all evaluated to nil. I don't see how that could happen with the test file, and when I start Emacs with -Q, eval the test file, instrument todo-show, run ert on the test todo-test-item-highlighting, and step through todo-show and todo-check-file, I see that todo-default-todo-file gets assigned todo-test-1.todo from the todo-resources directory as its value. So I have no idea how this error could arise. And I also don't see how adding the sexp `(todo-test-get-archive 2)' prevents it, since that just displays the file todo-test-1.toda in todo-archive-mode (and that file becomes the buffer-local value of todo-current-todo-file). Can you reproduce the error, and if so, could you try debugging it? Or if you don't have time for that, could you tell me why you used that specific change to avoid the error? Maybe I'm overlooking something. Steve Berman