unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* How to block tests on hydra
@ 2017-07-01 11:48 Michael Albinus
  2017-07-11  3:44 ` Noam Postavsky
  0 siblings, 1 reply; 9+ messages in thread
From: Michael Albinus @ 2017-07-01 11:48 UTC (permalink / raw)
  To: emacs-devel

Hi,

recent changes of Tramp block the test on hydra in
gnu:emacs-trunk:coverage. I've instrumented test/Makefile.in in order to
see the output of tramp-tests, and it looks like the blocking test is
tramp-test36-asynchronous-requests. It works properly when running locally.

Well, I have worked on this test the last two weeks. Problems in this
test have always been bad timings and race conditions. In order to find
the cause on hydra, I would need to add traces to this test case again
and again. This would take time; I would not be surprised, if it will
take one or two weeks.

Would it be OK to block all the other Emacs tests on hydra for that
time? If not, I will skip the test if it detecs hydra environment, and
we won't know ever what's behind.

Best regards, Michael.



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: How to block tests on hydra
  2017-07-01 11:48 How to block tests on hydra Michael Albinus
@ 2017-07-11  3:44 ` Noam Postavsky
  2017-07-11  7:20   ` Michael Albinus
  0 siblings, 1 reply; 9+ messages in thread
From: Noam Postavsky @ 2017-07-11  3:44 UTC (permalink / raw)
  To: Michael Albinus; +Cc: Emacs developers

On Sat, Jul 1, 2017 at 7:48 AM, Michael Albinus <michael.albinus@gmx.de> wrote:

> recent changes of Tramp block the test on hydra in
> gnu:emacs-trunk:coverage. I've instrumented test/Makefile.in in order to
> see the output of tramp-tests, and it looks like the blocking test is
> tramp-test36-asynchronous-requests. It works properly when running locally.

I'm surprised it does anything at all actually, isn't the (add-to-list
'buffers ...) call a bug? Should be using `push' I think.

-              (add-to-list 'buffers (generate-new-buffer "foo")))
+              (push (generate-new-buffer "foo") buffers))

I noticed you added a with-timeout on that test, but it doesn't seem
to be working. Maybe a stronger method would be to use

    (start-process "*watchdog*" nil shell-file-name shell-command-switch
                   (format "sleep 350 ; kill -SIGUSR2 %d" (emacs-pid)))

By the way, I hit the "`tramp-test36-asynchronous-requests' timed out"
message when running locally in an -O0 build, although it succeeds
with an -O2 build. Maybe I just have a weak CPU.



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: How to block tests on hydra
  2017-07-11  3:44 ` Noam Postavsky
@ 2017-07-11  7:20   ` Michael Albinus
  2017-07-11 11:45     ` Noam Postavsky
  0 siblings, 1 reply; 9+ messages in thread
From: Michael Albinus @ 2017-07-11  7:20 UTC (permalink / raw)
  To: Noam Postavsky; +Cc: Emacs developers

Noam Postavsky <npostavs@users.sourceforge.net> writes:

Hi Noam,

>> recent changes of Tramp block the test on hydra in
>> gnu:emacs-trunk:coverage. I've instrumented test/Makefile.in in order to
>> see the output of tramp-tests, and it looks like the blocking test is
>> tramp-test36-asynchronous-requests. It works properly when running locally.
>
> I'm surprised it does anything at all actually, isn't the (add-to-list
> 'buffers ...) call a bug? Should be using `push' I think.
>
> -              (add-to-list 'buffers (generate-new-buffer "foo")))
> +              (push (generate-new-buffer "foo") buffers))

Why that? `add-to-list' is as good as `push' in this case. I haven't seen a
problem with that. If you run in edebug, you'll see that `buffers' keeps
all process buffers.

> I noticed you added a with-timeout on that test, but it doesn't seem
> to be working.

The timeout is a self-defense. And it doesn't trigger at least for me,
because (I believe) the test case is working properly now, and finishes
in time.

> By the way, I hit the "`tramp-test36-asynchronous-requests' timed out"
> message when running locally in an -O0 build, although it succeeds
> with an -O2 build. Maybe I just have a weak CPU.

How does it make a difference? Is an asynchronous process to be intended
to run in another thread, on another processor?

Best regards, Michael.



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: How to block tests on hydra
  2017-07-11  7:20   ` Michael Albinus
@ 2017-07-11 11:45     ` Noam Postavsky
  2017-07-12 12:54       ` Michael Albinus
  0 siblings, 1 reply; 9+ messages in thread
From: Noam Postavsky @ 2017-07-11 11:45 UTC (permalink / raw)
  To: Michael Albinus; +Cc: Emacs developers

On Tue, Jul 11, 2017 at 3:20 AM, Michael Albinus <michael.albinus@gmx.de> wrote:
>>
>> I'm surprised it does anything at all actually, isn't the (add-to-list
>> 'buffers ...) call a bug? Should be using `push' I think.
>>
>> -              (add-to-list 'buffers (generate-new-buffer "foo")))
>> +              (push (generate-new-buffer "foo") buffers))
>
> Why that? `add-to-list' is as good as `push' in this case. I haven't seen a
> problem with that. If you run in edebug, you'll see that `buffers' keeps
> all process buffers.

But you have lexical-binding:t set at the top of the file, and
`buffer' is a let-bound variable, whereas `add-to-list' operates on
dynamic variables. Hmm, looking at the disassembly it seems that
add-to-list's compiler macro fixed up the problem, although I thought
it should give a compile warning in this situation.

>
>> I noticed you added a with-timeout on that test, but it doesn't seem
>> to be working.
>
> The timeout is a self-defense. And it doesn't trigger at least for me,
> because (I believe) the test case is working properly now, and finishes
> in time.

What about this one:

http://hydra.nixos.org/eval/1373949
https://nix-cache.s3.amazonaws.com/log/v7ndmrhdhjw76v9mzghjyijnsmw2npl8-emacs-coverage-unknown.drv

>
>> By the way, I hit the "`tramp-test36-asynchronous-requests' timed out"
>> message when running locally in an -O0 build, although it succeeds
>> with an -O2 build. Maybe I just have a weak CPU.
>
> How does it make a difference? Is an asynchronous process to be intended
> to run in another thread, on another processor?

I don't know why it makes a difference.



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: How to block tests on hydra
  2017-07-11 11:45     ` Noam Postavsky
@ 2017-07-12 12:54       ` Michael Albinus
  2017-07-14  1:30         ` Noam Postavsky
  0 siblings, 1 reply; 9+ messages in thread
From: Michael Albinus @ 2017-07-12 12:54 UTC (permalink / raw)
  To: Noam Postavsky; +Cc: Emacs developers

Noam Postavsky <npostavs@users.sourceforge.net> writes:

Hi Noam,

>>> I'm surprised it does anything at all actually, isn't the (add-to-list
>>> 'buffers ...) call a bug? Should be using `push' I think.
>>>
>>> -              (add-to-list 'buffers (generate-new-buffer "foo")))
>>> +              (push (generate-new-buffer "foo") buffers))
>>
>> Why that? `add-to-list' is as good as `push' in this case. I haven't seen a
>> problem with that. If you run in edebug, you'll see that `buffers' keeps
>> all process buffers.
>
> But you have lexical-binding:t set at the top of the file, and
> `buffer' is a let-bound variable, whereas `add-to-list' operates on
> dynamic variables. Hmm, looking at the disassembly it seems that
> add-to-list's compiler macro fixed up the problem, although I thought
> it should give a compile warning in this situation.

Well, as compromise I use now

(setq buffers (cons (generate-new-buffer "foo") buffers))

>>> I noticed you added a with-timeout on that test, but it doesn't seem
>>> to be working.
>>
>> The timeout is a self-defense. And it doesn't trigger at least for me,
>> because (I believe) the test case is working properly now, and finishes
>> in time.
>
> What about this one:
>
> http://hydra.nixos.org/eval/1373949
> https://nix-cache.s3.amazonaws.com/log/v7ndmrhdhjw76v9mzghjyijnsmw2npl8-emacs-coverage-unknown.drv

Hmm, it happens sporadically. I have enabled traces for tramp-tests,
hopefully we'll get more information when it happens next time.

>>> By the way, I hit the "`tramp-test36-asynchronous-requests' timed out"
>>> message when running locally in an -O0 build, although it succeeds
>>> with an -O2 build. Maybe I just have a weak CPU.

Could you try to reproduce it? tramp-tests.log might help then.

Best regards, Michael.



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: How to block tests on hydra
  2017-07-12 12:54       ` Michael Albinus
@ 2017-07-14  1:30         ` Noam Postavsky
  2017-07-14  8:58           ` Michael Albinus
  0 siblings, 1 reply; 9+ messages in thread
From: Noam Postavsky @ 2017-07-14  1:30 UTC (permalink / raw)
  To: Michael Albinus; +Cc: Emacs developers

[-- Attachment #1: Type: text/plain, Size: 447 bytes --]

On Wed, Jul 12, 2017 at 8:54 AM, Michael Albinus <michael.albinus@gmx.de> wrote:
>
>>>> By the way, I hit the "`tramp-test36-asynchronous-requests' timed out"
>>>> message when running locally in an -O0 build, although it succeeds
>>>> with an -O2 build. Maybe I just have a weak CPU.
>
> Could you try to reproduce it? tramp-tests.log might help then.

After running the test, I see the attached in *Messages*, not sure
what we're looking for...

[-- Attachment #2: tramp-test36.log.gz --]
[-- Type: application/x-gzip, Size: 1441 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: How to block tests on hydra
  2017-07-14  1:30         ` Noam Postavsky
@ 2017-07-14  8:58           ` Michael Albinus
  2017-07-15  3:07             ` Noam Postavsky
  0 siblings, 1 reply; 9+ messages in thread
From: Michael Albinus @ 2017-07-14  8:58 UTC (permalink / raw)
  To: Noam Postavsky; +Cc: Emacs developers

Noam Postavsky <npostavs@users.sourceforge.net> writes:

Hi Noam,

> After running the test, I see the attached in *Messages*, not sure
> what we're looking for...

This means that the timer eats all resources. I've added an adaptive
adjustment of the timer for this case, could you, pls, retest?

Best regards, Michael.



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: How to block tests on hydra
  2017-07-14  8:58           ` Michael Albinus
@ 2017-07-15  3:07             ` Noam Postavsky
  2017-07-15  7:30               ` Michael Albinus
  0 siblings, 1 reply; 9+ messages in thread
From: Noam Postavsky @ 2017-07-15  3:07 UTC (permalink / raw)
  To: Michael Albinus; +Cc: Emacs developers

[-- Attachment #1: Type: text/plain, Size: 260 bytes --]

On Fri, Jul 14, 2017 at 4:58 AM, Michael Albinus <michael.albinus@gmx.de> wrote:
> This means that the timer eats all resources. I've added an adaptive
> adjustment of the timer for this case, could you, pls, retest?

After this change the test passes for me.

[-- Attachment #2: tramp-test36-2.log.gz --]
[-- Type: application/x-gzip, Size: 760 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: How to block tests on hydra
  2017-07-15  3:07             ` Noam Postavsky
@ 2017-07-15  7:30               ` Michael Albinus
  0 siblings, 0 replies; 9+ messages in thread
From: Michael Albinus @ 2017-07-15  7:30 UTC (permalink / raw)
  To: Noam Postavsky; +Cc: Emacs developers

Noam Postavsky <npostavs@users.sourceforge.net> writes:

>> This means that the timer eats all resources. I've added an adaptive
>> adjustment of the timer for this case, could you, pls, retest?
>
> After this change the test passes for me.

Thanks. What's left to do is observing hydra. I'll do.

Best regards, Michael.



^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2017-07-15  7:30 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-01 11:48 How to block tests on hydra Michael Albinus
2017-07-11  3:44 ` Noam Postavsky
2017-07-11  7:20   ` Michael Albinus
2017-07-11 11:45     ` Noam Postavsky
2017-07-12 12:54       ` Michael Albinus
2017-07-14  1:30         ` Noam Postavsky
2017-07-14  8:58           ` Michael Albinus
2017-07-15  3:07             ` Noam Postavsky
2017-07-15  7:30               ` Michael Albinus

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).