Re: Help with recursive destructive function

[Eric Abrahamsen <eric@ericabrahamsen.net>]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>     (defun deep-edit (f data)
>>       (let ((cur (list #'car #'setcar data))
>>             (stack (list (list #'cdr #'setcdr data))))
>>         (while cur
>>           (let* ((getter (car cur))
>>                  (setter (cadr cur))
>>                  (tree (caddr cur))
>>                  (subtree (funcall getter tree)))
>>             (funcall setter tree (funcall f subtree))
>>             (cond
>>              ((consp subtree)
>>               (push (list #'cdr #'setcdr subtree) stack)
>>               (setq cur (list #'car #'setcar subtree)))
>>              (t (setq cur (pop stack))))))))
>
> BTW, a "cleaner" (tho less efficient) way uses gv-ref:
>
>     (defun deep-edit (f data)
>       (let ((cur (gv-ref (car data)))
>             (stack (list (gv-ref (cdr data)))))
>         (while (or cur stack)
>           ;; Probably should use (cl-callf f (gv-deref cell)).
>           (pcase (setf (gv-deref cur) (funcall f (gv-deref cell)))
>             ((and (pred consp) subtree)
>               (push (gv-ref (cdr subtree)) stack)
>               (setq cur (gv-ref (car subtree))))
>             (t (setq cur (pop stack)))))))
>
> tho the above has a bug when cur is nil, so it won't work as is.

All this went very rapidly over my head, but I guess that's what I was
hoping for! I'll wait and see if you all work this through any further,
then play around with the results, and update bug #29541 with a new patch.

Thanks!

Eric