From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master fe939b3 1/2: Fix reference to `tags-loop-continue' in doc string Date: Fri, 02 Aug 2019 20:27:22 +0200 Message-ID: <877e7vpgmt.fsf@mouse.gnus.org> References: <20190801195403.16246.49802@vcs0.savannah.gnu.org> <20190801195406.087AF20CC8@vcs0.savannah.gnu.org> <87ef23allc.fsf@mouse.gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="207505"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 02 20:43:21 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1htcWM-000rp5-9n for ged-emacs-devel@m.gmane.org; Fri, 02 Aug 2019 20:43:18 +0200 Original-Received: from localhost ([::1]:36936 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1htcWL-0007Np-7l for ged-emacs-devel@m.gmane.org; Fri, 02 Aug 2019 14:43:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34658) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1htcH4-00080l-8a for emacs-devel@gnu.org; Fri, 02 Aug 2019 14:27:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1htcH2-00056I-7M for emacs-devel@gnu.org; Fri, 02 Aug 2019 14:27:29 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:56394) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1htcH2-00051E-0M for emacs-devel@gnu.org; Fri, 02 Aug 2019 14:27:28 -0400 Original-Received: from 77.18.62.220.tmi.telenormobil.no ([77.18.62.220] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1htcGx-0004o0-3B for emacs-devel@gnu.org; Fri, 02 Aug 2019 20:27:25 +0200 In-Reply-To: (Robert Pluim's message of "Fri, 02 Aug 2019 14:23:15 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239142 Archived-At: Robert Pluim writes: > Ah, you mean like this? I hope I have the eval-when-compile stuff > right. And if you do 'dired-do-search' followed by > 'xref-find-definitions' it would be easy to confuse yourself. > > We could find a new binding for fileloop-continue, which also breaks > backwards compatibility, but then at least there=CA=BCs a default binding. [...] > +(eval-when-compile (declare-function fileloop-continue "fileloop" ())) I don't think this is necessary -- you can just have the `declare-function' without any `eval-when-compile'. But you should probably include the arg list? > + (if (ring-empty-p ring) > + ;; Just in case we were in a fileloop sequence > + (fileloop-continue) Yes, that's what I wondered would work. Are there any drawbacks to doing something like this? Perhaps the interface becomes a bit... unpredictable? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no