* revising a [PATCH]
@ 2019-11-20 16:51 dick.r.chiang
2019-11-20 17:23 ` Amin Bandali
0 siblings, 1 reply; 4+ messages in thread
From: dick.r.chiang @ 2019-11-20 16:51 UTC (permalink / raw)
To: emacs-devel
What is the preferred way of revising an already submitted [PATCH]?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: revising a [PATCH]
2019-11-20 16:51 revising a [PATCH] dick.r.chiang
@ 2019-11-20 17:23 ` Amin Bandali
2019-11-20 17:58 ` dick.r.chiang
0 siblings, 1 reply; 4+ messages in thread
From: Amin Bandali @ 2019-11-20 17:23 UTC (permalink / raw)
To: emacs-devel
dick.r.chiang@gmail.com writes:
> What is the preferred way of revising an
> already submitted [PATCH]?
The usual practice is to amend your commit with
the new changes, potentially rebase onto latest
commit, and send a v2. For a recent and simple
example, see https://bugs.gnu.org/38257.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: revising a [PATCH]
2019-11-20 17:23 ` Amin Bandali
@ 2019-11-20 17:58 ` dick.r.chiang
2019-11-20 18:20 ` Robert Pluim
0 siblings, 1 reply; 4+ messages in thread
From: dick.r.chiang @ 2019-11-20 17:58 UTC (permalink / raw)
To: Amin Bandali; +Cc: emacs-devel
The example suggests "resubmit the patch in its entirety, as if the initially
submitted patch was never sent."
You mention "commits" and "rebasing", but I fail to see how any branch-related notions
apply here.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: revising a [PATCH]
2019-11-20 17:58 ` dick.r.chiang
@ 2019-11-20 18:20 ` Robert Pluim
0 siblings, 0 replies; 4+ messages in thread
From: Robert Pluim @ 2019-11-20 18:20 UTC (permalink / raw)
To: dick.r.chiang; +Cc: Amin Bandali, emacs-devel
>>>>> On Wed, 20 Nov 2019 12:58:00 -0500, dick.r.chiang@gmail.com said:
dick> The example suggests "resubmit the patch in its entirety, as if the initially
dick> submitted patch was never sent."
dick> You mention "commits" and "rebasing", but I fail to see how any branch-related notions
dick> apply here.
The master branch will have evolved since the initial patch, so it
needs to be adjusted for its current state, which is the same as
rebasing a branch with one commit.
Robert
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-20 18:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-20 16:51 revising a [PATCH] dick.r.chiang
2019-11-20 17:23 ` Amin Bandali
2019-11-20 17:58 ` dick.r.chiang
2019-11-20 18:20 ` Robert Pluim
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).