From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix display box cursor under image with margins Date: Sat, 25 Apr 2020 12:22:42 +0100 Message-ID: <877dy3hksd.fsf@tcd.ie> References: <83imhwk7sr.fsf@gnu.org> <835zdn97k8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="38559"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Evgeny Zajcev , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 25 13:23:34 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jSIuE-0009uE-5f for ged-emacs-devel@m.gmane-mx.org; Sat, 25 Apr 2020 13:23:34 +0200 Original-Received: from localhost ([::1]:35242 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSIuD-0001RG-6a for ged-emacs-devel@m.gmane-mx.org; Sat, 25 Apr 2020 07:23:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48178) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSItT-0000Xm-4E for emacs-devel@gnu.org; Sat, 25 Apr 2020 07:22:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jSItS-0004Wy-P5 for emacs-devel@gnu.org; Sat, 25 Apr 2020 07:22:46 -0400 Original-Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:35171) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jSItS-0004Qc-CM for emacs-devel@gnu.org; Sat, 25 Apr 2020 07:22:46 -0400 Original-Received: by mail-wm1-x341.google.com with SMTP id r26so14658462wmh.0 for ; Sat, 25 Apr 2020 04:22:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=hWX6dbJsGZ44FBhiDTORU2/heMrRUYg5QGZSGP6LtD4=; b=sIJqoMmOOQFVCkWmrRl8pgFhSMxflQZFkVbgDgXlA1zCo68JZwIJTa7D0/kIsSfL1g 5PJruEiOlxaSRAmD9X5DdjSkAgfKN4+Pn1syrF+ZJx7occ7lmGa48WvOjZ6XLxIO/CcE 2bdvt0HSbkgRTeGycGLZmuS0K/LYM+cdowmMzaGv2Q42WV/W9qNzxDP6tr4FNwSkaEnI sjpMrLkGjpStuJg4Uy5Y7nAadRztiuxTzrSoq/+3j1XzY8Ey+DuS2biJGNWvvhfCQsao B1EWt9Rw6O3c3edSlZoJ1HBNuwwv5hQ9aL1+3kX422ftSBk/lkDBdpWAFV0UQdEfubIB B1HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=hWX6dbJsGZ44FBhiDTORU2/heMrRUYg5QGZSGP6LtD4=; b=DGvOI+V9eZuD7qMa29q0YJuNknD2eIuOrdIwrdF5kmB3tlU0byG+Vs6SebcJpgxVcP /UD/Cx8VA3cncoG9IWDvTAjw6YfWoS+Le/wxz3u15PU7vIUtRKHx6KaRhhD43XaOTeKL u0Q00dDTRCPiPPPdsuufi8lXP7LxLCTit4wAXvt81oDmgs3DDtrtPMa+P/oxoPafwtwS q3mICSni7L9xB1Hb6tCVJKLRc35BaFk3Lo5zRTJWDAg56zQpF+UW2brB6WQmUCkLZui9 aM1yBdm6FndGobdP4EAL957CZngCq/FPP32P6v3moXqi5C/Koae8b49OgS8BMiThoV69 sTeA== X-Gm-Message-State: AGi0Pubp1wdfjzZunDWDjXFiP0igaib9b0ukoRSViaUFbfjlqJSMG/94 fd6hwh2bOWG8YVgCQpGSjz9sQg== X-Google-Smtp-Source: APiQypJVAa5SleZr71iJnlovNg19P268JJlXwFQ/XYA2ntkaNVBKj4/W17KVoK/kFEZSp2Vg6/aMbQ== X-Received: by 2002:a1c:678a:: with SMTP id b132mr15849793wmc.107.1587813763707; Sat, 25 Apr 2020 04:22:43 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id j11sm12376544wrr.62.2020.04.25.04.22.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Apr 2020 04:22:43 -0700 (PDT) In-Reply-To: <835zdn97k8.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 25 Apr 2020 13:35:35 +0300") Received-SPF: none client-ip=2a00:1450:4864:20::341; envelope-from=contovob@tcd.ie; helo=mail-wm1-x341.google.com X-detected-operating-system: by eggs.gnu.org: Error: [-] PROGRAM ABORT : Malformed IPv6 address (bad octet value). Location : parse_addr6(), p0f-client.c:67 X-Received-From: 2a00:1450:4864:20::341 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:247766 Archived-At: Eli Zaretskii writes: >> From: Evgeny Zajcev >> Date: Sat, 18 Apr 2020 21:05:16 +0300 >> Cc: emacs-devel >> >> > Here is the patch to fix issue making cursor hollow under non-mask image, but containing margins. >> This >> > patch keeps box cursor to be box in case image has margins. >> >> Could you please give an example of such an image and what the results >> look like, before and after the patch? It's hard to understand the >> details of this otherwise. >> >> Here is first screenshot how hollow cursor looks on image with margin - >> http://lgarc.narod.ru/pics/emacs-hollow-cursor.png >> >> And here is how it looks with patch applied - http://lgarc.narod.ru/pics/emacs-box-cursor.png >> >> Without patch, look of the cursor won't change, it will remain being hollow > > Thanks. Frankly, I'm not sure the change is for the better. > > Does anyone else have an opinion? I think the existing hollow cursor makes it more obvious that the cursor is over an image; the latter doesn't really betray the fact that it's a cursor, at least to my eyes. That said, I wouldn't be opposed to new cursor types. -- Basil