From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 262d0c6: Mark some tests as expensive Date: Sat, 12 Sep 2020 14:11:40 +0200 Message-ID: <877dsz2o03.fsf@gnus.org> References: <20200910182904.20559.25935@vcs0.savannah.gnu.org> <20200910182905.F0E4520A2E@vcs0.savannah.gnu.org> <877dt0is0p.fsf@gmx.de> <83a6xve0vq.fsf@gnu.org> <87a6xv456t.fsf@gnus.org> <837dszdyqv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39494"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: stefan@marxist.se, emacs-devel@gnu.org, michael.albinus@gmx.de, mardani29@yahoo.es To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 12 14:13:11 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kH4P0-000ABT-FX for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Sep 2020 14:13:10 +0200 Original-Received: from localhost ([::1]:46956 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kH4Oz-00053W-GU for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Sep 2020 08:13:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60528) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kH4Nl-0003vT-42 for emacs-devel@gnu.org; Sat, 12 Sep 2020 08:11:53 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:51188) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kH4Nj-0004Tb-9e; Sat, 12 Sep 2020 08:11:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=l4bhe8ag8PLmhDMO6bGQprCoyhuiifqSHWFxtpG+bkw=; b=LKiW15cuptdtxTkUyVeqnPB5Mz Wr7iOjzzz8db6h4KEQi2+VAgB0MDArSs2NDSYpvij25zgNE6ZOdGilD2Pr2hhyHDxzR4tHbq5OYtK frZNkK7MzDhVzP8XDUTVHVQ2ZfHCHwZ5jwYYDUGcJP5zRjEqmwba/e5fD8oeY00vuMJ8=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kH4NZ-0006EL-Kb; Sat, 12 Sep 2020 14:11:44 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEXWq2TeuoyiYkxB LyT////lU39VAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+QJDAssFsd3H+MAAAGNSURBVDjLbZMBssMg CESRXEDzL2DgAvlw/7t1URNNG6bTZnzCsoQSRaRSSlZH1BJBI3CeyhbnblRyyWmCsnuPmnLKtKRs AyBllqJE2a+oZSaA7Dc4lwSiuxLiAq2/ohOktdtbAheOod4SGjB1E2kgdw/hwlRwKKL+nxeJv7hb dzDR8wnkCj2XptLmoijkavjcgDIFcOc+FI5EIBbCqUD+UMOTcaUOQJq/UG9jRAQgrlHHdBcAMRQQ 6ULRvUnNwofU3puT1AGYuJ+Fe3caF9wqziHL0hpcABoRTplhaAJtoEAj6jU3dM0b4qRywJI+AVzg coLEDyDBOuUXwCnejxgG+dTg8EEab6x3pZcGRmiMZivjJYdzGQAJlWEPJ5sRvtGOD+sS2sb4wmxj O9puUmrL0o3QcbeFSac2fn12FYTbdn23extqpS+gIjNX3jP6851hPhdeV3A13W/pMsTxfwocLifQ AeB7BTZ+D+0D+imVMeKkv8D2mIy8ZABwjlX+BgR3+xtoC/ZWCvM9a4h/AOuenqUSokA1AAAAJXRF WHRkYXRlOmNyZWF0ZQAyMDIwLTA5LTEyVDExOjQ0OjIyKzAwOjAw/sjoUAAAACV0RVh0ZGF0ZTpt b2RpZnkAMjAyMC0wOS0xMlQxMTo0NDoyMiswMDowMI+VUOwAAAAASUVORK5CYII= X-Now-Playing: Joni Mitchell's _Clouds_: "I Think I Understand" In-Reply-To: <837dszdyqv.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 12 Sep 2020 14:24:08 +0300") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255315 Archived-At: Eli Zaretskii writes: > How will that work if the change was in Tramp, or was related to > Tramp? In my case, for example, it would most probably mean none of > the Tramp tests will ever run at all, because they all take more than > 1 sec down here. > > Also, there are some tests with inherent delays (auto-revert tests are > one example, but there are others) -- would that mean we don't run > these, either? Yes, if they take more than a second to run. We've already made this decision with all the tests previously marked as expensive, so there's nothing new here. We are formalising what counts as a "too slow" test for the default "make check" case. We could add more levels -- we now only have "normal" and "expensive", right? We could add an in-between level, "quite-expensive" or whatever. > What I do for a "fast test" use case is to run only the tests directly > related to the change, usually the FOO-tests.el tests that correspond > to the file FOO I've changed. Sometimes, there are related tests in > other files as well. A simple "make FOO-tests" command is all that's > needed. I do that, too, when working on something specific. But being able to say "make check" gives me greater confidence that I've not messed up something in a related area (and let's face it, the entirety of Emacs is "a related area" :-)). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no