From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Redisplay slower in Emacs 28 than Emacs 27 Date: Mon, 07 Dec 2020 16:04:08 +0100 Message-ID: <877dptiro7.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18496"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Gregory Heytings To: Gregory Heytings via "Emacs development discussions." Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 07 16:05:58 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmI5O-0004fS-Ay for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Dec 2020 16:05:58 +0100 Original-Received: from localhost ([::1]:41696 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmI5N-0004Py-Cw for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Dec 2020 10:05:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34466) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmI3l-0003rs-Ol for emacs-devel@gnu.org; Mon, 07 Dec 2020 10:04:17 -0500 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:55886) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmI3j-00051v-GH for emacs-devel@gnu.org; Mon, 07 Dec 2020 10:04:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=SK//GYJhZd4PJfZBOcRS8Azt39L+P+7h4DdTlZXyo2Q=; b=cBseESfX8N3ckVlQWjpC8OkYPY AQhwvIPZC7+7eGXZtrTFBhazUhLjWpkxa5vPlzo3AgpM8JA8SGnofwrJm9KgK4yAMISA1pHmp1r1Z Spcv48vV4vOSy/ppNE8sqpsr982ARB58tu9QtgRvCZmaFPI9VflF7fchyHDPXcUs96Es=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmI3d-0006fs-A2; Mon, 07 Dec 2020 16:04:12 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEWxiF2YckxJQiaI Yjv///9BI6RqAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+QMBw4vJD2n1zoAAAGmSURBVDjLfZQBcsQg CEW1uQDICSIXELn/3fpBk8222zKzM5onCB/cUpiZuGwjrpxWCvdlUz1s7zrdoHfvrvMNxDFfDj5z E6D2rj1+imjqc14AHvzLZnq8At/2L+AbTJWPwJmrX2fmKHwucAoxW9ugjdvDcN64/QqlDpVE1i36 Bgz5o0CFMoiYocSdxzR3m6ekstujYlnxuaBiS/U3iCUyHQGcYtcWkIgvUwwKpsTWJoDm5e5aR/QJ +ndtbWWl8eEsxaJrbuLtSjf89SAXiJGhnlqp1Gx5hnpTl2Tu1Q8wxD8DK/IJqJMJL58EsupAiURr DgLMy+OsoV3Z5BGKsMBgBJAnCB2hcYwy0dx3BDgL+QhZDzi1h8dZKRtRxQ97goEuVIDoJWcMW7Ij JYr3c6AUDATSteVRx4EVKAHkF76BlJhEcbENcqir4Rmas8eo8MTlHOnihVglOkRscI1xbCtUV45p q0hWoD3A3B4n+6gJGQ23pjfAaOBkFoFLvi4PJIJZR1RUkn8AttJFWtdji6HCcWzDY5u+vcIHWE/s Bbh/NC78h/0JvgH7fYPLB098OgAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMC0xMi0wN1QxNDo0Nzoz NiswMDowMAJacvIAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMTItMDdUMTQ6NDc6MzYrMDA6MDBz B8pOAAAAAElFTkSuQmCC X-Now-Playing: Shirley Collins's _Heart's Ease_: "Locked In Ice" In-Reply-To: (Gregory Heytings via's message of "Mon, 07 Dec 2020 14:53:01 +0000") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:260478 Archived-At: Gregory Heytings via "Emacs development discussions." writes: > Following the "The Emacs master is much slower than the emacs-27 > branch." thread, I tested Alan's benchmark on the master branch. The > platform I used is a 64-bit GNU/Linux computer, with GCC 10.2. > > It turns out that the 10-15% slowdown of redisplay in Emacs 28, > compared to Emacs 27, is due to a single character change, namely the > "!" character removed in commit 165fd028. That sounds rather odd, because the code in question is this: for (img = c->buckets[i]; img; img = img->next) if (img->hash == hash && equal_lists (img->spec, spec) And the ! removed was in front of the equal_list (which was reversed logically). In comparison, the code looks like this in Emacs 27: for (img = c->buckets[i]; img; img = img->next) if (img->hash == hash && !NILP (Fequal (img->spec, spec)) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no