From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Revert recent buggy font-locking changes in python.el Date: Thu, 04 Mar 2021 12:31:54 +0100 Message-ID: <877dmnw3x1.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7028"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Doug Davis Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 04 12:34:40 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHmFc-0001i3-BB for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Mar 2021 12:34:40 +0100 Original-Received: from localhost ([::1]:59386 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHmFb-0007ZZ-Bd for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Mar 2021 06:34:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38966) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHmD4-0005mO-8q for emacs-devel@gnu.org; Thu, 04 Mar 2021 06:32:02 -0500 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:39242) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHmD2-00028o-LT for emacs-devel@gnu.org; Thu, 04 Mar 2021 06:32:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=axnH+mBEBVqhe4AuVIVX9XbVq2qPK2nHeqVfMQSFhyg=; b=fhflk3ytS5/oMOdPaWxT3xAt8v OlsreGXNEFOTo68xRaYKR1GqtDipx37mLnqfrSQvzTCRWcC7dvjLU2jxHmtOeAZLBlOz03EBcszrn wF/bxqfs5J8fyYpK+JsbbpkdfwrT15MiLExoutWs0vFhibVySElZUrAjYkqfrrriD2vQ=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHmCx-0002I8-Eu; Thu, 04 Mar 2021 12:31:58 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEUwGA+kTy7olFT/ //+IyZgpAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+UDBAoxAIlVT3IAAADuSURBVCjPjc8xbsMwDABA ETB/EP6HAerdQyjAmtMhekWf0KFTpw42EOuVJSlZdjrVg8QzRZEKYf9IpMeXM3DUGHaB3HpGIf9B mOkEeoEfQ+EzwrGRdxto9l8OpIet6CXgB4i4Zu5eUxG/bGvT2tR9JqvRF16nBk0IOea79pXJqzCt DqjYDOygVKyeR4PkzSBivfEhFUu4eD9DXIJo/G4XSFrAIA0otvsE+Yk3R9ClPHGihmiQivituDbk ohgbSilLzyh+GsDwiXzgAxg7GJh6DcNEaY0H8tbwZljzDrvgD+AVKZcBGBwp520Ae2T5BQcodEfp GrRSAAAAOGVYSWZNTQAqAAAACAABh2kABAAAAAEAAAAaAAAAAAACoAIABAAAAAEAAAGQoAMABAAA AAEAAAGQAAAAADj5TfYAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjEtMDMtMDRUMTA6NDk6MDArMDA6 MDC9EHEiAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIxLTAzLTA0VDEwOjQ5OjAwKzAwOjAwzE3JngAA ABJ0RVh0ZXhpZjpFeGlmT2Zmc2V0ADI2UxuiZQAAABh0RVh0ZXhpZjpQaXhlbFhEaW1lbnNpb24A NDAwQPmChgAAABh0RVh0ZXhpZjpQaXhlbFlEaW1lbnNpb24ANDAw3fZj8AAAAABJRU5ErkJggg== X-Now-Playing: Sam Amidon's _All Is Well_: "Prodigal Son" In-Reply-To: (Doug Davis's message of "Wed, 03 Mar 2021 16:28:45 -0500") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265944 Archived-At: Doug Davis writes: > (Bug#45679) and (Bug#46233) report buggy font-locking in python.el. I > was able to trace it back to b2ce94fa5e - but I haven't been able to > figure out _what_ the bug is (it's easy to trigger the issue, i.e. > trigger the wonky font-locking), but not obvious how it's happening). > > Would it be reasonable to revert those changes (the attached patch does > it)? I would also be happy to help solve the underlying issue (by > testing new patches or being pointed to any tips for debugging font > locking issues). The patch seemed to fix the issue in bug#45341, so it'd be better to try to determine what it doesn't get right instead of reverting outright. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no