unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Eli Zaretskii <eliz@gnu.org>
Cc: mattiase@acm.org, emacs-devel@gnu.org, rgm@gnu.org
Subject: Re: master 9e94509 3/3: Generate info/dir directly from any org sources
Date: Sat, 06 Mar 2021 17:21:51 +0000	[thread overview]
Message-ID: <877dmkryds.fsf@tcd.ie> (raw)
In-Reply-To: <834khowaa5.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 06 Mar 2021 17:51:14 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: "Basil L. Contovounesios" <contovob@tcd.ie>
>> Cc: Mattias Engdegård <mattiase@acm.org>,  rgm@gnu.org,
>>   emacs-devel@gnu.org
>> Date: Sat, 06 Mar 2021 15:31:58 +0000
>> 
>>  texi_misc = $(shell ${MAKE} --no-print-directory -s -C doc/misc echo-sources)
>>  
>>  srcdir_doc_info_dir_inputs = \
>>    ${srcdir}/doc/emacs/emacs.texi \
>>    ${srcdir}/doc/lispintro/emacs-lisp-intro.texi \
>>    ${srcdir}/doc/lispref/elisp.texi \
>> -  $(addprefix ${srcdir}/doc/misc/,${texi_misc})
>> +  $(addprefix ${srcdir}/doc/misc/,$(filter %.texi %.org,${texi_misc}))
>
> This only works if the other output is interspersed "at word level",
> i.e. you don't have characters from one Make mixed up with those of
> another inside a single word.  Right?

Right.  (Though in practice it WFM™.)

> Why do we need to use $(shell) at all?

Ideally we shouldn't.  Even capturing the output of a sub-make recipe
e.g. with $(eval ...) would be better, since that would play better with
the jobserver.

> Can't we use $(wildcard) to
> the same effect without starting another process?  If the problem is
> that some *.texi files are generated, and we don't want them in the
> list, how about generating them in a subdirectory of doc/misc/?

Either sounds fine to me, but I don't understand well enough Glenn's
changes or how these recipes should work to be of much help with that.

Thanks,

-- 
Basil



  reply	other threads:[~2021-03-06 17:21 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210304184723.8249.29253@vcs0.savannah.gnu.org>
     [not found] ` <20210304184725.15B2320E1B@vcs0.savannah.gnu.org>
2021-03-05 12:03   ` master 9e94509 3/3: Generate info/dir directly from any org sources Basil L. Contovounesios
2021-03-05 19:17     ` Glenn Morris
2021-03-06 11:51       ` Basil L. Contovounesios
2021-03-06 13:49         ` Lars Ingebrigtsen
2021-03-06 14:09           ` Basil L. Contovounesios
2021-03-06 14:16         ` Mattias Engdegård
2021-03-06 14:51           ` Eli Zaretskii
2021-03-06 15:31             ` Basil L. Contovounesios
2021-03-06 15:51               ` Eli Zaretskii
2021-03-06 17:21                 ` Basil L. Contovounesios [this message]
2021-03-06 17:23               ` Andreas Schwab
2021-03-06 17:37                 ` Basil L. Contovounesios
2021-03-06 18:10                   ` Andreas Schwab
2021-03-06 18:34                     ` Basil L. Contovounesios
2021-03-06 17:28         ` Glenn Morris
2021-03-06 17:41           ` Basil L. Contovounesios
2021-03-06 17:47             ` Glenn Morris
2021-03-06 19:12               ` Glenn Morris
2021-03-06 20:15                 ` Basil L. Contovounesios
2022-01-05 16:58                   ` Philipp Stephani
2022-01-05 17:09                     ` Eli Zaretskii
2021-03-06 20:40                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dmkryds.fsf@tcd.ie \
    --to=contovob@tcd.ie \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=mattiase@acm.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).