From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrew Cohen Newsgroups: gmane.emacs.devel Subject: Re: News from the lexical world Date: Tue, 27 Apr 2021 07:31:30 +0800 Organization: Hong Kong University of Science and Technology Message-ID: <877dkor5bh.fsf@ust.hk> References: <87o8e1pmog.fsf@ust.hk> <87v989qmg4.fsf@ust.hk> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36782"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: emacs-devel@gnu.org Cancel-Lock: sha1:qRqUlB1i6WwdCyeU3F0imhynwME= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 27 01:32:42 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lbAiX-0009Ll-IL for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Apr 2021 01:32:41 +0200 Original-Received: from localhost ([::1]:45298 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbAiW-0003eR-Le for ged-emacs-devel@m.gmane-mx.org; Mon, 26 Apr 2021 19:32:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37490) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbAhf-0003AC-Jz for emacs-devel@gnu.org; Mon, 26 Apr 2021 19:31:47 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]:60762) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbAhd-0003kf-Im for emacs-devel@gnu.org; Mon, 26 Apr 2021 19:31:47 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1lbAhb-0008KJ-2j for emacs-devel@gnu.org; Tue, 27 Apr 2021 01:31:43 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268507 Archived-At: >>>>> "SM" == Stefan Monnier writes: [...] >> (add-hook 'sc-attribs-postselect-hook (lambda () (setq >> bbdb-sc-last-attrib (if sc-downcase-p (downcase attribution) >> attribution)))) SM> Hmm... I can't find this code in the BBDB copy I have (from SM> elpa.git). Which version of BBDB do you have? I have the git version from https://git.savannah.nongnu.org/cgit/bbdb.git/ The code is in bbdb-sc.el ;; Insert our hooks ;; Dammit, supercite! It runs `sc-attribs-postselect-hook' in an ;; environment with the local variable `attribution' that we rely on. (with-no-warnings (defvar attribution)) ;;;###autoload (defun bbdb-insinuate-sc () "Hook BBDB into Supercite. Do not call this in your init file. Use `bbdb-initialize'. However, this is not the full story. See bbdb-sc.el for how to fully hook BBDB into Supercite." (add-hook 'sc-post-hook 'bbdb-sc-set-attrib) (add-hook 'sc-attribs-postselect-hook (lambda () (setq bbdb-sc-last-attrib (if sc-downcase-p (downcase attribution) attribution))))) But I guess this is a more generic problem? Any function added to sc-attribs-postselect-hook will need access to 'attribution and/or 'citation which are not in scope. Best, Andy -- Andrew Cohen