From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jonas Bernoulli Newsgroups: gmane.emacs.devel Subject: Re: Adding transient to Emacs core Date: Tue, 27 Apr 2021 17:03:41 +0200 Message-ID: <877dknsraq.fsf@bernoul.li> References: <87czuqi86o.fsf@bernoul.li> <87pmyhdvla.fsf@bernoul.li> <20210426.230318.88708181443886760.enometh@meer.net> <878s54m7ae.fsf@bernoul.li> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23254"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: martin rudalics , Madhu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 27 17:11:09 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lbPMj-0005vk-6c for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Apr 2021 17:11:09 +0200 Original-Received: from localhost ([::1]:54126 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbPMi-0005T8-26 for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Apr 2021 11:11:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53116) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbPFk-0006ej-E7 for emacs-devel@gnu.org; Tue, 27 Apr 2021 11:04:00 -0400 Original-Received: from mail.hostpark.net ([212.243.197.30]:46720) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbPFf-0007hY-WB for emacs-devel@gnu.org; Tue, 27 Apr 2021 11:03:56 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 8A77316112; Tue, 27 Apr 2021 17:03:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-type:content-type:mime-version:message-id:date:date :references:in-reply-to:subject:subject:from:from:received :received; s=sel2011a; t=1619535823; bh=VybgIGVyPAXPXVzkVYQB4xF/ Oworwv+UyNCGQKopLIw=; b=JjglroXSaX5Rk8QCcc+DG3yaf/VYa/uKUC62q1wi 7ZPDquql1cvVi4k+7QWPwRs+M66aDnTrjX/6Uml3VFQyez6jCpBWUXfB9j10j4EV JJTHZm2ZoO9D9AGMTArhXi2ZbR3CLIitr6JxAKVTrKpi50hRbHM/j84dTElVtAvt H8s= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Original-Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id IFYUheXYUJo4; Tue, 27 Apr 2021 17:03:43 +0200 (CEST) Original-Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 5D962160BA; Tue, 27 Apr 2021 17:03:43 +0200 (CEST) In-Reply-To: Received-SPF: none client-ip=212.243.197.30; envelope-from=jonas@bernoul.li; helo=mail.hostpark.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268532 Archived-At: martin rudalics writes: > >> If you say that (pop-up-windows nil) is not a valid customization, I > >> would strongly disagree with that. > > > > I have addressed this by let-binding that variable to t around the call > > to display-buffer. There's just no way around that because transient's > > buffer just has to be displayed somewhere other than the selected > > window. > > This would constitute a major bug in `display-buffer' - `pop-up-windows' > is semi-obsolete ("provided for backward compatibility only"). The > canonical way to do what you want is to provide an > > (inhibit-same-window . t) > > action alist entry. We were already using (inhibit-same-window . t) and indeed if I remove the let-binding, then things continue to function. I am removing this unnecessary kludge again.