From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 2) Date: Sat, 01 May 2021 22:57:16 +0300 Organization: LINKOV.NET Message-ID: <877dkirzvn.fsf@mail.linkov.net> References: <0bbdeece-90d5-160c-07ec-2ad8edbf9872@daniel-mendler.de> <87czudm7bv.fsf@mail.linkov.net> <976056e8-3d46-db27-32c2-ddf3ca32d5a7@daniel-mendler.de> <878s5090e9.fsf@mail.linkov.net> <69fd42ed-a1a0-adcb-ac8b-caad80cb0967@daniel-mendler.de> <24f3b5e7-3e5e-d00f-3fc4-9d093ca1dc10@daniel-mendler.de> <87fsz7wvu5.fsf@mail.linkov.net> <46a170c1-7d81-8ed5-e61a-d8193b640d16@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2281"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Gregory Heytings , Dmitry Gutov , Stefan Monnier , "emacs-devel@gnu.org" To: Daniel Mendler Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 01 22:36:57 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lcwMB-0000PM-Gq for ged-emacs-devel@m.gmane-mx.org; Sat, 01 May 2021 22:36:55 +0200 Original-Received: from localhost ([::1]:45092 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcwMA-0000aV-KM for ged-emacs-devel@m.gmane-mx.org; Sat, 01 May 2021 16:36:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33652) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcwIz-0005uP-2x for emacs-devel@gnu.org; Sat, 01 May 2021 16:33:37 -0400 Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]:56921) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcwIx-0001nW-50 for emacs-devel@gnu.org; Sat, 01 May 2021 16:33:36 -0400 X-Originating-IP: 91.129.102.166 Original-Received: from mail.gandi.net (m91-129-102-166.cust.tele2.ee [91.129.102.166]) (Authenticated sender: juri@linkov.net) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id E9137C0002; Sat, 1 May 2021 20:33:30 +0000 (UTC) In-Reply-To: (Daniel Mendler's message of "Fri, 30 Apr 2021 20:30:48 +0200") Received-SPF: pass client-ip=217.70.183.198; envelope-from=juri@linkov.net; helo=relay6-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268734 Archived-At: >>> Thanks, I tested the vertical and horizontal format, >>> and the horizontal format is displayed nicely, but I expected >>> that in the vertical format completions inside every group >>> to be arranged the same way as in horizontal format, e.g. >>> everything is fine in the horizontal format: >> >> Yes, this is intentional. I assume that one would want to have headers >> per column as in a two column paper layout for example. We can also use >> the different layout if that is preferred. > > I believe the arrangement I am using in the current patch is is the more > natural one. > > What you proposed for the vertical layout would look like this > > v /--\ /--\ > v | | | | > | | | | v > \--/ \--/ v > ============= > v /--\ /--\ > v | | | | > | | | | v > \--/ \--/ v > ============= > v /--\ /--\ > v | | | | > | | | | v > \--/ \--/ v > > This seems to me like a mix of vertical and horizontal layout. It's still the vertical layout but with grouping similar to how you sort candidates in every group, only here the per-group candidates are arranged vertically. Maybe this choice could be handled by an option?