From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Bastien Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default Date: Wed, 19 May 2021 13:59:04 +0200 Organization: GNU Message-ID: <877djvylx3.fsf@gnu.org> References: <1df50c0d035675f851387d689030d588@purelymail.com> <87k0nw1qaq.fsf@red-bean.com> <878s4cf74z.fsf@gnus.org> <835yzgrtsi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17010"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: kfogel@red-bean.com, Lars Ingebrigtsen , pwr@bydasein.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 19 14:00:15 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ljKs2-000455-N7 for ged-emacs-devel@m.gmane-mx.org; Wed, 19 May 2021 14:00:14 +0200 Original-Received: from localhost ([::1]:51974 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljKs1-0001XP-H9 for ged-emacs-devel@m.gmane-mx.org; Wed, 19 May 2021 08:00:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47878) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljKr0-0000pw-U3 for emacs-devel@gnu.org; Wed, 19 May 2021 07:59:10 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45712) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljKqz-0003DA-W5; Wed, 19 May 2021 07:59:10 -0400 Original-Received: from [78.194.183.21] (port=51752 helo=guerry) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljKqw-0003Fm-1z; Wed, 19 May 2021 07:59:09 -0400 Original-Received: by guerry (Postfix, from userid 1000) id 26EDD1A60479; Wed, 19 May 2021 13:59:04 +0200 (CEST) In-Reply-To: <835yzgrtsi.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 18 May 2021 17:38:37 +0300") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269472 Archived-At: Eli Zaretskii writes: >> From: Lars Ingebrigtsen >> Date: Tue, 18 May 2021 16:28:44 +0200 >> Cc: Karl Fogel , "Paul W. Rankin" , >> "Paul W. Rankin via Emacs development discussions." >> >> Eli Zaretskii writes: >> >> > Please don't make this change until you hear from Lars, who examined >> > the original patch and decided to install it. It doesn't get more >> > "considerate" than that. >> >> It does seem to be an unexpectedly (to me, at least) controversial >> change, so perhaps it should be tweaked. For instance, using fringe >> markers (on frames that support that) instead of highlighting the entire >> line, or something else that isn't that stark. > > I guess so, yes. FWIW I'd prefer a fringe marker than the current fontification. One problem I've seen while testing this feature for the last weeks is that editing text within the fontified region will (expectedly) expand the fontified part, questioning the very idea of having an "area" for indicating where the bookmark points. A fringe marker for the line where this point is seems useful enough. 2 cents, -- Bastien