From: Bastien <bzg@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: kfogel@red-bean.com, Lars Ingebrigtsen <larsi@gnus.org>,
pwr@bydasein.com, emacs-devel@gnu.org
Subject: Re: [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default
Date: Wed, 19 May 2021 13:59:04 +0200 [thread overview]
Message-ID: <877djvylx3.fsf@gnu.org> (raw)
In-Reply-To: <835yzgrtsi.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 18 May 2021 17:38:37 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Lars Ingebrigtsen <larsi@gnus.org>
>> Date: Tue, 18 May 2021 16:28:44 +0200
>> Cc: Karl Fogel <kfogel@red-bean.com>, "Paul W. Rankin" <pwr@bydasein.com>,
>> "Paul W. Rankin via Emacs development discussions." <emacs-devel@gnu.org>
>>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>> > Please don't make this change until you hear from Lars, who examined
>> > the original patch and decided to install it. It doesn't get more
>> > "considerate" than that.
>>
>> It does seem to be an unexpectedly (to me, at least) controversial
>> change, so perhaps it should be tweaked. For instance, using fringe
>> markers (on frames that support that) instead of highlighting the entire
>> line, or something else that isn't that stark.
>
> I guess so, yes.
FWIW I'd prefer a fringe marker than the current fontification.
One problem I've seen while testing this feature for the last weeks is
that editing text within the fontified region will (expectedly) expand
the fontified part, questioning the very idea of having an "area" for
indicating where the bookmark points.
A fringe marker for the line where this point is seems useful enough.
2 cents,
--
Bastien
next prev parent reply other threads:[~2021-05-19 11:59 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 6:20 [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default Paul W. Rankin via Emacs development discussions.
2021-05-18 6:58 ` Karl Fogel
2021-05-18 8:17 ` Paul W. Rankin via Emacs development discussions.
2021-05-18 8:45 ` Eli Zaretskii
2021-05-18 10:06 ` Paul W. Rankin via Emacs development discussions.
2021-05-18 12:09 ` Eli Zaretskii
2021-05-18 12:04 ` Eli Zaretskii
2021-05-18 14:28 ` Lars Ingebrigtsen
2021-05-18 14:38 ` Eli Zaretskii
2021-05-18 14:40 ` Lars Ingebrigtsen
2021-05-19 11:59 ` Bastien [this message]
2021-05-19 13:55 ` Eli Zaretskii
2021-05-24 22:32 ` Lars Ingebrigtsen
2021-05-24 22:51 ` [External] : " Drew Adams
2021-05-18 14:43 ` Drew Adams
2021-05-18 15:07 ` Eli Zaretskii
2021-09-13 9:46 ` Stefan Kangas
2021-09-13 9:58 ` Manuel Uberti
2021-09-13 10:17 ` Stefan Kangas
2021-09-13 10:12 ` Colin Baxter
2021-09-13 15:29 ` [External] : " Drew Adams
2021-09-13 10:43 ` Adam Porter
2021-09-13 11:36 ` Lars Ingebrigtsen
2021-09-13 19:36 ` Matthias Meulien
2021-09-14 5:40 ` Colin Baxter
2021-09-14 11:15 ` Lars Ingebrigtsen
2021-09-14 11:46 ` Eli Zaretskii
2021-09-14 11:54 ` Lars Ingebrigtsen
2021-09-14 11:52 ` miha
2021-09-14 11:56 ` Lars Ingebrigtsen
2021-09-14 14:44 ` miha
2021-09-15 7:59 ` Lars Ingebrigtsen
2021-05-18 10:49 ` Basil L. Contovounesios
2021-05-18 11:08 ` Paul W. Rankin via Emacs development discussions.
2021-05-19 12:00 ` Bastien
2021-05-19 12:58 ` Gregor Zattler
2021-05-18 10:49 ` Basil L. Contovounesios
2021-05-19 12:00 ` Paul W. Rankin via Emacs development discussions.
2021-05-19 14:15 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877djvylx3.fsf@gnu.org \
--to=bzg@gnu.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=kfogel@red-bean.com \
--cc=larsi@gnus.org \
--cc=pwr@bydasein.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).