From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Crash with --enable-checking and some glyphs Date: Sat, 27 Nov 2021 15:04:56 +0100 Message-ID: <877dctsnhz.fsf@gnus.org> References: <87h7c1u0cg.fsf@gnus.org> <87wnkxskvn.fsf@gnus.org> <87zgpt63m3.fsf@gnus.org> <83mtlt8vil.fsf@gnu.org> <87v90h6271.fsf@gnus.org> <83lf1d8uyw.fsf@gnu.org> <87r1b561kn.fsf@gnus.org> <871r35ziyl.fsf@gnus.org> <87sfvlwkrc.fsf_-_@gnus.org> <87sfvlh1zo.fsf@gmail.com> <87h7c0flfk.fsf@gnus.org> <874k807166.fsf@gmail.com> <87wnkwb8q7.fsf@gnus.org> <87sfvkb85w.fsf@gnus.org> <83wnkw469i.fsf@gnu.org> <87ee739kjx.fsf@gnus.org> <83h7bz2i9f.fsf@gnu.org> <87mtlrt2ei.fsf@gnus.org> <838rxb2c8i.fsf@gnu.org> <87a6hrt0ti.fsf@gnus.org> <8335ni3mr4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37868"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: rpluim@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 27 15:06:17 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mqyLJ-0009fT-4m for ged-emacs-devel@m.gmane-mx.org; Sat, 27 Nov 2021 15:06:17 +0100 Original-Received: from localhost ([::1]:60214 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mqyLH-0004vB-Vb for ged-emacs-devel@m.gmane-mx.org; Sat, 27 Nov 2021 09:06:16 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54068) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqyKJ-00044t-9h for emacs-devel@gnu.org; Sat, 27 Nov 2021 09:05:15 -0500 Original-Received: from [2a01:4f9:2b:f0f::2] (port=52112 helo=quimby.gnus.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqyKF-0003HH-2K; Sat, 27 Nov 2021 09:05:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=O5PpRHKGcOxOco6f/oSxPABhRLMcdBvSNmPzcica4RM=; b=KPXZd5fhDXnWjxD7Z13ajYA8P4 1fYJM2jhH2EuVbfOZZnzBbtfWwEBeucu3eC6GPRoNcQbN2xoTAqQuKrvoIcJr3Lj3ZiZSjq97rtwB 64hRY24cG2KHWGX+TrGKeLB7Np7FpYa7ncEgdklrkdJJ8JTZpdJVbn3qIvXRoBhMjOH4=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mqyK0-00016R-Vs; Sat, 27 Nov 2021 15:05:00 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEXWq2TeuoyiYkxB LyT////lU39VAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+ULGw4BKFylda8AAAGNSURBVDjLbZMBssMg CESRXEDzL2DgAvlw/7t1URNNG6bTZnzCsoQSRaRSSlZH1BJBI3CeyhbnblRyyWmCsnuPmnLKtKRs AyBllqJE2a+oZSaA7Dc4lwSiuxLiAq2/ohOktdtbAheOod4SGjB1E2kgdw/hwlRwKKL+nxeJv7hb dzDR8wnkCj2XptLmoijkavjcgDIFcOc+FI5EIBbCqUD+UMOTcaUOQJq/UG9jRAQgrlHHdBcAMRQQ 6ULRvUnNwofU3puT1AGYuJ+Fe3caF9wqziHL0hpcABoRTplhaAJtoEAj6jU3dM0b4qRywJI+AVzg coLEDyDBOuUXwCnejxgG+dTg8EEab6x3pZcGRmiMZivjJYdzGQAJlWEPJ5sRvtGOD+sS2sb4wmxj O9puUmrL0o3QcbeFSac2fn12FYTbdn23extqpS+gIjNX3jP6851hPhdeV3A13W/pMsTxfwocLifQ AeB7BTZ+D+0D+imVMeKkv8D2mIy8ZABwjlX+BgR3+xtoC/ZWCvM9a4h/AOuenqUSokA1AAAAJXRF WHRkYXRlOmNyZWF0ZQAyMDIxLTExLTI3VDE0OjAxOjQwKzAwOjAwtso/ugAAACV0RVh0ZGF0ZTpt b2RpZnkAMjAyMS0xMS0yN1QxNDowMTo0MCswMDowMMeXhwYAAAAASUVORK5CYII= X-Now-Playing: Joni Mitchell's _Clouds_: "I Think I Understand" In-Reply-To: <8335ni3mr4.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 26 Nov 2021 18:27:59 +0200") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a01:4f9:2b:f0f::2 (failed) Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280338 Archived-At: Eli Zaretskii writes: > But what about the font? We don't use the above for it->descent, at > least not directly. So where in the code did it->descent get > negative? (gdb) p font->descent $14 = 2 (gdb) print boff $15 = 3 I think it has to be from here: if (it->char_to_display != '\n' && it->char_to_display != '\t') { it->nglyphs = 1; if (it->override_ascent >= 0) { it->ascent = it->override_ascent; it->descent = it->override_descent; boff = it->override_boff; } else { it->ascent = FONT_BASE (font) + boff; it->descent = FONT_DESCENT (font) - boff; } And boff is 3 because of: boff = font->baseline_offset; if (font->vertical_centering) boff = VCENTER_BASELINE_OFFSET (font, it->f) - boff; (gdb) print font->vertical_centering $17 = true And we don't apply these sanity checks in this case: /* These limitations are enforced by an assertion near the end of this function. */ if (it->ascent < 0) it->ascent = 0; if (it->descent < 0) it->descent = 0; -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no