From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuri D'Elia Newsgroups: gmane.emacs.devel Subject: Re: Incorrect font weight selected Date: Thu, 06 Jan 2022 00:16:15 +0100 Message-ID: <877dbdvjga.fsf@wavexx.thregr.org> References: <87pmpv708h.fsf@wavexx.thregr.org> <83r1abcb93.fsf@gnu.org> <87y24jqahr.fsf@wavexx.thregr.org> <83ilvnc6z4.fsf@gnu.org> <875yrmyk8q.fsf@wavexx.thregr.org> <87y24grwp6.fsf@wavexx.thregr.org> <877dbzo98z.fsf@gnus.org> <83bl1b12b5.fsf@gnu.org> <837dbz112w.fsf@gnu.org> <71a9cd97-02a6-79d7-6af8-b4aef3d1baa8@yandex.ru> <83y24eyww3.fsf@gnu.org> <87wnjyt9yd.fsf@wavexx.thregr.org> <83sfumyr9c.fsf@gnu.org> <877dbe86tv.fsf@wavexx.thregr.org> <83ee5m9kp7.fsf@gnu.org> <87r19mulkg.fsf@wavexx.thregr.org> <83bl0q9hz6.fsf@gnu.org> <87mtkaujbs.fsf@wavexx.thregr.org> <838rvu9f35.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26430"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.7.5; emacs 29.0.50 Cc: larsi@gnus.org, emacs-devel@gnu.org, monnier@iro.umontreal.ca, dgutov@yandex.ru To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 06 00:42:46 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n5FvZ-0006jU-PH for ged-emacs-devel@m.gmane-mx.org; Thu, 06 Jan 2022 00:42:45 +0100 Original-Received: from localhost ([::1]:40584 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5FvY-0001FE-N7 for ged-emacs-devel@m.gmane-mx.org; Wed, 05 Jan 2022 18:42:44 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38094) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5Fuw-0000a4-7B for emacs-devel@gnu.org; Wed, 05 Jan 2022 18:42:06 -0500 Original-Received: from [2001:41c9:1:41f::63] (port=33324 helo=erc.thregr.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5Fuu-0002o4-Fe; Wed, 05 Jan 2022 18:42:05 -0500 Original-Received: from [2.198.4.140] (helo=localhost) by erc.thregr.org with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) id 1n5Fv0-001rPs-1S (envelope-from ); Thu, 06 Jan 2022 00:42:10 +0100 In-reply-to: <838rvu9f35.fsf@gnu.org> X-Host-Lookup-Failed: Reverse DNS lookup failed for 2001:41c9:1:41f::63 (failed) Received-SPF: pass client-ip=2001:41c9:1:41f::63; envelope-from=wavexx@thregr.org; helo=erc.thregr.org X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284275 Archived-At: On Wed, Jan 05 2022, Eli Zaretskii wrote: > When we look at low-level code such as this one, we should always keep > that in mind, and avoid leaking the face definitions to other frames. > The trick of making the change take effect on other frames is > implemented by higher levels. Do you have a more concrete overview of how the change _should_ at least ideally be propagated for me to get a better overview? One side-effect of pushing a few set-face-font calls in a after-make-frame hook in my setup (as opposed to calling set-face-font once) was a noticeable increase of time required to show the resulting frame, which is not too nice to have. > This is the general background that makes me uneasy to accept the > changes which you suggested, because they seem to violate that general > principle on a very low level. In this sense, the change only fixes the lower-level font selection when opening a face in a single frame, so it doesn't alter how we're propagating the change at all at the moment.