From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 2b97e83cc1 2/2: Fix off-by-one file size formatting in ls-lisp Date: Sat, 12 Feb 2022 18:33:14 +0100 Message-ID: <877da00z39.fsf@gnus.org> References: <164464970577.18616.16858189491672331595@vcs2.savannah.gnu.org> <20220212070826.4B772C00895@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25263"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Feb 12 18:34:20 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIwHs-0006Kq-BG for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Feb 2022 18:34:20 +0100 Original-Received: from localhost ([::1]:44150 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nIwHq-0008G1-Rb for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Feb 2022 12:34:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39954) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nIwH0-0007Xz-JS for emacs-devel@gnu.org; Sat, 12 Feb 2022 12:33:26 -0500 Original-Received: from [2a01:4f9:2b:f0f::2] (port=34088 helo=quimby.gnus.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nIwGw-0005Gm-T2 for emacs-devel@gnu.org; Sat, 12 Feb 2022 12:33:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=FVMb/cq/CqlAcT0mLx+DRkLvdTI7LN2uw5kSp8rRKCk=; b=cZgjj/0nulIOWCpmgwhaFB3ejT T1RHn3QzOzFiqjWBZhWwLTyvHTX3wf2bLefHao3I4ZNdwBJGQgYW0SJr1NgXuQwmpcRdQWHvnT+en bI6s4ZUsYnrWbfm5Fa/KalxBtify5FKbd4nr3JdtC1XslmnCEPGea8xdtYUMlmh63l3Y=; Original-Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIwGp-0001O9-Ar; Sat, 12 Feb 2022 18:33:18 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEX03LSVgWXr2rwU DgheTjv////FslQwAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+YCDBEUNsAvNWwAAAGSSURBVDjLfZSL ba0wDIah6gC1yQBNYIEce4HE3n+m2uYQ0it6LUUR+cjvJyzLn7ZCBvC1Anz9Rh/ftpbvh0t240kL M5lhmS1A2RzU8+QAvIE44DjPDO0GRENrr5NUPkH3A2H8DZQDZFIoOID50PQGUHKfnDeAAAdpOXCS 6keJqHYL7ph9VCgRzmbpjHDXZElAPoMizq8BItZQzkr16EPKK8Lqj6BS97sku50LRz1UmvQ8AY1S baIta4cbsAQgA0XB6/v2oQF2FuUJrJY4eY02NsmiaYDohiiwbQZae4PPANqS+g6cFPEGppVFSCwM SAinlAZgEK+NmDfUE0Ail4dmO3trGp/AmuHvYknUvGdyAVXLgyyWjVLEofUCPj/N5+4cJKp3Htar ttNlrykPae0YoM8JYsEBKk43sNSYYYicpszxiJikC6Wab8CweZp02At98mHTcV70ofuniNfM7zam M7gC+gu8TKo8AYaij4BsdFN/ArUAJnwADPZ5pqtRbgrDlvVr/DNK8XUN5//tozz9XpYf84OP1yk2 CiQAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjItMDItMTJUMTc6MjA6NTQrMDA6MDBSwTM7AAAAJXRF WHRkYXRlOm1vZGlmeQAyMDIyLTAyLTEyVDE3OjIwOjU0KzAwOjAwI5yLhwAAAABJRU5ErkJggg== X-Now-Playing: Jon Eberson Group's _Stories_: "So Much Better" In-Reply-To: (Stefan Monnier's message of "Sat, 12 Feb 2022 12:25:51 -0500") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a01:4f9:2b:f0f::2 (failed) Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286185 Archived-At: Stefan Monnier writes: >> * lisp/ls-lisp.el (ls-lisp-format, ls-lisp-format-file-size): The >> human-readable file sizes can be 7 characters wide (e.g., >> "1016.1k") (bug#53937). > > Why would we want the ".1" in "1016.1k"? Perhaps we don't. For a file like -rw-r--r-- 1 larsi larsi 1029204 Feb 12 08:04 bytes ls-lisp displays -rw-r--r-- 1 larsi larsi 1005.1k Feb 12 08:04 bytes and ls displays -rw-r--r-- 1 larsi larsi 1006K Feb 12 08:04 bytes with "-lh". -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no