From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Akib Azmain Turja Newsgroups: gmane.emacs.devel Subject: Re: [Patch] Avoid recording chars when reading passwords Date: Sat, 18 Jun 2022 17:29:56 +0600 Message-ID: <877d5ep5u3.fsf@disroot.org> References: <87edzz8dzo.fsf@elite.giraud> <834k0v5f7z.fsf@gnu.org> <8735g7vb47.fsf@elite.giraud> <83bkuvtr3q.fsf@gnu.org> <83tu8nrvdb.fsf@gnu.org> <87ilp2z7a4.fsf@elite.giraud> <83bkuqnrwa.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17676"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii , Manuel Giraud Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 18 13:32:50 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o2Wh8-0004QX-H8 for ged-emacs-devel@m.gmane-mx.org; Sat, 18 Jun 2022 13:32:50 +0200 Original-Received: from localhost ([::1]:46298 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o2Wh7-0000RC-1t for ged-emacs-devel@m.gmane-mx.org; Sat, 18 Jun 2022 07:32:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43118) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2Wes-0007OR-61 for emacs-devel@gnu.org; Sat, 18 Jun 2022 07:30:30 -0400 Original-Received: from knopi.disroot.org ([178.21.23.139]:50212) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2Weo-000780-8T; Sat, 18 Jun 2022 07:30:29 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 57B4E44240; Sat, 18 Jun 2022 13:30:19 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Original-Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7iq0gEWLy7BW; Sat, 18 Jun 2022 13:30:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1655551817; bh=/XMdggwJj/kvY7in7lOeN2Qd0lFsTlDn8/vNhWzHH4g=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=LABcHW/rexm+Fiyl1GxNpHggKmfbHVapggZHy20/f6Er1p2nxKsR0ATSn0rXMVgO0 HZJcY6gUzy9y6SDPvcmGTMWbu2/29VTXNabLK0zNGlYmhCNYaMgKfKjYWSM26jSR96 TKJkmb0SP3DuvGxDDGBoC6JyaVB+t2JEjqWMl9xBwYe2QPvxskZo6INowcQ22XtVK4 aANPvWWt9+Tnel5c/CVECorXW2xLNPL5A5T/b5JEJVlDGV2Z52weqM+Mrbf3Ysr07H llbRpiyshQmhkt9ox3J053gAZYkeO6K/5LmLLIAonvsb6mmg5jOZvIpAJDDP+ke5HI zZOb6J+6Ngo2g== In-Reply-To: <83bkuqnrwa.fsf@gnu.org> Received-SPF: pass client-ip=178.21.23.139; envelope-from=akib@disroot.org; helo=knopi.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291354 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Eli Zaretskii writes: >> From: Manuel Giraud >> Cc: Stefan Monnier , emacs-devel@gnu.org >> Date: Wed, 15 Jun 2022 09:59:31 +0200 >>=20 >> Eli Zaretskii writes: >>=20 >> > The next question is: do we want to enable this by default and in a >> > way that users cannot have the previous behavior back? >>=20 >> I think that having this as a default is a good thing=E2=84=A2 (no more = clear >> password in lossage). About being able to revert this behaviour, I know >> I won't use it but maybe it has some use case with the dribble file: do >> people use the dribble file as some automation tool for example? >>=20 >> > In any case, this needs a NEWS entry, I think. >>=20 >> Ok, I'd one to this patch when we have decide the default and if it >> needs a user option. > > Sounds like having this on by default is what people want. But we > need a knob to revert to the previous behavior, and we need a NEWS > entry. Could you please prepare an updated patch with those two > additions? > > Thanks. > Yes, there should be an option to revert it, otherwise it'll break my "workflow"[1]. [1]: https://xkcd.com/1172/ =2D-=20 Akib Azmain Turja This message is signed by me with my GnuPG key. It's fingerprint is: 7001 8CE5 819F 17A3 BBA6 66AF E74F 0EFA 922A E7F5 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEyVTKmrtL6kNBe3FRVTX89U2IYWsFAmKttzQACgkQVTX89U2I YWuaGRAAi9d4cpwRuKWj39Lw3jgyxLjX14tum6XENG6sFk8grs05fs9lfevcUZwT v2OsBVpe2HB7jo7YVtR1/PQitu56uQzlcYXh4yVRSGbXUVfFAnXf3guKkMOqyKwg WzXtoFguxR520ni87qZy529klQ7WzgMdXz8LtSpxc/jlvYZXNEonk7sD8vPlCb5B 5TvgS8KgihV9NTkTPFWM0w+F9oOg8+9TzhQDqWQjFWIVkJHSSYnvl7BXxTjTbeKf jmb5lEZXwO3MYaR4Dej0Ule9nQJr0xO8MLd1pnUmWuwsxZkp/y438gHQed5NCO0q SD9A88cqVj38MN4lZzTgA1Q5oHNhXEevTjUdU1QFAv3sE3NeYNJzeJKD5oj8e0kr SyIuTX6U71wUBHmaqrRWG7tqEvZDW8QsCGtq8D4jcaGnV5xOuRUJnuHA76EPXNF7 gbnSqC/I+Xrhhb4GekGiiaKAvEv5e2oW0LVbwCwLOz/7S5gXumqIYAcq/8XWM50L YYnixpUJVuNa2HbkucczmKv3zbupM/TwB3mm8u4mX4iTblCenNgPl/z7HpJCMOIQ Ay7x8AKcrXUtgG1c6uwQBVUS8rCGh6TlXK9n59RH1pXt1nLDGHPy04ZDmtWlHiRk u8X+v0CDhIQxN9LtnGCLbihT9OlJ+IXQFm/nwHMdNsS4yz8pyrc= =q4xu -----END PGP SIGNATURE----- --=-=-=--