From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Add zuul.el package to ELPA Date: Wed, 31 Aug 2022 11:57:16 +0000 Message-ID: <877d2o8w2r.fsf@posteo.net> References: <874jxuj3q1.fsf@posteo.net> <87v8qaumrh.fsf@posteo.net> <87pmgh1pbf.fsf@posteo.net> <87edwx755s.fsf@posteo.net> <87wnao6566.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27343"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Niklas Eklund Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Aug 31 14:00:10 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oTMO9-0006vp-MH for ged-emacs-devel@m.gmane-mx.org; Wed, 31 Aug 2022 14:00:09 +0200 Original-Received: from localhost ([::1]:48956 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oTMO8-0005la-PG for ged-emacs-devel@m.gmane-mx.org; Wed, 31 Aug 2022 08:00:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41174) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTMLh-00043y-Gm for emacs-devel@gnu.org; Wed, 31 Aug 2022 07:57:37 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:46061) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTMLW-0007H1-Im for emacs-devel@gnu.org; Wed, 31 Aug 2022 07:57:34 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 811E5240101 for ; Wed, 31 Aug 2022 13:57:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1661947040; bh=ETL4RuSU/gcSwHus1NjsUebJTrhRQYsgGAdaVQEU0ow=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=Mrmg6Jvheps8Y/vwrgczbkCxPrlDCrK0vC1EXDEqLSsSbjA6BCPGQakD3PW2njPS3 y4EC1OmlBUEvRHr8ADQ37rTLMYe5aPFOY92gpJ8qpxySokHKQAy2kBbp1dVj3B2ag2 N4ULJbQSjgEVChmvhWheB3FkqUXNO4G9ZaaO3MlYltGoqDf8/t5DSMrSKkionVmoBR 3tQrxXgxYRI3w8Eq5saV/vt/pNedxCz14okJiGhXdcvRubKqa8tSF0HLTuB61gQa+K ULSyZ3LVYdeVEztbbo3j/I4PY1F5l/iDBftu3edrnL7JyaSf3GCKl4E/OTXcg10nAj sFDq/2SF3lebw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MHjMz68XKz9rxV; Wed, 31 Aug 2022 13:57:17 +0200 (CEST) In-Reply-To: (Niklas Eklund's message of "Wed, 31 Aug 2022 11:44:13 +0000") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294421 Archived-At: Niklas Eklund writes: > Philip Kaludercic writes: > >> Niklas Eklund writes: >> >>> Niklas Eklund writes: >>> >>>> Philip Kaludercic writes: >>>> >>>>> Niklas Eklund writes: >>>>> >>>>>>> I believe if you used compat, you can reduce the minimal version of >>>>>>> Emacs down to 26.1, and the only hard dependency appears to be >>>>>>> project.el? >>> >>> One other thing I saw that package lint complained about, and that I >>> couldn't find in the compat package was with-connection-local-variables? >>> >>> 486:3: error: You should depend on (emacs "27.1") if you need >>> `with-connection-local-variables'. >>> >>> I see in the manual that it doesn't seem to be supported >>> https://git.sr.ht/~pkal/compat/tree/master/compat.texi#L1753. So I guess >>> I can lower it to 27.1 the most, but that would be a good win over 28.1 :) >> >> True, that is missing, but reading through the source in files-x.el, it >> *might* be possible to add that functionality in a backwards >> way? But if not, 27.1 is still a considerable improvement considering >> that Debian Stable is currently distributing that version. > > Absolutely, a great improvement! :) If that is added in the future that > would be even better of course, seems like that's the only thing > blocking the package from supporting 26. > > Once you have released a new version of compat I'll try to depend on > that. Would this patch be sufficient you think? (given that I update the > version of compat to the latest) > > From a698110e477a1e640b851f912601c67e19bea6b7 Mon Sep 17 00:00:00 2001 > From: Niklas Eklund > Date: Wed, 31 Aug 2022 13:38:06 +0200 > Subject: [PATCH] Use compat package to support older Emacs version > > This patch lowers the required Emacs version from 28.1 to 27.1. This > is done by using the compat package in combination with an explicit > dependency to the project package. > --- > zuul.el | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/zuul.el b/zuul.el > index f2b146c..34d4bf7 100644 > --- a/zuul.el > +++ b/zuul.el > @@ -5,7 +5,7 @@ > ;; Author: Niklas Eklund > ;; URL: https://git.sr.ht/~niklaseklund/zuul.el > ;; Version: 0.3 > -;; Package-Requires: ((emacs "28.1")) > +;; Package-Requires: ((emacs "27.1") (compat "2.1.2.2") (project "0.8.1")) > ;; Keywords: convenience tools > > ;; This file is not part of GNU Emacs. > @@ -41,6 +41,9 @@ > > (require 'ansi-color) > (require 'comint) > +(require 'compat) > +(require 'compat-27) > +(require 'compat-28) These two require statements aren't required, unless you depend on some function that has been updated between versions (e.g. assoc used to only take two arguments, and now takes 3, so to avoid overriding the old call compat provides a prefixed alternative "compat-assoc"). > (require 'project) > (eval-when-compile (require 'rx)) > (require 'subr-x) > @@ -770,7 +773,7 @@ Optionally provide extra parameters PARAMS, PARSER, METHOD, BUFFER or HEADERS." > "Parse the output of a json build." > (let ((build (zuul--request-json-parser))) > (string-join > - (flatten-list > + (flatten-tree > (seq-map #'zuul--build-playbook-output build)) > "\n")))