From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.devel Subject: Re: master 48aacbf292 2/2: Make many seldom-used generalized variables obsolete Date: Sun, 11 Sep 2022 10:11:04 -0700 Message-ID: <877d29hm53.fsf@melete.silentflame.com> References: <166111278304.2846.13033924580993120733@vcs2.savannah.gnu.org> <20220821201303.AD1E6C0088A@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1412"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: emacs-devel@gnu.org, Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 11 19:12:10 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXQV6-00007E-K7 for ged-emacs-devel@m.gmane-mx.org; Sun, 11 Sep 2022 19:12:10 +0200 Original-Received: from localhost ([::1]:59100 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oXQV5-0006jQ-9P for ged-emacs-devel@m.gmane-mx.org; Sun, 11 Sep 2022 13:12:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42088) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXQUC-0005rn-FL for emacs-devel@gnu.org; Sun, 11 Sep 2022 13:11:12 -0400 Original-Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:46315) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXQUA-0001jA-69 for emacs-devel@gnu.org; Sun, 11 Sep 2022 13:11:12 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 7DA5D3200034; Sun, 11 Sep 2022 13:11:06 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sun, 11 Sep 2022 13:11:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1662916266; x=1663002666; bh=ud6ULTVJvc RsjRGCLmCYiCWRPoIJjfRVUd0E8k+teIc=; b=s61gcLmzIUQFUkRP2DCWpqSiLu UWd9swUk/dA4fZQzHHSHQ4YZS68mc6TcAeCJ12chjui5sZdGCshFbQF+JkunQEIY CT+y6u1JIqz6mJVz/Jhh3/vTIw/SYPD/siGrZYnErY3LKdMa8z5b8WDq6oBh9i4Y CRRL8edD60Hjsg65Azpa+3mu8vFHi+eYUvqCuhQXh7r7eW2Dn6dgyp/3ul28PpIZ jvk0mbswwdDZIht/LCgl9ldjk5bFXkNI2FJlDThHC7mGdHUya40C5oZ4/Q44/C58 8rDy3tH3D1iw7ybHkgVdwVYnIgo3CUn63UXL5USrf+FfpW7qaKkOgtzNmMmA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1662916266; x=1663002666; bh=ud6ULTVJvcRsjRGCLmCYiCWRPoIJ jfRVUd0E8k+teIc=; b=b7n2kGcCD2bAv7BxT40tkps0OnDbOjzq2ij5pc1etlnc zHGfqhl7Jw5rMnBbStQtG2MwkWmTfI1O4xZgN2/hra+5XFilw810a/B4olmkUDsJ Lf3qJ2AT5h952Jk2suNKU5VP2V3xf3C9x/dzPQcu3X3dD7dK+d/bybqEpxi5wy2+ pkBVKlbagzPGrJwzLtW4PTBTasnrpZ/C6OjfNcfcV+hpZes+yTK9uy+EpwoMrIb5 p9A46sJgCuf5Aqwq5ho0LY6IYVaRoVv0XgPhcBJko/6denDk3KrnT0DGE4X/4/Cb l5380jH+73F0c+g8MmqsdQZ5p9BMlJX6MXsx9l7SAw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedutddguddufecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpeffueettdefvddtteevgfeufeejgfegudfgfedutdegfeet keehuddvfeejjeeifeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 11 Sep 2022 13:11:05 -0400 (EDT) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 2D4307EFBCF; Sun, 11 Sep 2022 10:11:04 -0700 (MST) In-Reply-To: <20220821201303.AD1E6C0088A@vcs2.savannah.gnu.org> (Lars Ingebrigtsen's message of "Sun, 21 Aug 2022 16:13:03 -0400 (EDT)") Received-SPF: pass client-ip=64.147.123.25; envelope-from=spwhitton@spwhitton.name; helo=wout2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295183 Archived-At: Hello, On Sun 21 Aug 2022 at 04:13PM -04, Lars Ingebrigtsen wrote: > branch: master > commit 48aacbf292fbe8d4be7761f83bf87de93497df27 > Author: Lars Ingebrigtsen > Commit: Lars Ingebrigtsen > > Make many seldom-used generalized variables obsolete > > The vast majority of these are unused in-tree, and many of them > perform actions that aren't obvious when reading the code. I found this in some code of mine, now generating warnings: (if (> (point) (mark)) (progn (cl-incf (point)) (cl-decf (mark))) (cl-incf (mark)) (cl-decf (point))) I guess the replacements would be forward-char and set-mark? Is there anything simpler? -- Sean Whitton