Re: master 13bd79e34f: Add more headers to default value of rmail-retry-ignored-headers.

Re: master 13bd79e34f: Add more headers to default value of rmail-retry-ignored-headers.

[Po Lu]

"Richard M. Stallman" <rms@gnu.org> writes:

> branch: master
> commit 13bd79e34fc6085410057f669cea435f2d1d046a
> Author: Richard Stallman <rms@gnu.org>
> Commit: Richard Stallman <rms@gnu.org>
>
>     Add more headers to default value of rmail-retry-ignored-headers.
>     
>     * rmail.el (rmail-retry-ignored-headers): Add more headers to default.
>     Don't bother with `purecopy'.  Split value readably.
> ---
>  lisp/mail/rmail.el | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/mail/rmail.el b/lisp/mail/rmail.el
> index fed0a2057b..9cc097d28d 100644
> --- a/lisp/mail/rmail.el
> +++ b/lisp/mail/rmail.el
> @@ -372,11 +372,17 @@ If nil, display all header fields except those matched by
>    :group 'rmail-headers)
>  
>  ;;;###autoload
> -(defcustom rmail-retry-ignored-headers (purecopy "^x-authentication-warning:\\|^x-detected-operating-system:\\|^x-spam[-a-z]*:\\|content-type:\\|content-transfer-encoding:\\|mime-version:\\|message-id:")
> +(defcustom rmail-retry-ignored-headers
> +  (concat "^x-authentication-warning:\\|^x-detected-operating-system:\\|"
> +          "^x-spam[-a-z]*:\\|^arc-.*:\\|"
> +          "^content-type:\\|^content-transfer-encoding:\\|"
> +          "^mime-version:\\|^message-id:\\|^x-google-smtp-source:\\|"
> +          "^x-received:\\|^received-spf:\\|"
> +          "^authentication-results:\\|^dkim-signature:")
>    "Headers that should be stripped when retrying a failed message."
>    :type '(choice regexp (const :value nil :tag "None"))
>    :group 'rmail-headers
> -  :version "23.2")	   ; added x-detected-operating-system, x-spam
> +  :version "23.2")

Since the default was changed, :version must be updated too, right?

Re: master 13bd79e34f: Add more headers to default value of rmail-retry-ignored-headers.

[Robert Pluim]

>>>>> On Wed, 21 Sep 2022 21:54:24 +0800, Po Lu <luangruo@yahoo.com> said:
    >> -  :version "23.2")	   ; added x-detected-operating-system, x-spam
    >> +  :version "23.2")

    Po Lu> Since the default was changed, :version must be updated too, right?

I already did that in 69fab1589a

Robert
-- 

Re: master 13bd79e34f: Add more headers to default value of rmail-retry-ignored-headers.

[Sean Whitton]

Hello,

On Wed 21 Sep 2022 at 08:43AM -04, Richard M. Stallman wrote:

> branch: master
> commit 13bd79e34fc6085410057f669cea435f2d1d046a
> Author: Richard Stallman <rms@gnu.org>
> Commit: Richard Stallman <rms@gnu.org>
>
>     Add more headers to default value of rmail-retry-ignored-headers.
>
>     * rmail.el (rmail-retry-ignored-headers): Add more headers to default.
>     Don't bother with `purecopy'.  Split value readably.
> ---

Could this variable be merged with message-ignored-resent-headers?  I
can't see why we might want to have both.

-- 
Sean Whitton

Re: master 13bd79e34f: Add more headers to default value of rmail-retry-ignored-headers.

[Eli Zaretskii]

> From: Sean Whitton <spwhitton@spwhitton.name>
> Date: Wed, 21 Sep 2022 22:08:23 -0700
> 
> Hello,
> 
> On Wed 21 Sep 2022 at 08:43AM -04, Richard M. Stallman wrote:
> 
> > branch: master
> > commit 13bd79e34fc6085410057f669cea435f2d1d046a
> > Author: Richard Stallman <rms@gnu.org>
> > Commit: Richard Stallman <rms@gnu.org>
> >
> >     Add more headers to default value of rmail-retry-ignored-headers.
> >
> >     * rmail.el (rmail-retry-ignored-headers): Add more headers to default.
> >     Don't bother with `purecopy'.  Split value readably.
> > ---
> 
> Could this variable be merged with message-ignored-resent-headers?  I
> can't see why we might want to have both.

I don't think that Rmail's rmail-retry-failure and message.el's
message-resend do the same job, do they?  The doc string of the former
says:

    "Edit a mail message which is based on the contents of the current message.
  For a message rejected by the mail system, extract the interesting headers and
  the body of the original message.

IOW, this deals with a message that was rejected by the MTA.  It
doesn't sound like a simple resend, AFAIU.

Re: master 13bd79e34f: Add more headers to default value of rmail-retry-ignored-headers.

[Po Lu]

Robert Pluim <rpluim@gmail.com> writes:

> I already did that in 69fab1589a

Oh, okay, thanks.

Re: master 13bd79e34f: Add more headers to default value of rmail-retry-ignored-headers.

[Sean Whitton]

Hello,

On Thu 22 Sep 2022 at 08:25AM +03, Eli Zaretskii wrote:

> I don't think that Rmail's rmail-retry-failure and message.el's
> message-resend do the same job, do they?  The doc string of the former
> says:
>
>     "Edit a mail message which is based on the contents of the current message.
>   For a message rejected by the mail system, extract the interesting headers and
>   the body of the original message.
>
> IOW, this deals with a message that was rejected by the MTA.  It
> doesn't sound like a simple resend, AFAIU.

I believe that Gnus uses message-ignored-resent-headers for all kinds of
resends, including resending bounced mail.

-- 
Sean Whitton