From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: TypeScript support for tree-sitter (was Re: Call for volunteers: add tree-sitter support to major modes) Date: Mon, 10 Oct 2022 19:48:27 +0200 Message-ID: <877d178t90.fsf@thornhill.no> References: <83czb1jrm3.fsf@gnu.org> <87h70b8zqs.fsf@thornhill.no> <835ygrhd1p.fsf@gnu.org> <87bkqj8w8n.fsf@thornhill.no> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19664"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 10 21:12:00 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ohyC0-0004ub-GA for ged-emacs-devel@m.gmane-mx.org; Mon, 10 Oct 2022 21:12:00 +0200 Original-Received: from localhost ([::1]:51986 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohyBz-0007bc-2H for ged-emacs-devel@m.gmane-mx.org; Mon, 10 Oct 2022 15:11:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46154) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohwtN-0007q8-VI for emacs-devel@gnu.org; Mon, 10 Oct 2022 13:48:41 -0400 Original-Received: from out0.migadu.com ([2001:41d0:2:267::]:29133) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohwtE-0002So-RX; Mon, 10 Oct 2022 13:48:41 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1665424109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mL/y1uNKM0JE33D2Lu9kuvpjdQw/v/q6glCrujCh5Ao=; b=cTAfMfrB4kbLGZruxMAj4oWGdnLpjsveKev9tMsUUruzGQr4I15YIhf/gD4UCSeq8Pdogz Vhdz3W9t9L8jRpIpZdbfXswLtbwr1tC5yTqtje+7BTKW5iFHHb90mVKTibnmyWlD3UvCjc sn79KG113tDfDBnBPUICuSSLc5Ztm5Zu3fRl8TOtn75RYnSFiY0/q2Sx6eHWY7Y6O4EVGl 4ff6QmTz1+SQ5CqfMjtx4iXznMOzpbyDUkxYx7dXCjr9Wl9pOn+vO/RbKYQsczyzHk+xk4 0YDOoLPaL85yfbQkbhi5ECDYePL+wHYC2HVoESJDSIE1+DpyiNTS92rFCfhURQ== In-Reply-To: X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:2:267::; envelope-from=theo@thornhill.no; helo=out0.migadu.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297396 Archived-At: --=-=-= Content-Type: text/plain Hi and thanks for your time! > Thanks! Some very minor comments: > [...] > + > > I think we should menntion that this mode requires tree-sitter to function. > Done > > * Incompatible Lisp Changes in Emacs 29.1 > > diff --git a/lisp/progmodes/typescript-mode.el b/lisp/progmodes/typescript-mode.el > new file mode 100644 > index 0000000000..363f7d150d > --- /dev/null > +++ b/lisp/progmodes/typescript-mode.el > @@ -0,0 +1,8 @@ > +;;; typescript-mode.el --- tree sitter support for Typescript -*- lexical-binding: t; -*- > + > +;; Copyright (C) 2022 Free Software Foundation, Inc. > + > +;; Author : Theodor Thornhill > +;; Maintainer : Theodor Thornhill > +;; Created : April 2022 > +;; Keywords : typescript languages tree-sitter > > I think we're suppose to add "This file is part of GNU Emacs" in the > header. > Done > + > +;; This program is free software; you can redistribute it and/or modify > +;; it under the terms of the GNU General Public License as published by > +;; the Free Software Foundation, either version 3 of the License, or > +;; (at your option) any later version. > + [...] > + > > Regarding below: again, sorry for the nitpick, but could you wrap lines > to 70 columns? No need to be sorry - I tried wrapping some more stuff. Sometimes it may hurt readability with 70 columns. I thought 80 was preferred? In anycase, it should be better now. > > +(defvar typescript-mode--indent-rules > + `((tsx See latest iteration below. Thanks, Theo --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Add-TypeScript-support-with-tree-sitter.patch >From 33a27eccec2e252315e14031dc027d08d55be94b Mon Sep 17 00:00:00 2001 From: Theodor Thornhill Date: Mon, 10 Oct 2022 17:23:59 +0200 Subject: [PATCH] Add TypeScript support with tree-sitter * lisp/progmodes/typescript-mode.el (typescript-mode): New major mode for TypeScript with support for tree-sitter --- etc/NEWS | 6 + lisp/progmodes/typescript-mode.el | 345 ++++++++++++++++++++++++++++++ 2 files changed, 351 insertions(+) create mode 100644 lisp/progmodes/typescript-mode.el diff --git a/etc/NEWS b/etc/NEWS index 88b1431d6a..65ff7f7c92 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -2774,6 +2774,12 @@ Emacs buffers, like indentation and the like. The new ert function This is a lightweight variant of 'js-mode' that is used by default when visiting JSON files. + +** New mode 'typescript-mode'. +Support is added for TypeScript, based on the new integration with +Tree-Sitter. There's support for font-locking, indentation and +navigation. Tree-Sitter is required for this mode to function. + * Incompatible Lisp Changes in Emacs 29.1 diff --git a/lisp/progmodes/typescript-mode.el b/lisp/progmodes/typescript-mode.el new file mode 100644 index 0000000000..ce926a2c9b --- /dev/null +++ b/lisp/progmodes/typescript-mode.el @@ -0,0 +1,345 @@ +;;; typescript-mode.el --- tree sitter support for Typescript -*- lexical-binding: t; -*- + +;; Copyright (C) 2022 Free Software Foundation, Inc. + +;; Author : Theodor Thornhill +;; Maintainer : Theodor Thornhill +;; Created : April 2022 +;; Keywords : typescript languages tree-sitter + +;; This file is part of GNU Emacs. + +;; This program is free software; you can redistribute it and/or modify +;; it under the terms of the GNU General Public License as published by +;; the Free Software Foundation, either version 3 of the License, or +;; (at your option) any later version. + +;; This program is distributed in the hope that it will be useful, +;; but WITHOUT ANY WARRANTY; without even the implied warranty of +;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;; GNU General Public License for more details. + +;; You should have received a copy of the GNU General Public License +;; along with this program. If not, see . + +(require 'treesit) + + +(defcustom typescript-mode-indent-offset 2 + "Number of spaces for each indentation step in `typescript-mode'." + :type 'integer + :safe 'integerp + :group 'typescript) + +(defvar typescript-mode--syntax-table + (let ((table (make-syntax-table))) + ;; Taken from the cc-langs version + (modify-syntax-entry ?_ "_" table) + (modify-syntax-entry ?$ "_" table) + (modify-syntax-entry ?\\ "\\" table) + (modify-syntax-entry ?+ "." table) + (modify-syntax-entry ?- "." table) + (modify-syntax-entry ?= "." table) + (modify-syntax-entry ?% "." table) + (modify-syntax-entry ?< "." table) + (modify-syntax-entry ?> "." table) + (modify-syntax-entry ?& "." table) + (modify-syntax-entry ?| "." table) + (modify-syntax-entry ?` "\"" table) + (modify-syntax-entry ?\240 "." table) + table) + "Syntax table for `typescript-mode'.") + +(defvar typescript-mode--indent-rules + `((tsx + ((node-is "}") parent-bol 0) + ((node-is ")") parent-bol 0) + ((node-is "]") parent-bol 0) + ((node-is ">") parent-bol 0) + ((node-is ".") + parent-bol ,typescript-mode-indent-offset) + ((parent-is "ternary_expression") + parent-bol ,typescript-mode-indent-offset) + ((parent-is "named_imports") + parent-bol ,typescript-mode-indent-offset) + ((parent-is "statement_block") + parent-bol ,typescript-mode-indent-offset) + ((parent-is "type_arguments") + parent-bol ,typescript-mode-indent-offset) + ((parent-is "variable_declarator") + parent-bol ,typescript-mode-indent-offset) + ((parent-is "arguments") + parent-bol ,typescript-mode-indent-offset) + ((parent-is "array") + parent-bol ,typescript-mode-indent-offset) + ((parent-is "formal_parameters") + parent-bol ,typescript-mode-indent-offset) + ((parent-is "template_substitution") + parent-bol ,typescript-mode-indent-offset) + ((parent-is "object_pattern") + parent-bol ,typescript-mode-indent-offset) + ((parent-is "object") + parent-bol ,typescript-mode-indent-offset) + ((parent-is "object_type") + parent-bol ,typescript-mode-indent-offset) + ((parent-is "enum_body") + parent-bol ,typescript-mode-indent-offset) + ((parent-is "arrow_function") + parent-bol ,typescript-mode-indent-offset) + ((parent-is "parenthesized_expression") + parent-bol ,typescript-mode-indent-offset) + + ;; TSX + ((parent-is "jsx_opening_element") + parent ,typescript-mode-indent-offset) + ((node-is "jsx_closing_element") parent 0) + ((parent-is "jsx_element") + parent ,typescript-mode-indent-offset) + ((node-is "/") parent 0) + ((parent-is "jsx_self_closing_element") + parent ,typescript-mode-indent-offset) + (no-node parent-bol 0)))) + +(defvar typescript-mode--settings + (treesit-font-lock-rules + :language 'tsx + :override t + '( + (template_string) @font-lock-string-face + + ((identifier) @font-lock-constant-face + (:match "^[A-Z_][A-Z_\\d]*$" @font-lock-constant-face)) + + (nested_type_identifier + module: (identifier) @font-lock-type-face) + (type_identifier) @font-lock-type-face + (predefined_type) @font-lock-type-face + + (new_expression + constructor: (identifier) @font-lock-type-face) + + (function + name: (identifier) @font-lock-function-name-face) + + (function_declaration + name: (identifier) @font-lock-function-name-face) + + (method_definition + name: (property_identifier) @font-lock-function-name-face) + + (variable_declarator + name: (identifier) @font-lock-function-name-face + value: [(function) (arrow_function)]) + + (variable_declarator + name: (array_pattern + (identifier) + (identifier) @font-lock-function-name-face) + value: (array (number) (function))) + + (assignment_expression + left: [(identifier) @font-lock-function-name-face + (member_expression + property: (property_identifier) @font-lock-function-name-face)] + right: [(function) (arrow_function)]) + + (call_expression + function: + [(identifier) @font-lock-function-name-face + (member_expression + property: (property_identifier) @font-lock-function-name-face)]) + + (variable_declarator + name: (identifier) @font-lock-variable-name-face) + + (enum_declaration (identifier) @font-lock-type-face) + + (enum_body (property_identifier) @font-lock-type-face) + + (enum_assignment name: (property_identifier) @font-lock-type-face) + + (assignment_expression + left: [(identifier) @font-lock-variable-name-face + (member_expression + property: (property_identifier) @font-lock-variable-name-face)]) + + (for_in_statement + left: (identifier) @font-lock-variable-name-face) + + (arrow_function + parameter: (identifier) @font-lock-variable-name-face) + + (arrow_function + parameters: + [(_ (identifier) @font-lock-variable-name-face) + (_ (_ (identifier) @font-lock-variable-name-face)) + (_ (_ (_ (identifier) @font-lock-variable-name-face)))]) + + + (pair key: (property_identifier) @font-lock-variable-name-face) + + (pair value: (identifier) @font-lock-variable-name-face) + + (pair + key: (property_identifier) @font-lock-function-name-face + value: [(function) (arrow_function)]) + + (property_signature + name: (property_identifier) @font-lock-variable-name-face) + + ((shorthand_property_identifier) @font-lock-variable-name-face) + + (pair_pattern + key: (property_identifier) @font-lock-variable-name-face) + + ((shorthand_property_identifier_pattern) + @font-lock-variable-name-face) + + (array_pattern (identifier) @font-lock-variable-name-face) + + (jsx_opening_element + [(nested_identifier (identifier)) (identifier)] + @font-lock-function-name-face) + + (jsx_closing_element + [(nested_identifier (identifier)) (identifier)] + @font-lock-function-name-face) + + (jsx_self_closing_element + [(nested_identifier (identifier)) (identifier)] + @font-lock-function-name-face) + + (jsx_attribute (property_identifier) @font-lock-constant-face) + + [(this) (super)] @font-lock-keyword-face + + [(true) (false) (null)] @font-lock-constant-face + (regex pattern: (regex_pattern)) @font-lock-string-face + (number) @font-lock-constant-face + + (string) @font-lock-string-face + (template_string) @font-lock-string-face + + (template_substitution + ["${" "}"] @font-lock-constant-face) + + ["!" + "abstract" + "as" + "async" + "await" + "break" + "case" + "catch" + "class" + "const" + "continue" + "debugger" + "declare" + "default" + "delete" + "do" + "else" + "enum" + "export" + "extends" + "finally" + "for" + "from" + "function" + "get" + "if" + "implements" + "import" + "in" + "instanceof" + "interface" + "keyof" + "let" + "namespace" + "new" + "of" + "private" + "protected" + "public" + "readonly" + "return" + "set" + "static" + "switch" + "target" + "throw" + "try" + "type" + "typeof" + "var" + "void" + "while" + "with" + "yield" + ] @font-lock-keyword-face + + (comment) @font-lock-comment-face + ))) + +(defun typescript-mode--move-to-node (fn) + (when-let ((found-node + (treesit-parent-until + (treesit-node-at (point)) + (lambda (parent) + (treesit-query-capture + parent + typescript-mode--defun-query))))) + (goto-char (funcall fn found-node)))) + +(defun typescript-mode--beginning-of-defun (&optional _arg) + (typescript-mode--move-to-node #'treesit-node-start)) + +(defun typescript-mode--end-of-defun (&optional _arg) + (typescript-mode--move-to-node #'treesit-node-end)) + +(defvar typescript-mode--defun-query + (treesit-query-compile + 'tsx + "[(import_statement) + (function_declaration) + (type_alias_declaration) + (interface_declaration) + (lexical_declaration)] @defun")) + +;;;###autoload +(add-to-list 'auto-mode-alist '("\\.ts\\'" . typescript-mode)) + +;;;###autoload +(add-to-list 'auto-mode-alist '("\\.tsx\\'" . typescript-mode)) + +(define-derived-mode typescript-mode prog-mode "TypeScript" + "Major mode for editing typescript." + :group 'typescript + :syntax-table typescript-mode--syntax-table + + (unless (or (treesit-can-enable-p) + (treesit-language-available-p 'tsx)) + (error "Tree sitter for TypeScript isn't available.")) + + ;; Comments + (setq-local comment-start "// ") + (setq-local comment-start-skip "\\(?://+\\|/\\*+\\)\\s *") + (setq-local comment-end "") + + (setq-local treesit-simple-indent-rules typescript-mode--indent-rules) + (setq-local indent-line-function #'treesit-indent) + + (setq-local beginning-of-defun-function #'typescript-mode--beginning-of-defun) + (setq-local end-of-defun-function #'typescript-mode--end-of-defun) + + (unless font-lock-defaults + (setq font-lock-defaults '(nil t))) + + (setq-local treesit-font-lock-settings typescript-mode--settings) + + (treesit-font-lock-enable)) + +(provide 'typescript-mode) + +;;; typescript-mode.el ends here -- 2.34.1 --=-=-=--