From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add user content APIs for WebKit Xwidgets Date: Sun, 16 Oct 2022 14:41:03 +0800 Message-ID: <877d10mfsw.fsf@yahoo.com> References: <763B89A7-AF82-4AAB-A0E9-A04D9958CAE8@stanford.edu> <878rlianx4.fsf@yahoo.com> <9FF9464C-1369-423E-A581-A900D132845F@stanford.edu> <87zgdy97t1.fsf@yahoo.com> <63F00459-018C-4634-9B52-A89A3ED1AA36@stanford.edu> <0F1442C8-45E2-408C-B310-448B4A26496E@stanford.edu> <87ilklnxei.fsf@yahoo.com> <0583C9C0-9953-414E-9F51-2AEFDF225BD9@stanford.edu> <87edv8mlr5.fsf@yahoo.com> <264D17C0-1FD6-44BA-B8BE-28249374F7A2@stanford.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7895"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Lars Ingebrigtsen , "emacs-devel@gnu.org" To: Qiantan Hong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Oct 16 08:42:56 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ojxMN-0001pU-80 for ged-emacs-devel@m.gmane-mx.org; Sun, 16 Oct 2022 08:42:55 +0200 Original-Received: from localhost ([::1]:35646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ojxML-00014q-JG for ged-emacs-devel@m.gmane-mx.org; Sun, 16 Oct 2022 02:42:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38978) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojxLF-0008U0-9D for emacs-devel@gnu.org; Sun, 16 Oct 2022 02:41:45 -0400 Original-Received: from sonic307-56.consmr.mail.ne1.yahoo.com ([66.163.190.31]:40736) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ojxLD-0008Q3-7l for emacs-devel@gnu.org; Sun, 16 Oct 2022 02:41:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1665902499; bh=8tnLW28nFa4pzdwX/ZYQ+Kv2c8l6E1naZEJdcUGujZA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=Bj906kAJmhNoTeQ1AyGulYuaCrTORVwa6PsTZyDw5US4mUhlwfKEUAkJt8OdrzC3iyjneJtrPJ8OQ8gKSakHcyRHsi7j5d91/WNj8VPedBfaTHlSYCFFV3K2hYJdMQF2UuSD8a0qq/TOYliNKCLAjj8VA3IgzN9fM8H9X03IRdZ09q+tq2fSeSsRYN4lzomkG2dfATMWJuUeNl24/pzdih6s37b2rGLcFpT4gZ19ICEgvq2d753OL5CPkgyqxvTEVuZGw5/tq+HHbgyhirVNnrOtH8Q3BZcvlwa4IQ451w85wm98N16eOVezunHxkBLe8+9pxWE8dYND2hcB13axew== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1665902499; bh=9HbTjrtB3Pl0TX/L4I+OZ0jkbIeDvmKakvgNn1+hnBd=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=EwXXG4ibtbv8rmMsCnATtve/BLLTDhwnHGmEVTCPexHH5GtgCFAGrK1/PNrM56PVomdftQfeq1owMmgzGNFJqEl1KF1gD+z91LWE3py2PToUPFWMXQiHxIZy87HPG8x1z3VXjZM5e9Lp8alPFHAZ4K66af3q/WnO6HnPQoHh24L5sLPEUA5GBnRxwR3w58f+H+KPFfPk6vOQTI7R/Arge8fUg1KnIT+nUOwejC9VkiOrKrCZVdXGgqydeKZUSLd8jw6EvCoQVutFNkSJAuBC5ZXPdmvi5ML4+ylksAzeecphiAU1CvufCTO8Z2pOrAd1gQ9CUbmFbGAGHmXzVDDwwg== X-YMail-OSG: yundX5AVM1kOaTgHdbpH1ynWc8rsYc3s66XrjpzIW8m4g_hpLdHHIkMeTbXd4Us 7prXci4sw5_oGTwQNSJQhcNTGlxfowgH0UMlvoovhPt6.CLt7QvIEg.UBXDrsJ2yZEBwlufT0EY3 fzY.AzKGD4KfCBsU1PdOnSDdopP2SrDbOce3jsa7Lea23qEfxvpSnD7pEfscS6Rz67lJdIHBo4D1 Jh_h_dbKey9Swyw7Dj3OdadICHb.9YO1BfdGBWpHMrjjNWAWfLzqQd.1Ws5GsndwcNger7UwVSxR fjg7rQ.7.pIv2jlKZuhU145qKz0x8YnnDqeAQTCDnBS1C9Wb9lxYGLqJoKzw6bcn6mNG3iMj2S78 PaZElEbJz5ozLyqsRfGWtskjTpRtHWBXcAirmQa3mAGF_qeNJptRj7APyH3vu7PH0LChAYZkvx7v j1ZU8ASJIJuQ89m8d0mTcVLlzdRTvaOgqdOtISwNzqyv8hTejTMaW.6gOtKolu5YScxOrHySdJBO l_Q2DmMSTCD3T1wAVfQWJU4FfHxU.bjVPNw8tTzlQcoN6OMzcdqHALoZBUf4dVkOFAC8rtAKckz9 bqoVQHkYRnap2Q5e6pesJ5KA2ILE8pwkQDHMKIiJvXPjv0s07GPD3lcvFUlWe.4luyAd9ZmppkTr bxCSf3oXb8T2Uy9gjmglkeBEgQ43gDAFv_1FPWBw9paDum.e1VvqKUJlkehd5NJ7fljX5uFiTvNq 8hPSgIxMv1uBX_oTfAPwqHBKvefARKvTR2MiBfAfgJ6jqoZgVBP5rSc0ikrFx8Sojag1DAwT.4q6 HMYUmKnyh7sHkBFcB2nUI_V2zMv9hs0booqdsuTrhl X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Sun, 16 Oct 2022 06:41:39 +0000 Original-Received: by hermes--production-sg3-785466d859-9ltwm (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 20f0ad648afd99cd71fe860aac541626; Sun, 16 Oct 2022 06:41:35 +0000 (UTC) In-Reply-To: <264D17C0-1FD6-44BA-B8BE-28249374F7A2@stanford.edu> (Qiantan Hong's message of "Sun, 16 Oct 2022 06:29:42 +0000") X-Mailer: WebService/1.1.20740 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.190.31; envelope-from=luangruo@yahoo.com; helo=sonic307-56.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297830 Archived-At: Qiantan Hong writes: > Yes I=E2=80=99m aware. I was fixing them one by one. Thanks. > It seems that existing code is connecting signal without adding the marki= ng > code, guess that should be fixed too... Where? Existing code should not connect signals to anything other than `widget_osr' which is destroyed upon the xwidget being killed, a prerequisite for being marked by GC. > Those two problems above, I don=E2=80=99t have any existing code to imita= te, so it > would take a while to learn the codebase for me to be able to fix them. > I=E2=80=99m also not sure if I should just make my part conforming or als= o fix all existing code. > Is it acceptable that I submit a patch (with other problems fixed) first, > and work on fixing these two classes of problems later? I'd rather not install code with known memory management issues, especially not this close to the Emacs 29 release.