The main things were inconsistent indentation, using mapcar for side-effects (if anything mapc should be used in that case, but I think dolist is the best choice) and there still was one checkdoc complaint. On the topic of docstrings, I think you should invest some more time to make them understandable to someone who doesn't already know what the code is about. Have you signed the FSF copyright assignment? > ------- Original Message ------- > On Wednesday, June 7th, 2023 at 6:34 PM, ram wrote: > > >> >> >> just got back to this. calling find-file appears to not open the new >> file when called through the code. i'm not immediately sure what the >> problem is. any tips? i'll look more into this tonight >> >> >> >> >> ------- Original Message ------- >> On Wednesday, June 7th, 2023 at 3:50 PM, ram chat@rj95.be wrote: >> >> >> >> > yes i figured; i found other bugs as well, but i don't think this is a typo. i'll dig a bit more and see what i can find >> > >> > ------- Original Message ------- >> > On Wednesday, June 7th, 2023 at 3:48 PM, Philip Kaludercic philipk@posteo.net wrote: >> > >> > > ram chat@rj95.be writes: >> > > >> > > > changing the central type from defclass to cl-defstruct has appeared >> > > > to cause bugs? >> > > >> > > That might have been a typo on my end, I did not evaluate the code and >> > > was is a hurry to send you the diff. My point is that you don't need >> > > defclass, unless I am missing something in your code (and I don't think >> > > the minimal convenience of `with-slots' warrants classes here). >> > > >> > > > i am not sure what to make of this, but find-file and >> > > > its variants do not appear to work when changing only this. the file >> > > > is not opened; it is not that the file is opened but the active buffer >> > > > isn't switched >> > > > >> > > > ------- Original Message ------- >> > > > On Wednesday, June 7th, 2023 at 2:04 PM, Philip Kaludercic philipk@posteo.net wrote: >> > > > >> > > > > Philip Kaludercic philipk@posteo.net writes: >> > > > > >> > > > > > > here is the repo: https://github.com/gitrj95/breadcrumbs.el >> > > > > > >> > > > > > Here are a few suggestions: >> > > > > >> > > > > Oh, and can you address the issue raised by checkdoc?