unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu <luangruo@yahoo.com>
To: emacs-devel@gnu.org
Cc: Michael Albinus <michael.albinus@gmx.de>
Subject: Re: master 588a0363d9a: Improve SELinux handling in Tramp
Date: Thu, 03 Aug 2023 19:49:09 +0800	[thread overview]
Message-ID: <877cqcbb2i.fsf@yahoo.com> (raw)
In-Reply-To: <20230803111715.B86F3C038BB@vcs2.savannah.gnu.org> (Michael Albinus's message of "Thu, 3 Aug 2023 07:17:14 -0400 (EDT)")

Michael Albinus <Michael.Albinus@gmx.de> writes:

> branch: master
> commit 588a0363d9a3ce6d678618ad545f7a8f9af27880
> Author: Michael Albinus <michael.albinus@gmx.de>
> Commit: Michael Albinus <michael.albinus@gmx.de>
>
>     Improve SELinux handling in Tramp
>     
>     * lisp/net/tramp-sh.el (tramp-stat-file-attributes-with-selinux)
>     (tramp-stat-directory-files-and-attributes-with-selinux): New defconst.
>     (tramp-do-file-attributes-with-ls)
>     (tramp-do-file-attributes-with-stat)
>     (tramp-do-directory-files-and-attributes-with-stat): Return also
>     SELinux context.
>     (tramp-remote-selinux-p, tramp-do-copy-or-rename-file): Adapt docstring.
>     
>     * lisp/net/tramp-sudoedit.el (tramp-sudoedit-do-copy-or-rename-file)
>     (tramp-sudoedit-remote-selinux-p): Adapt docstring.
>     (tramp-sudoedit-file-attributes-with-selinux): New defconst.
>     (tramp-sudoedit-handle-file-attributes): Use it.
>     
>     * lisp/net/tramp.el (tramp-convert-file-attributes):
>     Extract SELinux context.

If my understanding is correct, then with this change Tramp starts to
return SELinux context information from file-attributes.

Doesn't this mean Dired and similar should be adjusted to refrain from
trying to restore SELinux attributes when performing a copy from a
remote directory, given that different machines can have completely
incompatible SELinux configurations?



       reply	other threads:[~2023-08-03 11:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <169106143410.16457.9843450418997998201@vcs2.savannah.gnu.org>
     [not found] ` <20230803111715.B86F3C038BB@vcs2.savannah.gnu.org>
2023-08-03 11:49   ` Po Lu [this message]
2023-08-03 13:08     ` master 588a0363d9a: Improve SELinux handling in Tramp Michael Albinus
2023-08-03 13:14       ` Po Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cqcbb2i.fsf@yahoo.com \
    --to=luangruo@yahoo.com \
    --cc=emacs-devel@gnu.org \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).