From: Jonas Bernoulli <jonas@bernoul.li>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: Po Lu <luangruo@yahoo.com>, emacs-devel@gnu.org
Subject: Re: Transient manual
Date: Sat, 02 Sep 2023 18:31:45 +0200 [thread overview]
Message-ID: <877cp8bkpa.fsf@bernoul.li> (raw)
In-Reply-To: <878r9phwsm.fsf@localhost>
Ihor Radchenko <yantar92@posteo.net> writes:
>> Speaking of af9c063ed, that commit adds another regression and has
>> to be reverted.
>
> Maybe you mean some other commit?
> af9c063ed is just changing a docstring.
Yes. It's e32bd5f7c78c9d92cefd9a78771f9729946fdf73.
Instead of restoring the save-match-data, you could change the order
of the bindings.
When I wrote that function, I decided that I would rather use
save-match-data, even though that could be avoided. That way the two
bindings which set and then refine CMD based on the first submatch are
next to each other, and only after that has been taken care off, do we
move on to set ARGS based on the second submatch. But if you think it
is more important to avoid a save-match-data, or think the mistake you
made is likely to be repeated, I am fine with switching up the order.
Jonas
next prev parent reply other threads:[~2023-09-02 16:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87cyz6wtja.fsf.ref@yahoo.com>
2023-08-29 1:01 ` Transient manual Po Lu
2023-08-30 0:10 ` Jonas Bernoulli
2023-08-30 1:08 ` Po Lu
2023-08-30 2:25 ` Eli Zaretskii
2023-09-01 1:15 ` Richard Stallman
2023-09-01 6:41 ` Eli Zaretskii
2023-08-30 5:16 ` Ihor Radchenko
2023-09-01 23:22 ` Jonas Bernoulli
2023-09-02 7:14 ` Ihor Radchenko
2023-09-02 16:31 ` Jonas Bernoulli [this message]
2023-09-02 17:12 ` Ihor Radchenko
2023-08-30 2:05 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cp8bkpa.fsf@bernoul.li \
--to=jonas@bernoul.li \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).