* Re: master 774c8ec74c9: cperl-mode.el: Make sure cperl-file-style is set buffer-local
[not found] ` <20240108151729.9420CC00264@vcs2.savannah.gnu.org>
@ 2024-01-09 6:48 ` Stefan Kangas
2024-01-09 10:59 ` Harald Jörg
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Kangas @ 2024-01-09 6:48 UTC (permalink / raw)
To: Harald Jörg, emacs-devel
Harald Jörg <haj@posteo.de> writes:
> branch: master
> commit 774c8ec74c98d69d56b2511a613145f2b69fb2eb
> Author: Harald Jörg <haj@posteo.de>
> Commit: Harald Jörg <haj@posteo.de>
>
> cperl-mode.el: Make sure cperl-file-style is set buffer-local
>
> * lisp/progmodes/cperl-mode.el (cperl-file-style): Add description
> what the options actually do.
> (cperl-menu): Split the menu entry "Indent styles" into "Default
> indent styles" and "Indent styles for current buffer"
> (cperl--set-file-style): call `cperl-file-style' instead of
> `cperl-set-style'. This completes the fix for Bug#17948.
> (cperl-set-style): Explain when to use `cperl-file-style'.
> Use `set-default-toplevel-value' instead of `set'.
> (cperl-set-style-back): Use `set-default-toplevel-value' instead
> of `set'.
> (cperl-file-style): New command to set the file style for the
> current buffer.
>
> * etc/NEWS: Announce the new command cperl-file-style.
This lead to a new warning
In cperl-file-style:
progmodes/cperl-mode.el:6561:4: Warning: ‘make-variable-buffer-local’
not called at toplevel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: master 774c8ec74c9: cperl-mode.el: Make sure cperl-file-style is set buffer-local
2024-01-09 6:48 ` master 774c8ec74c9: cperl-mode.el: Make sure cperl-file-style is set buffer-local Stefan Kangas
@ 2024-01-09 10:59 ` Harald Jörg
0 siblings, 0 replies; 2+ messages in thread
From: Harald Jörg @ 2024-01-09 10:59 UTC (permalink / raw)
To: Stefan Kangas; +Cc: emacs-devel
Stefan Kangas <stefankangas@gmail.com> writes:
> Harald Jörg <haj@posteo.de> writes:
>
>> branch: master
>> commit 774c8ec74c98d69d56b2511a613145f2b69fb2eb
>> Author: Harald Jörg <haj@posteo.de>
>> Commit: Harald Jörg <haj@posteo.de>
>> [...]
> This lead to a new warning
>
> In cperl-file-style:
> progmodes/cperl-mode.el:6561:4: Warning: ‘make-variable-buffer-local’
> not called at toplevel
Ouch. Fixed!
--
Cheers,
haj
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-09 10:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <170472704913.13846.17540657345343721535@vcs2.savannah.gnu.org>
[not found] ` <20240108151729.9420CC00264@vcs2.savannah.gnu.org>
2024-01-09 6:48 ` master 774c8ec74c9: cperl-mode.el: Make sure cperl-file-style is set buffer-local Stefan Kangas
2024-01-09 10:59 ` Harald Jörg
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).