From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Herman=2C_G=C3=A9za?= Newsgroups: gmane.emacs.devel Subject: Re: I created a faster JSON parser Date: Fri, 08 Mar 2024 17:14:21 +0100 Message-ID: <877cicl1cl.fsf@gmail.com> References: <87a5n96mb5.fsf@gmail.com> <87y1asyhs4.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18607"; mail-complaints-to="usenet@ciao.gmane.io" Cc: =?utf-8?Q?Herman=2C_G=C3=A9za?= , "emacs-devel@gnu.org" To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 09 01:02:39 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rikAh-0004h9-Ag for ged-emacs-devel@m.gmane-mx.org; Sat, 09 Mar 2024 01:02:39 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rik9x-0007VW-L5; Fri, 08 Mar 2024 19:01:53 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rik9w-0007SI-Sg for emacs-devel@gnu.org; Fri, 08 Mar 2024 19:01:52 -0500 Original-Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rik9u-0005xD-Nh for emacs-devel@gnu.org; Fri, 08 Mar 2024 19:01:52 -0500 Original-Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-412f988b601so19274515e9.0 for ; Fri, 08 Mar 2024 16:01:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709942509; x=1710547309; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:references:from:to:cc:subject:date:message-id :reply-to; bh=lA7LRf+VaY7J9Vc6f7PSXy1enfJkyC5yNs8mjfWa+z0=; b=GWNteO65xx/43tZOn/XMepI/I5f32oUQztoFXrgg+JVHVyxD7ngLfCeJDWWTjLJoQr XXXJelQheCqLiAmtjtZBngYH5Vdv+CIVXDB3WFbkIkQ+6mHXZ/QJV5kRqQ72FjAnWQu7 2wY1UHkVUJxP/wVP/BAcLQVPYLxjHZGDoBB9sK+qDdQvC1vueumrrYpSnDrQMNOt94in 8VoOML1qden3VUgElnJClYLNccvrf3/7tbGIjVyKo4oiBmn7Gy9gMCdgYoqyFaYkXi4M N+Jtc2aMQ+p0X/KWNtcA5KxKfpd2SWKq3UiPHWUT0pEZupCq+PsD95kN8kOyYzDL0OuQ L0Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709942509; x=1710547309; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:references:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=lA7LRf+VaY7J9Vc6f7PSXy1enfJkyC5yNs8mjfWa+z0=; b=f2tO+bbnS5xMI5mSS4Q1a6fUiDnThDuvj+ZyN782q1S37V/+o4cbBDOUAEKQV/zq/7 ZE6FM5Uf4/hHbh+AetuM7pYB0W/lAr+0Am/i3sfBNxa2IoOOk2rpipPeWinRPTItYaOa w9E5p4ds9sv8/n/2gFsGCMQEpXu2y3KnZKlWfBuQn2BVKBYq1mNcNczCJwsVb6gwOjTp FUSn4M01l6EtY//n285l0aA5rqYDT+u7ES6NowrbTQIOCgt0DWFvbrzF9Lbu51bkCjAd 8WbEYROPJ3Mq4+EARCs6Uu8Gg+MnsxJEWklJ89+slRiqeU2PWGuYSI5LvUCZqPEIJgRF 3QMw== X-Forwarded-Encrypted: i=1; AJvYcCVcmqS24ydtzjHDRd/M64U2RaWiN1cC1Zjeiqljm0Y+ElVTNcfi+j5eMLUpnAbmeYFkxXOuH8/IJJkl0WQ2mhyquTNS X-Gm-Message-State: AOJu0YzEtN1uBvPrTz2zRtZJhY1VP1W7v+OLyadRDVWUV69bt4N1XziH eaHHbt/b7s4FAfXyRKFS73Ptse9PruHn8xzF2wjwF/6kKNPD5t+8 X-Google-Smtp-Source: AGHT+IGxoUwedMTGoHYz1Gs9ZzYeAlCC0fFui0mDVSM628zqWZmg1wgqDmD4Yu3n2v2ye8fVeoj4zQ== X-Received: by 2002:a05:600c:5119:b0:413:134b:b97a with SMTP id o25-20020a05600c511900b00413134bb97amr429923wms.31.1709942508708; Fri, 08 Mar 2024 16:01:48 -0800 (PST) Original-Received: from localhost (netacc-gpn-4-80-29.pool.yettel.hu. [84.224.80.29]) by smtp.gmail.com with ESMTPSA id hg9-20020a05600c538900b00412f855bcc2sm7225061wmb.43.2024.03.08.16.01.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Mar 2024 16:01:48 -0800 (PST) In-reply-to: <87y1asyhs4.fsf@yahoo.com> Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=geza.herman@gmail.com; helo=mail-wm1-x330.google.com X-Spam_score_int: -5 X-Spam_score: -0.6 X-Spam_bar: / X-Spam_report: (-0.6 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_06_12=1.543, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316929 Archived-At: Po Lu writes: > "Herman, G=C3=A9za" writes: > >> What do you think? > > Speed aside, this change eliminates an external dependency from=20 > Emacs, > which is a great service to us in its own right. Thank you! I think jansson is still used, but only for writing to json. > Nevertheless, there are several coding style issues that should=20 > be > resolved, viz. the presence of redundant opening braces and=20 > ternary or > nested binary operations not enclosed in parentheses, Can you give me some examples reagarding operations need to be=20 parenthesized? Isn't there a gcc warning for this, so I can=20 follow the convention more easily?