From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master ac797f60160 2/2: ; * lisp/net/shr.el (shr-image-zoom-levels): Fix wrong type. Date: Tue, 09 Jul 2024 18:48:44 +0200 Message-ID: <877cdua4ur.fsf@gmail.com> References: <172054273136.24557.15429439759711990393@vcs2.savannah.gnu.org> <20240709163212.254C9C2BC9A@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31582"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 09 18:49:53 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sRE2L-00083E-38 for ged-emacs-devel@m.gmane-mx.org; Tue, 09 Jul 2024 18:49:53 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sRE1P-0008OF-Fi; Tue, 09 Jul 2024 12:48:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRE1O-0008O6-CA for emacs-devel@gnu.org; Tue, 09 Jul 2024 12:48:54 -0400 Original-Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sRE1L-00053b-41 for emacs-devel@gnu.org; Tue, 09 Jul 2024 12:48:54 -0400 Original-Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-4266f3e0df8so9878305e9.2 for ; Tue, 09 Jul 2024 09:48:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720543726; x=1721148526; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from:from :to:cc:subject:date:message-id:reply-to; bh=1hW9SQI2dSlIIMfv0MKzzCIs3UlDzI43HCWeE75O1K0=; b=G2AalaUAfyClGUbsaT6WZjoeSTMWPYBDZVXmxSo7gHXt8Y6+CdLKp8zZrjdIJ1iTJY LF/IIiT/hwc1A5eaJHiM/1XzfCNpFLABoV5HS8n7douHH+45lwB0eqFol+6eWbyHqahR 2mIPOCBoXsVvN3ZfL7MNOyU+r34+88Ehc+u/6Ev7XPoslXqTRPJcJ0HL2Iw7LHUnG8Sz y7SKzHnLzAzE8kgDjCxYjvsPJPY/RCVVVXWEyAGeV2yJjqtq1qNcVR6ot8P1GJCEX/0R dVHTngvQ0MMHfE5OiHnpZYpjYKCg6A52KWgYiOV7uTmOLxJQxjAji/LtcOA4dzwUhQ5O icTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720543726; x=1721148526; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1hW9SQI2dSlIIMfv0MKzzCIs3UlDzI43HCWeE75O1K0=; b=TaJIj/3d90rX6lL0x/aWy+YuFCstt4LY9TjsYn9y12KXnTfq7FdWLEucF7o/CKmpsC rwV2R5hOY46a7Rlit6JJVVTDHC91PI8mbWOGfpMpi96dJysPZM1BRguxklBT5ATEy40W RDEHABmSi1zj59HoVMeT8WWUG3e6xH94fAEdlZSbwjwYA1AuP7vCaI/O1FsNt0+P0EDf WWRaS0TkXhyASUMOGRv2fAyr7dB36y2nQNYaE4qMZkJvetzX0GehHGVGlJogBCwPmYDh uHgS6rTtvJwc7yjXu+zC93D4lvvDMdp7VqAL0uxbm61m0fH/BMba2mX1UG9ES/gcw3Fb 3qhg== X-Gm-Message-State: AOJu0Yz75BMODYvqkM6FPM32UFiHFnze/qg4ykaGvPbs/rc2t4TIBcZV jVEUZZ21JOXh/Za6CfaaRHPCJz/7IWFMyIUO7qrvITx63zCjwBsK X-Google-Smtp-Source: AGHT+IH1tIkDvYMoCSKHCy/V5g1FchvGMTQpz/z+dPNpVdw+RzDb3uV1y9vQ0Aershd5cunHiD7MhQ== X-Received: by 2002:a05:600c:4f4e:b0:426:6edb:7e14 with SMTP id 5b1f17b1804b1-426708f9d4cmr20947155e9.35.1720543725870; Tue, 09 Jul 2024 09:48:45 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42727805e4csm10763135e9.27.2024.07.09.09.48.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jul 2024 09:48:45 -0700 (PDT) In-Reply-To: <20240709163212.254C9C2BC9A@vcs2.savannah.gnu.org> ("Mattias =?utf-8?B?RW5nZGVnw4PCpXJk?= via Mailing list for Emacs changes"'s message of "Tue, 9 Jul 2024 12:32:12 -0400 (EDT)") Gmane-Reply-To-List: yes Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=rpluim@gmail.com; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321567 Archived-At: >>>>> On Tue, 9 Jul 2024 12:32:12 -0400 (EDT), Mattias Engdeg=C3=83=C2=A5r= d via Mailing list for Emacs changes said: Mattias> branch: master Mattias> commit ac797f60160848fb625db4855befc68352d6cbd2 Mattias> Author: Mattias Engdeg=C3=A5rd Mattias> Commit: Mattias Engdeg=C3=A5rd Mattias> ; * lisp/net/shr.el (shr-image-zoom-levels): Fix wrong typ= e. Mattias> --- Mattias> lisp/net/shr.el | 8 ++++---- Mattias> 1 file changed, 4 insertions(+), 4 deletions(-) Mattias> diff --git a/lisp/net/shr.el b/lisp/net/shr.el Mattias> index 4ccd8a5a85a..39271cc5296 100644 Mattias> --- a/lisp/net/shr.el Mattias> +++ b/lisp/net/shr.el Mattias> @@ -233,10 +233,10 @@ can be one of the following symbols: Mattias> * `fill-height': Display the image zoomed to fill the height = of the Mattias> current window." Mattias> :version "31.1" Mattias> - :type '(set (choice (const :tag "Fit to window size" fit) Mattias> - (const :tag "Original size" original) Mattias> - (const :tag "Full image size" image) Mattias> - (const :tag "Fill window height" fill-h= eight)))) Mattias> + :type '(set (const :tag "Fit to window size" fit) Mattias> + (const :tag "Original size" original) Mattias> + (const :tag "Full image size" image) Mattias> + (const :tag "Fill window height" fill-height))) Wouldn=CA=BCt this look better: :type '(repeat (radio (const :tag "Fit to window size" fit) (const :tag "Original size" original) (const :tag "Full image size" image) (const :tag "Fill window height" fill-height)))) It makes selection easier, since it shows the available options for each item. Robert --=20