Re: master ac797f60160 2/2: ; * lisp/net/shr.el (shr-image-zoom-levels): Fix wrong type.

[Robert Pluim <rpluim@gmail.com>]

>>>>> On Tue,  9 Jul 2024 12:32:12 -0400 (EDT), Mattias Engdegård via Mailing list for Emacs changes <emacs-diffs@gnu.org> said:

    Mattias> branch: master
    Mattias> commit ac797f60160848fb625db4855befc68352d6cbd2
    Mattias> Author: Mattias Engdegård <mattiase@acm.org>
    Mattias> Commit: Mattias Engdegård <mattiase@acm.org>

    Mattias>     ; * lisp/net/shr.el (shr-image-zoom-levels): Fix wrong type.
    Mattias> ---
    Mattias>  lisp/net/shr.el | 8 ++++----
    Mattias>  1 file changed, 4 insertions(+), 4 deletions(-)

    Mattias> diff --git a/lisp/net/shr.el b/lisp/net/shr.el
    Mattias> index 4ccd8a5a85a..39271cc5296 100644
    Mattias> --- a/lisp/net/shr.el
    Mattias> +++ b/lisp/net/shr.el
    Mattias> @@ -233,10 +233,10 @@ can be one of the following symbols:
    Mattias>  * `fill-height': Display the image zoomed to fill the height of the
    Mattias>  current window."
    Mattias>    :version "31.1"
    Mattias> -  :type '(set (choice (const :tag "Fit to window size" fit)
    Mattias> -                      (const :tag "Original size" original)
    Mattias> -                      (const :tag "Full image size" image)
    Mattias> -                      (const :tag "Fill window height" fill-height))))
    Mattias> +  :type '(set (const :tag "Fit to window size" fit)
    Mattias> +              (const :tag "Original size" original)
    Mattias> +              (const :tag "Full image size" image)
    Mattias> +              (const :tag "Fill window height" fill-height)))

Wouldnʼt this look better:

  :type '(repeat (radio
                  (const :tag "Fit to window size" fit)
                  (const :tag "Original size" original)
                  (const :tag "Full image size" image)
                  (const :tag "Fill window height" fill-height))))

It makes selection easier, since it shows the available options for
each item.

Robert
--