From: Robert Pluim <rpluim@gmail.com>
To: emacs-devel@gnu.org
Cc: "Mattias Engdegård" <mattiase@acm.org>
Subject: Re: master ac797f60160 2/2: ; * lisp/net/shr.el (shr-image-zoom-levels): Fix wrong type.
Date: Tue, 09 Jul 2024 18:48:44 +0200 [thread overview]
Message-ID: <877cdua4ur.fsf@gmail.com> (raw)
In-Reply-To: <20240709163212.254C9C2BC9A@vcs2.savannah.gnu.org> ("Mattias Engdegård via Mailing list for Emacs changes"'s message of "Tue, 9 Jul 2024 12:32:12 -0400 (EDT)")
>>>>> On Tue, 9 Jul 2024 12:32:12 -0400 (EDT), Mattias Engdegård via Mailing list for Emacs changes <emacs-diffs@gnu.org> said:
Mattias> branch: master
Mattias> commit ac797f60160848fb625db4855befc68352d6cbd2
Mattias> Author: Mattias Engdegård <mattiase@acm.org>
Mattias> Commit: Mattias Engdegård <mattiase@acm.org>
Mattias> ; * lisp/net/shr.el (shr-image-zoom-levels): Fix wrong type.
Mattias> ---
Mattias> lisp/net/shr.el | 8 ++++----
Mattias> 1 file changed, 4 insertions(+), 4 deletions(-)
Mattias> diff --git a/lisp/net/shr.el b/lisp/net/shr.el
Mattias> index 4ccd8a5a85a..39271cc5296 100644
Mattias> --- a/lisp/net/shr.el
Mattias> +++ b/lisp/net/shr.el
Mattias> @@ -233,10 +233,10 @@ can be one of the following symbols:
Mattias> * `fill-height': Display the image zoomed to fill the height of the
Mattias> current window."
Mattias> :version "31.1"
Mattias> - :type '(set (choice (const :tag "Fit to window size" fit)
Mattias> - (const :tag "Original size" original)
Mattias> - (const :tag "Full image size" image)
Mattias> - (const :tag "Fill window height" fill-height))))
Mattias> + :type '(set (const :tag "Fit to window size" fit)
Mattias> + (const :tag "Original size" original)
Mattias> + (const :tag "Full image size" image)
Mattias> + (const :tag "Fill window height" fill-height)))
Wouldnʼt this look better:
:type '(repeat (radio
(const :tag "Fit to window size" fit)
(const :tag "Original size" original)
(const :tag "Full image size" image)
(const :tag "Fill window height" fill-height))))
It makes selection easier, since it shows the available options for
each item.
Robert
--
next parent reply other threads:[~2024-07-09 16:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <172054273136.24557.15429439759711990393@vcs2.savannah.gnu.org>
[not found] ` <20240709163212.254C9C2BC9A@vcs2.savannah.gnu.org>
2024-07-09 16:48 ` Robert Pluim [this message]
2024-07-10 8:46 ` master ac797f60160 2/2: ; * lisp/net/shr.el (shr-image-zoom-levels): Fix wrong type Mattias Engdegård
2024-07-10 9:04 ` Robert Pluim
2024-07-10 10:46 ` Philip Kaludercic
2024-07-10 12:02 ` Robert Pluim
2024-07-10 17:24 ` Jim Porter
2024-07-11 7:37 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cdua4ur.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).