From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Morgan Willcock Newsgroups: gmane.emacs.devel Subject: Re: No NEWS entry for doc-view-mupdf-use-svg (Emacs 30.0.91 feedback) Date: Mon, 23 Sep 2024 16:50:13 +0100 Message-ID: <877cb2fjyi.fsf@ice9.digital> References: <87cyky43fb.fsf@ice9.digital> <86setu5f85.fsf@gnu.org> <87zfo22jy4.fsf@ice9.digital> <86bk0h5sx9.fsf@gnu.org> <87ldzlgxvh.fsf@ice9.digital> <87msk0oqoq.fsf@gnu.org> <87plovmmox.fsf@ice9.digital> <8734lqzx64.fsf@gnu.org> <877cb2kbta.fsf@ledu-giraud.fr> <8634lqh9bt.fsf@gnu.org> <87msjyv2xb.fsf@gnu.org> <86msjyfkn3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34565"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Tassilo Horn , manuel@ledu-giraud.fr, emacs-devel@gnu.org, visuweshm@gmail.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 23 17:50:43 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sslKl-0008pK-10 for ged-emacs-devel@m.gmane-mx.org; Mon, 23 Sep 2024 17:50:43 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sslKT-0007KM-VS; Mon, 23 Sep 2024 11:50:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sslKQ-0007JI-CU for emacs-devel@gnu.org; Mon, 23 Sep 2024 11:50:22 -0400 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sslKN-0005ei-MN; Mon, 23 Sep 2024 11:50:21 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 088881BF20A; Mon, 23 Sep 2024 15:50:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ice9.digital; s=gm1; t=1727106614; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fkMep1IIVUG00mdD3VT8w4V1YPalksCzCoI5+nCjk3Y=; b=HwyaKrfW3u/WL3gJU4BIAuwiiHngSy49/SfN/op48YCtvByocucoJumwMPgPT7dQ4PuvfB 78wnFGSfQXgjrdJK3PPlYWogXCVBy2OaBSIXhrP5FvyxB3H/ZLAfVBJo3gFtzNoZlwVoON WFQl9WT8iqMgvY2hsd8Nefl1t/a/S8n3hK9ia8WhBnwJkXr8a1oaCW5ZhpGpkeWbOx8B/z AbyYMW/eGroQHPwqxUVOni6d1fMy5EugGhJf4vdGNoCMapTTwk0KN0LD3iNgtjA+F095y8 VMHiNisQ0ANbceIzdd7A0NK6TyLvmVRxMQHMsNR6IfJP30tOc3Ndo94jGkZECA== In-Reply-To: <86msjyfkn3.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 23 Sep 2024 18:35:28 +0300") X-GND-Sasl: morgan@ice9.digital Received-SPF: pass client-ip=217.70.183.201; envelope-from=morgan@ice9.digital; helo=relay8-d.mail.gandi.net X-Spam_score_int: -36 X-Spam_score: -3.7 X-Spam_bar: --- X-Spam_report: (-3.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.928, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323970 Archived-At: Eli Zaretskii writes: >> +If foreground and background color are not specified explicitly and >> +therefore inherit from the `default' face, the default >> +foreground/background color values are passed to `create-image' when >> +preparing the SVG for display in the doc-view buffer. The effect is >> +that the current theme's foreground/background values are applied to the >> +SVG display. Note that this doesn't work for documents which are not >> +simply black-on-white where it can lead to unreadable documents due to >> +foreground and background color being equal or similar." >> :version "30.1") > > I think this is too technical, and describes what the face definitions > do. I think we only need to say there that if the face's colors cause > color SVG images display with low contrast between foreground and > background, the user should customize the face to produce a better > contrast. Unless you know what the document looks like ahead of time, it isn't obvious that what you are looking at is actually a background and a foreground. Perhaps it is best to also mention that elements of the image may appear to be missing entirely. -- Morgan Willcock