unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Morgan Willcock <morgan@ice9.digital>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Tassilo Horn <tsdh@gnu.org>,
	  manuel@ledu-giraud.fr, emacs-devel@gnu.org,
	  visuweshm@gmail.com
Subject: Re: No NEWS entry for doc-view-mupdf-use-svg (Emacs 30.0.91 feedback)
Date: Mon, 23 Sep 2024 16:50:13 +0100	[thread overview]
Message-ID: <877cb2fjyi.fsf@ice9.digital> (raw)
In-Reply-To: <86msjyfkn3.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 23 Sep 2024 18:35:28 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> +If foreground and background color are not specified explicitly and
>> +therefore inherit from the `default' face, the default
>> +foreground/background color values are passed to `create-image' when
>> +preparing the SVG for display in the doc-view buffer.  The effect is
>> +that the current theme's foreground/background values are applied to the
>> +SVG display.  Note that this doesn't work for documents which are not
>> +simply black-on-white where it can lead to unreadable documents due to
>> +foreground and background color being equal or similar."
>>    :version "30.1")
>
> I think this is too technical, and describes what the face definitions
> do.  I think we only need to say there that if the face's colors cause
> color SVG images display with low contrast between foreground and
> background, the user should customize the face to produce a better
> contrast.

Unless you know what the document looks like ahead of time, it isn't
obvious that what you are looking at is actually a background and a
foreground.  Perhaps it is best to also mention that elements of the
image may appear to be missing entirely.

-- 
Morgan Willcock



  reply	other threads:[~2024-09-23 15:50 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-20 17:53 No NEWS entry for doc-view-mupdf-use-svg (Emacs 30.0.91 feedback) Morgan Willcock
2024-09-20 18:53 ` Eli Zaretskii
2024-09-20 19:34   ` Visuwesh
2024-09-20 19:39   ` Morgan Willcock
2024-09-20 22:29     ` chad
2024-09-20 22:46       ` Morgan Willcock
2024-09-21  8:09     ` Eli Zaretskii
2024-09-21  9:27       ` Morgan Willcock
2024-09-21 17:35         ` Tassilo Horn
2024-09-22 20:57           ` Morgan Willcock
2024-09-23  6:44             ` Tassilo Horn
2024-09-23  8:34               ` Manuel Giraud via Emacs development discussions.
2024-09-23  8:45                 ` Tassilo Horn
2024-09-23 11:34                   ` Manuel Giraud via Emacs development discussions.
2024-09-23 11:56                 ` Eli Zaretskii
2024-09-23 14:51                   ` Tassilo Horn
2024-09-23 15:35                     ` Eli Zaretskii
2024-09-23 15:50                       ` Morgan Willcock [this message]
2024-09-23 16:10                       ` Tassilo Horn
2024-09-23 16:27                         ` Eli Zaretskii
2024-09-23 16:54                           ` Tassilo Horn
2024-09-24 11:17                             ` Eli Zaretskii
2024-09-24 11:22                               ` Tassilo Horn
2024-09-23 17:56                         ` Manuel Giraud via Emacs development discussions.
2024-09-23 18:35                           ` Tassilo Horn
2024-09-23 19:06                             ` Manuel Giraud via Emacs development discussions.
2024-09-23  9:36               ` Visuwesh
2024-09-23 11:55               ` Eli Zaretskii
2024-09-23 12:05                 ` Tassilo Horn
2024-09-23 15:32                   ` Eli Zaretskii
2024-09-21  7:28   ` Tassilo Horn
2024-09-21  9:27     ` Morgan Willcock
2024-09-21 11:04       ` Visuwesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cb2fjyi.fsf@ice9.digital \
    --to=morgan@ice9.digital \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=manuel@ledu-giraud.fr \
    --cc=tsdh@gnu.org \
    --cc=visuweshm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).