unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
Cc: rms@gnu.org, emacs-devel@gnu.org
Subject: Re: why does occur depropertize matching lines?
Date: Sun, 21 Nov 2004 05:22:52 +0200	[thread overview]
Message-ID: <87653zkezn.fsf@jurta.org> (raw)
In-Reply-To: <FDELKNEBLPKKDCEBEJCBIELACJAA.drew.adams@oracle.com> (Drew Adams's message of "Sat, 20 Nov 2004 17:51:56 -0800")

"Drew Adams" <drew.adams@oracle.com> writes:
> I think this is a considerable setback wrt usability: it represents an
> information loss for users. I don't know how much of the pb was program
> "trouble" and how much was user "confusion", but I'm one user who would be
> willing to trade, say, the confusion of some extra, ineffective mouse-face
> highlighting for the benefit of informative syntactic highlighting. Such
> highlighting is all the more helpful when lines have been taken out of
> context (as in occur).

Even now occur partly preserves highlighting for some lines: when
called with a numeric prefix argument occur displays context lines
highlighted with their original faces whereas highlighting from matching
lines is removed.  This is too weird.  I can't find a reason for that.

I think occur should preserve highlighting of matching lines as well
(or at least preserve face properties if other properties are too confusing).

However, I see another problem: matches are not highlighted anymore
with `list-matching-lines-face' because when a character has two properties

  font-lock-face [bold]                   ;; from `list-matching-lines-face'
  face           [font-lock-keyword-face] ;; from source buffer

`face' property takes precedence over `font-lock-face'.

If it would be possible to merge these two properties somehow...

-- 
Juri Linkov
http://www.jurta.org/emacs/

  reply	other threads:[~2004-11-21  3:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-05 23:45 why does occur depropertize matching lines? Drew Adams
2004-11-19 16:02 ` Drew Adams
2004-11-21  1:10   ` Richard Stallman
2004-11-21  1:51     ` Drew Adams
2004-11-21  3:22       ` Juri Linkov [this message]
2004-11-25  2:19         ` Richard Stallman
2004-11-25  7:27           ` Juri Linkov
2004-11-26 21:03             ` Richard Stallman
2004-12-05 16:43               ` Juri Linkov
2004-12-06  1:40                 ` Richard Stallman
2004-12-06 20:10                   ` Juri Linkov
2004-12-06 20:33                     ` Stefan Monnier
2004-12-06 21:40                       ` Juri Linkov
2004-12-08  4:39                         ` Richard Stallman
2004-12-08 19:06                           ` Drew Adams
2004-12-08 19:44                             ` Josh Varner
2004-12-08 20:08                               ` Drew Adams
2004-12-09  4:42                                 ` Richard Stallman
2004-12-08  4:59                         ` Stefan Monnier
2004-12-08  4:39                     ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87653zkezn.fsf@jurta.org \
    --to=juri@jurta.org \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).