From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lute Kamstra Newsgroups: gmane.emacs.devel Subject: Re: Fixing the face menu Date: Mon, 27 Jun 2005 09:47:39 +0200 Message-ID: <8764w06y1w.fsf@xs4all.nl> References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1119859275 10238 80.91.229.2 (27 Jun 2005 08:01:15 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 27 Jun 2005 08:01:15 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 27 10:01:10 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DmoXf-0001p5-Ps for ged-emacs-devel@m.gmane.org; Mon, 27 Jun 2005 10:00:32 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DmofG-00075o-QW for ged-emacs-devel@m.gmane.org; Mon, 27 Jun 2005 04:08:22 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Dmobb-0006X1-WC for emacs-devel@gnu.org; Mon, 27 Jun 2005 04:04:36 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DmobW-0006VZ-6i for emacs-devel@gnu.org; Mon, 27 Jun 2005 04:04:31 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DmoaU-0006Ij-H1 for emacs-devel@gnu.org; Mon, 27 Jun 2005 04:03:26 -0400 Original-Received: from [194.109.24.27] (helo=smtp-vbr7.xs4all.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DmoPT-0003ZE-7Q; Mon, 27 Jun 2005 03:52:04 -0400 Original-Received: from pijl (a80-127-67-124.adsl.xs4all.nl [80.127.67.124]) by smtp-vbr7.xs4all.nl (8.13.3/8.13.3) with ESMTP id j5R7leju096403; Mon, 27 Jun 2005 09:47:40 +0200 (CEST) (envelope-from Lute.Kamstra@xs4all.nl) Original-Received: from lute by pijl with local (Exim 3.36 #1 (Debian)) id 1DmoLD-00028d-00; Mon, 27 Jun 2005 09:47:39 +0200 Original-To: rms@gnu.org In-Reply-To: (Richard M. Stallman's message of "Sun, 26 Jun 2005 00:46:21 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) Original-Lines: 28 X-Virus-Scanned: by XS4ALL Virus Scanner X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:39628 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:39628 "Richard M. Stallman" writes: > The faces menu automatically lists all faces that are defined > except those whose names are matched by facemenu-unlisted-faces. > I am pretty sure that list is not up to date, and that various > packages define faces that shouldn't be listed in the menu > but currently do get listed. > > We could go through all deffaces and update the value of > facemenu-unlisted-faces, but can we do something cleaner that will > require less maintenance? For instance, list in each defface > whether to include it in the face menu? Or list in each defface > if it should NOT be included in the face menu? Specifying all faces that shouldn't be listed (by means of facemenu-unlisted-faces) is not feasible. Every (external) lisp package can define faces which should not be listed. We can never anticipate the names of these faces. [We could introduce a variable facemenu-listed-faces that specifies the names of faces that should be listed in the menu. That would probably give better results.] I think that if we add an option to defface that can specify whether to add it to the face menu or not, that option should be optional and default to not as most faces should not be added to the face menu. Lute.