unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
Cc: emacs-devel@gnu.org
Subject: Re: filling bug in text-mode
Date: Sun, 09 Oct 2005 09:06:02 +0300	[thread overview]
Message-ID: <8764s7i93p.fsf@jurta.org> (raw)
In-Reply-To: <E1EONcq-0000yG-H1@fencepost.gnu.org> (Richard M. Stallman's message of "Sat, 08 Oct 2005 18:57:08 -0400")

>     One solution is to fix the regexp in `sentence-end' to match three
>     periods.
>
> I think that is the correct fix, because the sentence commands
> _should_ stop after three periods (when followed by two spaces
> or a newline).

Should the sentence commands stop also after three question marks???
And sentences can also end with three exclamation marks!!!

> It is a bug if they don't stop there.

This depends on the operational semantics of `sentence-end' rather
than its formal definition.  The current value of `sentence-end' allows
the sentence commands to process sentences with three periods correctly
except one place that caused this bug.  The use of `sentence-end' is
very questionable in this place.  Please, look at it again:

     (save-excursion
       (skip-chars-backward ". ")
       (and (looking-at "\\.")
     	    (not (looking-at (sentence-end)))))

Why only periods are skipped and matched by `looking-at' while
sentences can end also with `!' and `?' which are included in
`sentence-end' along with the period?

I'm inclined to fix this place rather than to change the default value
of `sentence-end'.  There are functions like `fill-delete-newlines'
that rely on its current default value, so changing the default value
of `sentence-end' will break such functions.

-- 
Juri Linkov
http://www.jurta.org/emacs/

  reply	other threads:[~2005-10-09  6:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-05 20:40 filling bug in text-mode Werner LEMBERG
2005-10-07 21:52 ` Juri Linkov
2005-10-08 22:57   ` Richard M. Stallman
2005-10-09  6:06     ` Juri Linkov [this message]
2005-10-10  4:14       ` Richard M. Stallman
2005-10-10  6:14         ` Juri Linkov
2005-10-10 13:44           ` Werner LEMBERG
2005-10-10 23:48           ` Richard M. Stallman
2005-10-11  4:34             ` Werner LEMBERG
2005-10-11 22:42               ` Richard M. Stallman
2005-10-14 11:42                 ` Juri Linkov
2005-10-11  7:22             ` David Kastrup
2005-10-11 14:31               ` Stefan Monnier
2005-10-11 22:43                 ` Richard M. Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8764s7i93p.fsf@jurta.org \
    --to=juri@jurta.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).