unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: suspicious GCPROs
Date: Mon, 20 Mar 2006 01:38:17 -0500	[thread overview]
Message-ID: <8764m9k4dx.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <E1FJm3I-00057h-00@etlken> (Kenichi Handa's message of "Thu, 16 Mar 2006 15:33:40 +0900")

> I've just checked all occurrences of GCPRO and found a few
> suspicious places.  Attached is the patch I propose.

> The first two patches (fileio.c and keymap.c) are clearly
> necessary because GCPROed variables are not yet initialized
> when GC occurs.

> The last two patchs (xfns.c and xterm.c) are also necessary
> for the same reason, but it seems to me that there's no need
> of GCPRO in the first place.  What do yo think?

Looks good to me, thanks,


        Stefan

      parent reply	other threads:[~2006-03-20  6:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-16  6:33 suspicious GCPROs Kenichi Handa
2006-03-17 16:32 ` Richard Stallman
2006-03-20  6:27   ` Kenichi Handa
2006-03-20  6:38 ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8764m9k4dx.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).