From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: michael.cadilhac@lrde.org (=?iso-8859-1?Q?Micha=EBl?= Cadilhac) Newsgroups: gmane.emacs.devel Subject: Re: delete-process bug Date: Tue, 30 May 2006 17:13:26 +0200 Organization: Epita/LRDE Message-ID: <8764jna6ll.fsf@lrde.org> References: <87k69eyddj.fsf@lrde.org> <87odxjakox.fsf@lrde.org> <8764jrlewm.fsf@lrde.org> <87pshyqgtd.fsf@lrde.org> <87fyiuq9t5.fsf@lrde.org> <877j45rj3w.fsf@lrde.org> <87k684y4uz.fsf@lrde.org> <87u0774rak.fsf@lrde.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1973201500==" X-Trace: sea.gmane.org 1149002037 15351 80.91.229.2 (30 May 2006 15:13:57 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 30 May 2006 15:13:57 +0000 (UTC) Cc: agustin.martin@hispalinux.es, Eli Zaretskii , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 30 17:13:51 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Fl5uI-0006H0-PP for ged-emacs-devel@m.gmane.org; Tue, 30 May 2006 17:13:22 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fl5uI-0001Mh-5K for ged-emacs-devel@m.gmane.org; Tue, 30 May 2006 11:13:18 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Fl5u4-0001Mc-Q3 for emacs-devel@gnu.org; Tue, 30 May 2006 11:13:04 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Fl5u3-0001MM-BV for emacs-devel@gnu.org; Tue, 30 May 2006 11:13:04 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fl5u3-0001MI-58 for emacs-devel@gnu.org; Tue, 30 May 2006 11:13:03 -0400 Original-Received: from [62.39.139.2] (helo=kualalumpur.lrde.epita.fr) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1Fl5zo-0000S9-EY; Tue, 30 May 2006 11:19:00 -0400 Original-Received: from mahaena.lrde.epita.fr ([192.168.101.66] helo=mahaena.lrde) by kualalumpur.lrde.epita.fr with esmtp (Exim 4.50) id 1Fl5te-0005Pm-BQ; Tue, 30 May 2006 17:12:38 +0200 Original-To: storm@cua.dk (Kim F. Storm) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEVWPh+Tai+5r5YKBAEU CQQzGAtiq7gjAAACR0lEQVQ4jW2UzW7lIAyFzVW8BzTZX5DmCZLuU2H2pMXv/ypzbK7aSh2kRCRf /HNsE0q7Sg+RQ7JFKaqtrRNAl5AIIKe6D5DBqgbmUAe5hBI1wIRFAHjeM0RKtZi7XVVEpb0BSNfA IddChChT5DildSLWOWhY5IEItMnncZgFcUAc/5jjwCMsDosRNdfKPDTFEdVBW8C+RebDb4N5Orio RhM1+11IJyx0ng2+LryFHBMPDQDYHrY6IfGuU3ouiXTQNE8LIJDKOWpNxERTFrggQwRPd7USUsTW fJ0XbR3bdj5KgBYy4SACpxDeUYEUAzLmtJ1iIrD2gczPq8Qomjhsh/RjGIgKIO8p7NITjwlx7WID nsnQe5NeuTvoBpi8LX6vLLOh5icjOHqBypgnuSp7M+RE1agbQKHQr5E2z1WObhYW4gMqeGQL7joM jCf2DxSk5ApADSYHfFF4igNfJZL1z0GKP0FN02s4XiDXr7V5P94W6I9v8MfBOQDmfwAaVYt+x8Da v4DJvX8BAdin3Knm5yMZYAO4ABDkDniZLLfi4P40gP1F0TPGZOu0CGwA1lcowxwlGy6A9705mD0V jHCxwVZT/hYdRJVUGZNlx6l7ScQBTluof6Wj6bsPYlvpwoTvXFD9gHPn2TZPF3ntI2ecxVrW5MrV XiCie5EeNa7BlWu/HNSkprDUva163PHxAv5jyGV7gVzyAghSKOTnat85UIYFICXbD2NV9rRiv0BS tKQsg6OHH4A15F1WW+UHKHHa32h6aPnAm3/pUcWp+WYnTQAAAABJRU5ErkJggg== In-Reply-To: (Kim F. Storm's message of "Tue, 30 May 2006 16:26:58 +0200") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:55482 Archived-At: --===============1973201500== Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable storm@cua.dk (Kim F. Storm) writes: > michael.cadilhac@lrde.org (Micha=EBl Cadilhac) writes: > >> Aaaand here comes the new new new (super better) new great patch >> v3923.3 (beta 1) ! > > Looks really fine now.=20=20 > > Can you write a ChangeLog entry for it, so we can install it. The whole patch follows: --=-=-= Content-Type: text/x-patch; charset=iso-8859-1 Content-Disposition: inline; filename=process.patch Content-Transfer-Encoding: quoted-printable Index: src/process.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /sources/emacs/emacs/src/process.c,v retrieving revision 1.481 diff -c -r1.481 process.c *** src/process.c 8 May 2006 05:19:42 -0000 1.481 =2D-- src/process.c 30 May 2006 15:04:55 -0000 *************** *** 778,783 **** =2D-- 778,793 ---- return proc; } =20=20 +=20 + #ifdef SIGCHLD + /* Fdelete_process promises to immediately forget about the process, but = in + reality, Emacs needs to remember those processes until they have been + treated by sigchld_handler; otherwise this handler would consider the + process as being synchronous and say that the synchronous process is + dead. */ + static Lisp_Object deleted_pid_list; + #endif +=20 DEFUN ("delete-process", Fdelete_process, Sdelete_process, 1, 1, 0, doc: /* Delete PROCESS: kill it and forget about it immediately. PROCESS may be a process, a buffer, the name of a process or buffer, or *************** *** 799,810 **** } else if (XINT (p->infd) >=3D 0) { ! Fkill_process (process, Qnil); ! /* Do this now, since remove_process will make sigchld_handler do n= othing. */ ! p->status ! =3D Fcons (Qsignal, Fcons (make_number (SIGKILL), Qnil)); ! XSETINT (p->tick, ++process_tick); ! status_notify (p); } remove_process (process); return Qnil; =2D-- 809,839 ---- } else if (XINT (p->infd) >=3D 0) { ! #ifdef SIGCHLD ! Lisp_Object symbol; !=20 ! /* No problem storing the pid here, as it is still in Vprocess_alis= t. */ ! deleted_pid_list =3D Fcons (make_fixnum_or_float (p->pid), ! /* GC treated elements set to nil. */ ! Fdelq (Qnil, deleted_pid_list)); ! /* If the process has already signaled, remove it from the list. */ ! if (p->raw_status_new) ! update_status (p); ! symbol =3D p->status; ! if (CONSP (p->status)) ! symbol =3D XCAR (p->status); ! if (EQ (symbol, Qsignal) || EQ (symbol, Qexit)) ! Fdelete (make_fixnum_or_float (p->pid), deleted_pid_list); ! else ! #endif ! { ! Fkill_process (process, Qnil); ! /* Do this now, since remove_process will make sigchld_handler do noth= ing. */ ! p->status ! =3D Fcons (Qsignal, Fcons (make_number (SIGKILL), Qnil)); ! XSETINT (p->tick, ++process_tick); ! status_notify (p); ! } } remove_process (process); return Qnil; *************** *** 6316,6321 **** =2D-- 6345,6351 ---- ** Malloc WARNING: This should never call malloc either directly or indirectly; if it does, that is a bug */ =20=20 + #ifdef SIGCHLD SIGTYPE sigchld_handler (signo) int signo; *************** *** 6373,6378 **** =2D-- 6403,6417 ---- =20=20 /* Find the process that signaled us, and record its status. */ =20=20 + /* The process can have been deleted by Fdelete_process. */ + tail =3D Fmember (make_fixnum_or_float (pid), deleted_pid_list); + if (!NILP (tail)) + { + Fsetcar (tail, Qnil); + goto sigchld_end_of_loop; + } +=20 + /* Otherwise, if it is asynchronous, it is in Vprocess_alist. */ p =3D 0; for (tail =3D Vprocess_alist; GC_CONSP (tail); tail =3D XCDR (tail)) { *************** *** 6424,6431 **** EMACS_SET_SECS_USECS (*input_available_clear_time, 0, 0); } =20=20 ! /* There was no asynchronous process found for that id. Check ! if we have a synchronous process. */ else { synch_process_alive =3D 0; =2D-- 6463,6470 ---- EMACS_SET_SECS_USECS (*input_available_clear_time, 0, 0); } =20=20 ! /* There was no asynchronous process found for that pid: we have ! a synchronous process. */ else { synch_process_alive =3D 0; *************** *** 6442,6447 **** =2D-- 6481,6490 ---- EMACS_SET_SECS_USECS (*input_available_clear_time, 0, 0); } =20=20 +=20 + sigchld_end_of_loop: + ; +=20 /* On some systems, we must return right away. If any more processes want to signal us, we will get another signal. *************** *** 6458,6463 **** =2D-- 6501,6507 ---- #endif /* USG, but not HPUX with WNOHANG */ } } + #endif /* SIGCHLD */ =20=20 static Lisp_Object *************** *** 6843,6848 **** =2D-- 6887,6895 ---- FD_SET (0, &input_wait_mask); =20=20 Vprocess_alist =3D Qnil; + #ifdef SIGCHLD + deleted_pid_list =3D Qnil; + #endif for (i =3D 0; i < MAXDESC; i++) { chan_process[i] =3D Qnil; *************** *** 6981,6986 **** =2D-- 7028,7036 ---- staticpro (&Qlast_nonmenu_event); =20=20 staticpro (&Vprocess_alist); + #ifdef SIGCHLD + staticpro (&deleted_pid_list); + #endif =20=20 DEFVAR_BOOL ("delete-exited-processes", &delete_exited_processes, doc: /* *Non-nil means delete processes immediately when they exi= t. Index: src/ChangeLog =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /sources/emacs/emacs/src/ChangeLog,v retrieving revision 1.5110 diff -c -r1.5110 ChangeLog *** src/ChangeLog 30 May 2006 04:33:52 -0000 1.5110 =2D-- src/ChangeLog 30 May 2006 15:04:56 -0000 *************** *** 1,3 **** =2D-- 1,16 ---- + 2006-05-30 Micha=EBl Cadilhac +=20 + * process.c (deleted_pid_list): Add a static variable to store the pids + of the deleted processes. Declare it only if SIGCHLD is defined. + (init_process): Initialize it. + (syms_of_process): Staticpro it. + (Fdelete_process): Add the deleted process to it. Check after the + addition and before the kill if the process is already stopped, in + which case it is deleted from the list and not killed. + (sigchld_handler): Define it only if SIGCHLD is. Search the process + that signaled Emacs in `deleted_pid_list' before `Vprocess_alist'. + Original idea by Stefan Monnier . +=20=09 2006-05-30 Richard Stallman =20=20 * coding.c (Ffind_operation_coding_system): Doc fix. --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable >> No problem. Hope you will not need a KILL signal in your brain, for >> the sake of your (?) CHLD. > > I don't know if GDB can be used to peek around before the > final KILL signal to make a core dump, in case anybody > need to do some post-mortem analysis ... Mmmh... Wondering if someone HAS to see you after the KILL signal to avoid being a zombie. > Anyway, I've just sent the looping process a SIGSTOP --=20=20 > so I can wake it up again in case we need another round > through the loop ;-) We shall debug that, but after the release. :-) =2D-=20 | Micha=EBl `Micha' Cadilhac | Mieux vaut se taire = | | Epita/LRDE Promo 2007 | Que de parler trop fort. = | | http://www.lrde.org/~cadilh_m | -- As de tr=E8fle = | `-- - JID: micha@amessage.be --' - -= -' --=-=-=-- --==-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) iD8DBQFEfGEZZYNf4qobZ7kRAvAwAJ9vkYJCJCGO1ENT8Lm3hD/yNgzs8ACgt5X4 1XJXYHA+pKqf9bLRuoRzaYg= =WnhM -----END PGP SIGNATURE----- --==-=-=-- --===============1973201500== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel --===============1973201500==--