From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: michael.cadilhac@lrde.org (=?iso-8859-1?Q?Micha=EBl?= Cadilhac) Newsgroups: gmane.emacs.devel Subject: Re: delete-process bug Date: Thu, 01 Jun 2006 16:20:43 +0200 Organization: Epita/LRDE Message-ID: <8764jlyn2c.fsf@lrde.org> References: <87k69eyddj.fsf@lrde.org> <87odxjakox.fsf@lrde.org> <8764jrlewm.fsf@lrde.org> <87pshyqgtd.fsf@lrde.org> <87fyiuq9t5.fsf@lrde.org> <877j45rj3w.fsf@lrde.org> <87k684y4uz.fsf@lrde.org> <87u0774rak.fsf@lrde.org> <8764jna6ll.fsf@lrde.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0553080946==" X-Trace: sea.gmane.org 1149171603 23542 80.91.229.2 (1 Jun 2006 14:20:03 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 1 Jun 2006 14:20:03 +0000 (UTC) Cc: Agustin Martin , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jun 01 16:19:59 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Flo1m-0003Dj-Ff for ged-emacs-devel@m.gmane.org; Thu, 01 Jun 2006 16:19:58 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Flo1l-0001dd-TW for ged-emacs-devel@m.gmane.org; Thu, 01 Jun 2006 10:19:57 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Flo1Y-0001dY-3T for emacs-devel@gnu.org; Thu, 01 Jun 2006 10:19:44 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Flo1W-0001d6-C8 for emacs-devel@gnu.org; Thu, 01 Jun 2006 10:19:43 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Flo1W-0001d2-6q for emacs-devel@gnu.org; Thu, 01 Jun 2006 10:19:42 -0400 Original-Received: from [62.39.139.2] (helo=kualalumpur.lrde.epita.fr) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1Flo7m-0001z0-0a for emacs-devel@gnu.org; Thu, 01 Jun 2006 10:26:10 -0400 Original-Received: from mahaena.lrde.epita.fr ([192.168.101.66] helo=mahaena.lrde) by kualalumpur.lrde.epita.fr with esmtp (Exim 4.50) id 1Flo1T-0004zZ-UM; Thu, 01 Jun 2006 16:19:39 +0200 Original-To: storm@cua.dk (Kim F. Storm) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEU/JREXDATg1LV8UCao i1fQpmoP3Nd6AAACa0lEQVQ4jWWUQW7jMAxFqZEPICJzAjXeM6W8dyNqX9ji/a8yn04xnWIEJLD9 LJH85DcJFyJV3erqPty8ExHfBikXSdn0WVezC0hOAQiA2nCsAHOqEnPe4k+puU8zw/t+xquqjRKA 4lHsmQBT8C5pDtBwfwH8VdcHI5+FHtjRxrQRwZsf3hNjZRKAPEzHEdH9mFNSYb5dQK3r8KM6ftNy KikAirDZFWdVkDqbxjGFbAcwbQCxxc8mPRHUGOcCIMgMACV23RfJTch3gC6ofT3qCdG0NyUUPfYF yQrKCIAnuYsgX2qPzW2i9sNrfSOSPPZQiygtCNlCjlpXJV38lIKshF/AZzsAMoArdCKNHfXukPuJ ImbLh+9J2gXwap0QpZ7NjZ7ekdkFcDiqPiLGcHmuvaG/AHgy62s52Lae1ABoA7D6d2kDoAvgbnyD ZutEd6lTHOXfYPHVJDH1K8a1+oyrjoZpAGn1x5pfwPr2E9yjxSpk50/gEyKgD/+BD/KzN3tQ13b8 Cx5loF0AgnZf5IUny9hRHQOYBllHDM+6s3oviZBu77mFjDm621Np3hkjR90wE1BkTYvhdDgDgCmR xWChFfcYAOqMm5NZkVWMur8AL5+oeMQOob2FmY76FiM+PrDDZypwGdqokSlAaQOmGH6mW8KpsOwl 0YOLedjSITr6scNRF8D4PesH33QmLrx8AzjpV/3kkg025w2gfAFYKCLluJAc4Ap+h18oo4S8wzaY klDsBUTiY8EZFkg5Iass75FubC9wd8qa0u9+gRxAsAKEaRAo6iB+vwCMGmdBjvgidQGA1ntMX4CS ZYGV/wADyL80LIX/UAAAAABJRU5ErkJggg== In-Reply-To: (Kim F. Storm's message of "Thu, 01 Jun 2006 16:06:39 +0200") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:55556 Archived-At: --===============0553080946== Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable storm@cua.dk (Kim F. Storm) writes: > michael.cadilhac@lrde.org (Micha=EBl Cadilhac) writes: > >> The whole patch follows: > > Thanks. Installed. Thanks! Now that this bug is fixed, Agustin, can you check (a third time) if the first patch is OK? (Copy of the message follows) michael.cadilhac@lrde.org (Micha=EBl Cadilhac) writes: > I was wondering why ispell-kill-process took so much time to > execute. > > This function does the following: > - Send EOF to ispell, > - Read its output if there is, timeout to 1 sec, > - Kill the process if it's still not, > - Wait for it to be really killed (sleeping for 0.25 sec between checks= ). Oh, and BTW, why is the wait_for_termination function not provided to the user? > I don't want to be ... rude, I'm really a pacifist actually, but why > not just delete-process it ? > I propose the following change: --=-=-= Content-Type: text/x-patch; charset=iso-8859-1 Content-Disposition: inline; filename=ispell.patch Content-Transfer-Encoding: quoted-printable Index: lisp/ChangeLog =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /sources/emacs/emacs/lisp/ChangeLog,v retrieving revision 1.9586 diff -c -B -b -r1.9586 ChangeLog *** lisp/ChangeLog 23 May 2006 11:23:25 -0000 1.9586 =2D-- lisp/ChangeLog 23 May 2006 18:17:41 -0000 *************** *** 1,3 **** =2D-- 1,9 ---- + 2006-05-23 Micha=EBl Cadilhac +=20 + * textmodes/ispell.el (ispell-kill-ispell): If ispell has been + launched asynchronously, delete its process instead of being + cool. +=20 2006-05-23 Thien-Thi Nguyen =20=20 * emacs-lisp/ewoc.el (ewoc-delete): New function. Index: lisp/textmodes/ispell.el =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /sources/emacs/emacs/lisp/textmodes/ispell.el,v retrieving revision 1.199 diff -c -B -b -r1.199 ispell.el *** lisp/textmodes/ispell.el 21 May 2006 20:25:43 -0000 1.199 =2D-- lisp/textmodes/ispell.el 23 May 2006 18:17:41 -0000 *************** *** 2572,2586 **** (or no-error (error "There is no ispell process running!")) (if ispell-async-processp ! (progn ! (process-send-eof ispell-process) ! (if (eq (ispell-process-status) 'run) ! (ispell-accept-output 1)) ! (if (eq (ispell-process-status) 'run) ! (kill-process ispell-process)) ! (while (not (or (eq (ispell-process-status) 'exit) ! (eq (ispell-process-status) 'signal))) ! (sleep-for 0.25))) ;; synchronous processes (ispell-send-string "\n") ; make sure side effects occurred. (kill-buffer ispell-output-buffer) =2D-- 2572,2578 ---- (or no-error (error "There is no ispell process running!")) (if ispell-async-processp ! (delete-process ispell-process) ;; synchronous processes (ispell-send-string "\n") ; make sure side effects occurred. (kill-buffer ispell-output-buffer) --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable =2D-=20 | Micha=EBl `Micha' Cadilhac | Mieux vaut se taire = | | Epita/LRDE Promo 2007 | Que de parler trop fort. = | | http://www.lrde.org/~cadilh_m | -- As de tr=E8fle = | `-- - JID: micha@amessage.be --' - -= -' --=-=-=-- --==-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) iD8DBQFEfve9ZYNf4qobZ7kRAmCdAJ0e+i+w3yNqGxEzl3XWMvhAZzN7dACdGr16 Z8l48g1JM9Ag8uCCknoWVN4= =EueC -----END PGP SIGNATURE----- --==-=-=-- --===============0553080946== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel --===============0553080946==--