unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@stupidchicken.com>
Cc: Juri Linkov <juri@jurta.org>, rms@gnu.org, emacs-devel@gnu.org
Subject: Re: Links in WoMan buffer should not call `man'
Date: Tue, 05 Sep 2006 16:56:11 -0400	[thread overview]
Message-ID: <8764g2xcb8.fsf@stupidchicken.com> (raw)
In-Reply-To: <874pvmx47i.fsf@cs.cmu.edu> (Michael Welsh Duggan's message of "Tue\, 05 Sep 2006 01\:38\:57 -0400")

Michael Welsh Duggan <md5i@cs.cmu.edu> writes:

>> Some time later, I am realizing that string_match_1 is using
>> current_buffer's case table.  Since the string being matched against
>> might have nothing to do with the current buffer, this seems
>> incorrect.  Is this a red herring?
>
> More data:  The *Message* buffer at dump time has a case_canon_table
> with three extra slots, all nil.

This patch removes the bug, and is probably the correct thing to do.
Any objections to my installing it?

*** emacs/src/regex.c.~1.211.~	2006-02-21 14:36:47.000000000 -0500
--- emacs/src/regex.c	2006-09-05 16:53:54.000000000 -0400
***************
*** 2162,2168 ****
  
    Lisp_Object eqv_table;
  
!   if (!RE_TRANSLATE_P (translate))
      {
        EXTEND_RANGE_TABLE (work_area, 2);
        work_area->table[work_area->used++] = (start);
--- 2162,2170 ----
  
    Lisp_Object eqv_table;
  
!   if (!RE_TRANSLATE_P (translate)
!       || (eqv_table = XCHAR_TABLE (translate)->extras[2],
! 	  NILP (eqv_table)))
      {
        EXTEND_RANGE_TABLE (work_area, 2);
        work_area->table[work_area->used++] = (start);
***************
*** 2170,2177 ****
        return -1;
      }
  
-   eqv_table = XCHAR_TABLE (translate)->extras[2];
- 
    for (; start <= end; start++)
      {
        enum case_type this_type;
--- 2172,2177 ----

  reply	other threads:[~2006-09-05 20:56 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-25 19:52 Links in WoMan buffer should not call `man' Reiner Steib
2006-08-25 22:14 ` Chong Yidong
2006-08-26 11:36   ` Reiner Steib
2006-08-28 15:42     ` Chong Yidong
2006-08-27 20:12 ` Juri Linkov
2006-08-27 22:28   ` Eli Zaretskii
2006-08-28 22:09   ` Richard Stallman
2006-08-30 10:45     ` Eli Zaretskii
2006-08-30 22:48       ` Juri Linkov
2006-09-02 23:57     ` Juri Linkov
2006-09-04  9:50       ` Richard Stallman
2006-09-04 22:54         ` Juri Linkov
2006-09-05  3:38           ` Michael Welsh Duggan
2006-09-05  3:43             ` Michael Welsh Duggan
2006-09-05  4:31               ` Michael Welsh Duggan
2006-09-05  5:38                 ` Michael Welsh Duggan
2006-09-05 20:56                   ` Chong Yidong [this message]
2006-09-06 19:06                     ` Richard Stallman
2006-09-07 21:15                     ` Richard Stallman
2006-09-06  8:49                 ` Richard Stallman
2006-09-06  8:49           ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8764g2xcb8.fsf@stupidchicken.com \
    --to=cyd@stupidchicken.com \
    --cc=emacs-devel@gnu.org \
    --cc=juri@jurta.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).