From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: crash: x_error_quitter Date: Sun, 13 May 2007 09:52:10 -0400 Message-ID: <87646whlv9.fsf@stupidchicken.com> References: <87r6pnnn6b.fsf@stupidchicken.com> <87abw9ty8n.fsf@stupidchicken.com> <46470BEF.4080107@swipnet.se> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1179064362 8589 80.91.229.12 (13 May 2007 13:52:42 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 13 May 2007 13:52:42 +0000 (UTC) Cc: rms@gnu.org, emacs-devel@gnu.org To: Jan =?utf-8?Q?Dj=C3=A4rv?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 13 15:52:41 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HnEV7-0008EC-2l for ged-emacs-devel@m.gmane.org; Sun, 13 May 2007 15:52:41 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HnEcl-0004cQ-1n for ged-emacs-devel@m.gmane.org; Sun, 13 May 2007 10:00:35 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HnEcT-0004Yg-GI for emacs-devel@gnu.org; Sun, 13 May 2007 10:00:17 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HnEcS-0004Y8-Ga for emacs-devel@gnu.org; Sun, 13 May 2007 10:00:16 -0400 Original-Received: from south-station-annex.mit.edu ([18.72.1.2]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HnEUn-0004Ah-Kz; Sun, 13 May 2007 09:52:21 -0400 Original-Received: from grand-central-station.mit.edu (GRAND-CENTRAL-STATION.MIT.EDU [18.7.21.82]) by south-station-annex.mit.edu (8.13.6/8.9.2) with ESMTP id l4DDqKQQ024165; Sun, 13 May 2007 09:52:20 -0400 (EDT) Original-Received: from outgoing-legacy.mit.edu (OUTGOING-LEGACY.MIT.EDU [18.7.22.104]) by grand-central-station.mit.edu (8.13.6/8.9.2) with ESMTP id l4DDqDIa001272; Sun, 13 May 2007 09:52:13 -0400 (EDT) Original-Received: from localhost (SYDNEYPACIFIC-FIVE-NINETY-FIVE.MIT.EDU [18.95.7.84]) ) by outgoing-legacy.mit.edu (8.13.6/8.12.4) with ESMTP id l4DDqA5M011102; Sun, 13 May 2007 09:52:12 -0400 (EDT) Original-Received: from cyd by localhost with local (Exim 3.36 #1 (Debian)) id 1HnEUc-0004MW-00; Sun, 13 May 2007 09:52:10 -0400 In-Reply-To: <46470BEF.4080107@swipnet.se> ("Jan =?utf-8?Q?Dj=C3=A4rv=22's?= message of "Sun\, 13 May 2007 15\:00\:31 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1.50 (gnu/linux) X-Scanned-By: MIMEDefang 2.42 X-Spam-Score: -2.599 X-detected-kernel: Solaris 9.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:70964 Archived-At: Jan Dj=C3=A4rv writes: >>> The reason we make this crash is so we can find the causes and fix them. >> >> Except I don't think we've found a single legitimate bug this way. > > Yes we have. > >> Every time this comes up, we just end up adding yet another call to >> x_catch_error. Since X "protocol errors" are really more like warning >> messages (as opposed to X "fatal errors"), I don't envision any other >> situation cropping up. > > Depends on the error. Some are really fatal. > >> But hey, CPU cycles are cheap these days, so what does it matter if we >> plaster unnecessary x_catch_error calls all over the code. > > It can hide a real error that causes the protocol error in the first plac= e. What's wrong with spitting out an error message to the terminal and trying to continue, as I believe other X programs do?