From: Michael Olson <mwolson@gnu.org>
To: emacs-devel@gnu.org
Subject: Re: Patch: Add call graph to elp.el
Date: Sun, 10 Feb 2008 15:09:16 -0600 [thread overview]
Message-ID: <8763wwmscj.fsf@grepfind.mwolson.org> (raw)
In-Reply-To: 47AD63E8.8080308@fastmail.net
[-- Attachment #1: Type: text/plain, Size: 1501 bytes --]
Christian Ohler <ohler+emacs@fastmail.net> writes:
> The attached patch makes elp.el record and display call graph
> information. This makes the profiler much more useful.
Just a few nitpicks before reviewing more in-depth.
> Christian.
> --- elp.el 28 Jan 2008 22:48:53 +0100 1.43
> +++ elp.el 08 Feb 2008 21:58:18 +0100
> @@ -126,6 +126,8 @@
>
> ;;; Code:
>
> +(require 'cl)
> +
Should be:
(eval-when-compile (require 'cl))
> @@ -245,7 +262,7 @@
> ;; definition.
> (elp-restore-function funsym)
> (let* ((funguts (symbol-function funsym))
> - (infovec (vector 0 0 funguts))
> + (infovec (vector 0 0 funguts (list) (list)))
> (newguts '(lambda (&rest args))))
> ;; we cannot profile macros
> (and (eq (car-safe funguts) 'macro)
Use a tab instead of a space at the beginning, because that is what is
done in the rest of the file.
> @@ -386,6 +403,8 @@
> (aset info 0 0) ;reset call counter
> (aset info 1 0.0) ;reset total time
> ;; don't muck with aref 2 as that is the old symbol definition
> + (aset info 3 (list)) ;reset children
> + (aset info 4 (list)) ;reset parents
> ))
Tab instead of space between code and comment.
--
| Michael Olson | FSF Associate Member #652 |
| http://mwolson.org/ | Hobbies: Lisp, HCoop |
| Projects: Emacs, Muse, ERC, EMMS, ErBot, DVC, Planner |
`-------------------------------------------------------'
[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]
prev parent reply other threads:[~2008-02-10 21:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-09 8:27 Patch: Add call graph to elp.el Christian Ohler
2008-02-10 0:21 ` Mike Mattie
2008-02-10 21:09 ` Michael Olson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8763wwmscj.fsf@grepfind.mwolson.org \
--to=mwolson@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).