unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: Miles Bader <miles@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: C-u prefix behavior of TAB broken
Date: Sun, 24 Feb 2008 21:05:09 +0200	[thread overview]
Message-ID: <8763we18xf.fsf@jurta.org> (raw)
In-Reply-To: <87mys272v7.fsf@catnip.gol.com> (Miles Bader's message of "Sun, 23 Dec 2007 07:59:08 +0900")

> +      ;; If a prefix argument was given, rigidly indent the following
> +      ;; sexp to match the change in the current line's indentation.
> +      (when arg
> +	(let ((indentation-change (- (current-indentation) old-indent)))
> +	  (unless (zerop indentation-change)
> +	    (save-excursion
> +	      (forward-line 1)
> +	      (when (< (point) end-marker)
> +		(indent-rigidly (point) end-marker indentation-change))))))))))

I have bound a key to the command that calls `indent-for-tab-command'
with a prefix argument, and when I accidently type it a close parenthesis,
it fails with the error "Containing expression ends prematurely".

I think it would be better not to fail at such places, and just indent
the current line without indenting the following sexp.

The following patch fixes this.  Any better ideas?

Index: lisp/indent.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/indent.el,v
retrieving revision 1.76
diff -u -r1.76 indent.el
--- lisp/indent.el	8 Jan 2008 20:44:48 -0000	1.76
+++ lisp/indent.el	24 Feb 2008 19:04:32 -0000
@@ -29,6 +29,8 @@
 
 ;;; Code:
 
+(eval-when-compile (require 'cl)) ;; for `ignore-errors'
+
 (defgroup indent nil
   "Indentation commands."
   :group 'editing)
@@ -109,7 +111,7 @@
     (let ((end-marker
 	   (and arg
 		(save-excursion
-		  (forward-line 0) (forward-sexp) (point-marker))))
+		  (forward-line 0) (ignore-errors (forward-sexp)) (point-marker))))
 	  (old-indent
 	   (current-indentation)))
 
-- 
Juri Linkov
http://www.jurta.org/emacs/




  reply	other threads:[~2008-02-24 19:05 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-16 22:07 C-u prefix behavior of TAB broken Miles Bader
2007-12-17 12:48 ` martin rudalics
2007-12-17 14:27   ` Miles Bader
2007-12-17 19:03     ` martin rudalics
2007-12-21  0:20       ` Stefan Monnier
2007-12-21 19:49         ` Richard Stallman
2007-12-22  0:11           ` Miles Bader
2007-12-22  9:28             ` martin rudalics
2007-12-22 13:48               ` Miles Bader
2007-12-22 17:41                 ` martin rudalics
2007-12-22 19:52                   ` Miles Bader
2007-12-22 22:35                     ` martin rudalics
2007-12-22 22:59                       ` Miles Bader
2008-02-24 19:05                         ` Juri Linkov [this message]
2008-02-24 19:26                           ` Miles Bader
2008-02-24 19:40                             ` Juri Linkov
2008-02-25  2:56                               ` Miles Bader
2007-12-23  0:55                   ` Stefan Monnier
2007-12-23  1:39                     ` Miles Bader
2007-12-23 21:49                       ` Stefan Monnier
2007-12-22 21:08               ` Richard Stallman
2007-12-22 22:08                 ` martin rudalics
2007-12-23 21:11                   ` Richard Stallman
2007-12-23 21:44                     ` martin rudalics
2007-12-24 21:55                       ` Richard Stallman
2007-12-24 22:33                         ` martin rudalics
2007-12-26  5:29                           ` Richard Stallman
2007-12-26 13:49                             ` Vinicius Jose Latorre
2007-12-26 21:26                               ` Richard Stallman
2007-12-27 20:19                             ` Juri Linkov
2007-12-28 13:55                               ` Richard Stallman
2007-12-28 13:55                               ` Richard Stallman
2008-01-03 21:52                                 ` Juri Linkov
2008-01-03 23:50                                   ` Miles Bader
2007-12-23  0:51               ` Stefan Monnier
2007-12-23  9:13                 ` martin rudalics
2007-12-26  3:00           ` Miles Bader
2007-12-18  2:24     ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8763we18xf.fsf@jurta.org \
    --to=juri@jurta.org \
    --cc=emacs-devel@gnu.org \
    --cc=miles@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).