From: Sven Joachim <svenjoac@gmx.de>
To: Eric Hanchrow <eric.hanchrow@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: recent checkin broke the Emacs build
Date: Thu, 12 Feb 2009 09:33:07 +0100 [thread overview]
Message-ID: <8763jgt5q4.fsf@turtle.gmx.de> (raw)
In-Reply-To: <36366a980902112042i1632c9ecnfae66669cc2ad172@mail.gmail.com> (Eric Hanchrow's message of "Wed, 11 Feb 2009 20:42:49 -0800")
On 2009-02-12 05:42 +0100, Eric Hanchrow wrote:
> In file included from /usr/local/src/emacs/lib-src/movemail.c:687:
> /usr/include/time.h: At top level:
> /usr/include/time.h:187: error: conflicting types for 'time'
> /usr/local/src/emacs/lib-src/movemail.c:362: error: previous implicit
> declaration of 'time' was here
Here is a patch for this:
--8<---------------cut here---------------start------------->8---
--- movemail.c.~1.99.~ 2009-02-12 09:07:07.000000000 +0100
+++ movemail.c 2009-02-12 09:25:41.000000000 +0100
@@ -60,6 +60,7 @@
#include <sys/file.h>
#include <stdio.h>
#include <errno.h>
+#include <time.h>
#include <getopt.h>
#ifdef HAVE_UNISTD_H
@@ -375,7 +376,7 @@
int lockcount = 0;
int status = 0;
#if defined (MAIL_USE_MAILLOCK) && defined (HAVE_TOUCHLOCK)
- long touched_lock, now;
+ time_t touched_lock, now;
#endif
setuid (getuid ());
@@ -684,7 +685,6 @@
#endif
#include <pwd.h>
#include <string.h>
-#include <time.h>
#define NOTOK (-1)
#define OK 0
--8<---------------cut here---------------end--------------->8---
Suggested Changelog entry:
2009-02-12 Sven Joachim <svenjoac@gmx.de>
* movemail.c (main): Include time.h unconditionally.
next prev parent reply other threads:[~2009-02-12 8:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <36366a980902102137p3f495058hfb9bb9eb827edca@mail.gmail.com>
2009-02-12 4:42 ` recent checkin broke the Emacs build Eric Hanchrow
2009-02-12 8:33 ` Sven Joachim [this message]
2009-02-13 7:25 ` Tassilo Horn
2009-02-13 10:03 ` Sven Joachim
2009-02-13 10:21 ` Tassilo Horn
2009-02-13 14:23 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8763jgt5q4.fsf@turtle.gmx.de \
--to=svenjoac@gmx.de \
--cc=emacs-devel@gnu.org \
--cc=eric.hanchrow@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).