From: Chong Yidong <cyd@stupidchicken.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Dan Nicolaescu <dann@gnu.org>, emacs-devel@gnu.org
Subject: Re: split up process.c
Date: Sun, 11 Jul 2010 10:48:39 -0400 [thread overview]
Message-ID: <87630mf514.fsf@stupidchicken.com> (raw)
In-Reply-To: <83vd8mv99d.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 11 Jul 2010 09:10:38 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> > There's now only one function, wait_reading_process_output, which
>> > has 2 different implementations. (I could easily have a single
>> > function with two different bodies conditioned by `subprocesses',
>> > or I could move the second implementation to msdos.c, if people
>> > prefer that. But both alternatives looked no cleaner, and the
>> > latter would even make more maintenance headaches, IMO.)
>>
>> IMO it should go to msdos.c unless that requires other important code
>> changes.
>
> I will defer to Stefan and Yidong for the decision. Personally, I
> think having a function with the same name on two different source
> files will make maintenance a tad harder than it is when they are on
> the same file.
I think the present situation is fine.
prev parent reply other threads:[~2010-07-11 14:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-08 18:33 Changes in process.c Eli Zaretskii
2010-07-08 18:52 ` split up process.c [was: Re: Changes in process.c] Dan Nicolaescu
2010-07-08 20:35 ` Eli Zaretskii
2010-07-08 23:05 ` Dan Nicolaescu
2010-07-09 23:01 ` split up process.c Glenn Morris
2010-07-10 1:35 ` Dan Nicolaescu
2010-07-10 13:43 ` split up process.c [was: Re: Changes in process.c] Eli Zaretskii
2010-07-11 3:40 ` split up process.c Dan Nicolaescu
2010-07-11 6:10 ` Eli Zaretskii
2010-07-11 14:48 ` Chong Yidong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87630mf514.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=dann@gnu.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).