From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.devel Subject: Re: bug in copy-directory Date: Sat, 12 Feb 2011 08:06:20 +0100 Message-ID: <8762spspeb.fsf@gmail.com> References: <87ipxaidea.fsf@gmail.com> <87hbcot7gq.fsf@gmx.de> <87ei7qrdp0.fsf@gmail.com> <87ipx2dayh.fsf@gmx.de> <87y65yyxfu.fsf@gmail.com> <87d3n8xkeq.fsf@gmail.com> <878vxw6r4m.fsf@gmx.de> <87pqr790b0.fsf@gmail.com> <87oc6r7gjc.fsf@gmx.de> <87ipwz8t92.fsf@gmail.com> <878vxt69k7.fsf@stupidchicken.com> <874o8hbc9q.fsf@gmx.de> <87y65txele.fsf@gmail.com> <87tyghxdgx.fsf@gmail.com> <87wrl98adj.fsf@stupidchicken.com> <87k4h7at1c.fsf@gmail.com> <87fwrvkm3y.fsf@gmx.de> <871v3eucjw.fsf@gmail.com> <87tyga86p0.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: dough.gmane.org 1297494858 3230 80.91.229.12 (12 Feb 2011 07:14:18 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 12 Feb 2011 07:14:18 +0000 (UTC) Cc: Michael Albinus , emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 12 08:14:13 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Po9gJ-0000u0-G0 for ged-emacs-devel@m.gmane.org; Sat, 12 Feb 2011 08:14:12 +0100 Original-Received: from localhost ([127.0.0.1]:47558 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Po9gI-0006bt-Jk for ged-emacs-devel@m.gmane.org; Sat, 12 Feb 2011 02:14:10 -0500 Original-Received: from [140.186.70.92] (port=57731 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Po9gC-0006bN-D8 for emacs-devel@gnu.org; Sat, 12 Feb 2011 02:14:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Po9gA-0001Jl-5Z for emacs-devel@gnu.org; Sat, 12 Feb 2011 02:14:04 -0500 Original-Received: from mail-fx0-f41.google.com ([209.85.161.41]:54747) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Po9Ym-00007g-LE for emacs-devel@gnu.org; Sat, 12 Feb 2011 02:06:24 -0500 Original-Received: by fxm12 with SMTP id 12so3661562fxm.0 for ; Fri, 11 Feb 2011 23:06:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=o9boOhoEg4FdwnJQ1MXtxeFSMwXKZwvNesZMWanSAWQ=; b=i6l9uX1GMcHts/hcfW3vn0I1KPBQrBQUyj6NWo5mR/yDs86R5ErCgjdH5fn+erEKQj PQn1RrvM5VGylhHMnjt13NNnFrP7yAN1cTRcuuqufASYz33tREHYuhoiXzZbvHRw5PJ0 Ft43uhmc+5KZ4EhSAGRImQq7I7BRPh+4YmnbQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=BpQHkN44dm82yPWkF3t/tBSspcOtbQ7hO7yiAePoNme66t0UmxYPn847Cl9imWlwcg K5mYpd6xHnnT4T1W9PMdY/di7BcUS+keeNhKd/wRlJVr574CvgG7kB3/40JCfCJQCugL 1SQscvbq//+/PHFZUdnUjElP7Ja6FSsa+16AA= Original-Received: by 10.223.101.136 with SMTP id c8mr1547979fao.100.1297494383721; Fri, 11 Feb 2011 23:06:23 -0800 (PST) Original-Received: from thierry-MM061 (131.78.88-79.rev.gaoland.net [79.88.78.131]) by mx.google.com with ESMTPS id z1sm47926fau.21.2011.02.11.23.06.21 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 11 Feb 2011 23:06:22 -0800 (PST) In-Reply-To: <87tyga86p0.fsf@stupidchicken.com> (Chong Yidong's message of "Fri, 11 Feb 2011 18:58:19 -0500") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.2.93 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.161.41 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:135932 Archived-At: --=-=-= Content-Type: text/plain Chong Yidong writes: > Thierry Volpiatto writes: > >> Michael Albinus writes: >> >>>> (defun copy-directory (directory newname &optional keep-time >>> parents copy-contents-only) >>> >>> I'm in favor of this proposal (compared with the recently introduced >>> `copy-as-subdir'). Thierry's proposal keeps the semantics of >>> `copy-directory', and the changed semantics are activated by the >>> optional argument. >> >> So when everybody is ok, i can send patch with this modification. >> Tell me also if copy-contents-only as arg name is ok for you (if you >> have better idea i take). > > This is OK for the trunk. If we go this route, I'd prefer to revert the > branch to the Emacs 23.2 behavior, since it requires non-local changes > and is backward incompatible; then we'll make the change for Emacs 24. ???I would say revert to Emacs 23.2 bug... > Go ahead and send the patch anytime it's ready. Find it attached. -- A+ Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997 --=-=-= Content-Type: application/octet-stream Content-Disposition: attachment; filename=copy-only-contents Content-Transfer-Encoding: base64 QnVnZml4IGNvcHktZGlyZWN0b3J5CgpGcm9tOiBUaGllcnJ5IFZvbHBpYXR0byA8dGhpZXJyeS52 b2xwaWF0dG9AZ21haWwuY29tPgoKbGlzcC9maWxlcy5lbCAoY29weS1kaXJlY3RvcnkpOiBuZXcg YXJnIGNvcHktb25seS1jb250ZW50cyBBbGxvdyB0byBjb3B5IGNvbnRlbnRzIG9mIGRpcmVjdG9y eSB3aGl0b3V0IHN1YmRpci4KCmxpc3AvZGlyZWQtYXV4LmVsIChkaXJlZC1jcmVhdGUtZmlsZXMp OiBEb24ndCBjcmVhdGUgc3ViZGlyZWN0b3J5IGluIGRpcmVkLWNvcHktZmlsZS4KLS0tCiBsaXNw L2ZpbGVzLmVsIHwgICA3NyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0KIDEgZmlsZXMgY2hhbmdlZCwgMzkgaW5zZXJ0aW9ucygrKSwgMzgg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9maWxlcy5lbCBiL2xpc3AvZmlsZXMuZWwK aW5kZXggZDg5NjAyMC4uNjExMzFkYyAxMDA2NDQKLS0tIGEvbGlzcC9maWxlcy5lbAorKysgYi9s aXNwL2ZpbGVzLmVsCkBAIC00NzIzLDcgKzQ3MjMsNyBAQCBJZiBSRUNVUlNJVkUgaXMgbm9uLW5p bCwgYWxsIGZpbGVzIGluIERJUkVDVE9SWSBhcmUgZGVsZXRlZCBhcyB3ZWxsLiIKIAkJIGRpcmVj dG9yeSAnZnVsbCBkaXJlY3RvcnktZmlsZXMtbm8tZG90LWZpbGVzLXJlZ2V4cCkpKQogICAgICAg KGRlbGV0ZS1kaXJlY3RvcnktaW50ZXJuYWwgZGlyZWN0b3J5KSkpKSkKIAotKGRlZnVuIGNvcHkt ZGlyZWN0b3J5IChkaXJlY3RvcnkgbmV3bmFtZSAmb3B0aW9uYWwga2VlcC10aW1lIHBhcmVudHMp CisoZGVmdW4gY29weS1kaXJlY3RvcnkgKGRpcmVjdG9yeSBuZXduYW1lICZvcHRpb25hbCBrZWVw LXRpbWUgcGFyZW50cyBjb250ZW50cy1vbmx5KQogICAiQ29weSBESVJFQ1RPUlkgdG8gTkVXTkFN RS4gIEJvdGggYXJncyBtdXN0IGJlIHN0cmluZ3MuCiBJZiBORVdOQU1FIG5hbWVzIGFuIGV4aXN0 aW5nIGRpcmVjdG9yeSwgY29weSBESVJFQ1RPUlkgYXMgc3ViZGlyZWN0b3J5IHRoZXJlLgogCkBA IC00NzUzLDQzICs0NzUzLDQ0IEBAIHRoaXMgaGFwcGVucyBieSBkZWZhdWx0LiIKICAgICAoaWYg aGFuZGxlcgogCShmdW5jYWxsIGhhbmRsZXIgJ2NvcHktZGlyZWN0b3J5IGRpcmVjdG9yeSBuZXdu YW1lIGtlZXAtdGltZSBwYXJlbnRzKQogCi0gICAgICA7OyBDb21wdXRlIHRhcmdldCBuYW1lLgot ICAgICAgKHNldHEgZGlyZWN0b3J5IChkaXJlY3RvcnktZmlsZS1uYW1lIChleHBhbmQtZmlsZS1u YW1lIGRpcmVjdG9yeSkpCi0JICAgIG5ld25hbWUgICAoZGlyZWN0b3J5LWZpbGUtbmFtZSAoZXhw YW5kLWZpbGUtbmFtZSBuZXduYW1lKSkpCi0KLSAgICAgIChpZiAobm90IChmaWxlLWRpcmVjdG9y eS1wIG5ld25hbWUpKQotCSAgOzsgSWYgTkVXTkFNRSBpcyBub3QgYW4gZXhpc3RpbmcgZGlyZWN0 b3J5LCBjcmVhdGUgaXQ7IHRoYXQKLQkgIDs7IGlzIHdoZXJlIHdlIHdpbGwgY29weSB0aGUgZmls ZXMgb2YgRElSRUNUT1JZLgotCSAgKG1ha2UtZGlyZWN0b3J5IG5ld25hbWUgcGFyZW50cykKLQk7 OyBJZiBORVdOQU1FIGlzIGFuIGV4aXN0aW5nIGRpcmVjdG9yeSwgd2Ugd2lsbCBjb3B5IGludG8K LQk7OyBORVdOQU1FL1tESVJFQ1RPUlktQkFTRU5BTUVdLgotCShzZXRxIG5ld25hbWUgKGV4cGFu ZC1maWxlLW5hbWUKLQkJICAgICAgIChmaWxlLW5hbWUtbm9uZGlyZWN0b3J5Ci0JCQkoZGlyZWN0 b3J5LWZpbGUtbmFtZSBkaXJlY3RvcnkpKQotCQkgICAgICAgbmV3bmFtZSkpCi0JKGFuZCAoZmls ZS1leGlzdHMtcCBuZXduYW1lKQotCSAgICAgKG5vdCAoZmlsZS1kaXJlY3RvcnktcCBuZXduYW1l KSkKLQkgICAgIChlcnJvciAiQ2Fubm90IG92ZXJ3cml0ZSBub24tZGlyZWN0b3J5ICVzIHdpdGgg YSBkaXJlY3RvcnkiCi0JCSAgICBuZXduYW1lKSkKLQkobWFrZS1kaXJlY3RvcnkgbmV3bmFtZSB0 KSkKLQotICAgICAgOzsgQ29weSByZWN1cnNpdmVseS4KLSAgICAgIChkb2xpc3QgKGZpbGUKLQkg ICAgICAgOzsgV2UgZG8gbm90IHdhbnQgdG8gY29weSAiLiIgYW5kICIuLiIuCi0JICAgICAgIChk aXJlY3RvcnktZmlsZXMgZGlyZWN0b3J5ICdmdWxsCi0JCQkJZGlyZWN0b3J5LWZpbGVzLW5vLWRv dC1maWxlcy1yZWdleHApKQotCShpZiAoZmlsZS1kaXJlY3RvcnktcCBmaWxlKQotCSAgICAoY29w eS1kaXJlY3RvcnkgZmlsZSBuZXduYW1lIGtlZXAtdGltZSBwYXJlbnRzKQotCSAgKGxldCAoKHRh cmdldCAoZXhwYW5kLWZpbGUtbmFtZSAoZmlsZS1uYW1lLW5vbmRpcmVjdG9yeSBmaWxlKSBuZXdu YW1lKSkKLQkJKGF0dHJzIChmaWxlLWF0dHJpYnV0ZXMgZmlsZSkpKQotCSAgICAoaWYgKHN0cmlu Z3AgKGNhciBhdHRycykpIDsgU3ltYm9saWMgbGluawotCQkobWFrZS1zeW1ib2xpYy1saW5rIChj YXIgYXR0cnMpIHRhcmdldCB0KQotCSAgICAgIChjb3B5LWZpbGUgZmlsZSB0YXJnZXQgdCBrZWVw LXRpbWUpKSkpKQotCi0gICAgICA7OyBTZXQgZGlyZWN0b3J5IGF0dHJpYnV0ZXMuCi0gICAgICAo c2V0LWZpbGUtbW9kZXMgbmV3bmFtZSAoZmlsZS1tb2RlcyBkaXJlY3RvcnkpKQotICAgICAgKGlm IGtlZXAtdGltZQotCSAgKHNldC1maWxlLXRpbWVzIG5ld25hbWUgKG50aCA1IChmaWxlLWF0dHJp YnV0ZXMgZGlyZWN0b3J5KSkpKSkpKQorICAgICAgICA7OyBDb21wdXRlIHRhcmdldCBuYW1lLgor ICAgICAgICAoc2V0cSBkaXJlY3RvcnkgKGRpcmVjdG9yeS1maWxlLW5hbWUgKGV4cGFuZC1maWxl LW5hbWUgZGlyZWN0b3J5KSkKKyAgICAgICAgICAgICAgbmV3bmFtZSAgIChkaXJlY3RvcnktZmls ZS1uYW1lIChleHBhbmQtZmlsZS1uYW1lIG5ld25hbWUpKSkKKworICAgICAgICAoaWYgKG5vdCAo ZmlsZS1kaXJlY3RvcnktcCBuZXduYW1lKSkKKyAgICAgICAgICAgIDs7IElmIE5FV05BTUUgaXMg bm90IGFuIGV4aXN0aW5nIGRpcmVjdG9yeSwgY3JlYXRlIGl0OyB0aGF0CisgICAgICAgICAgICA7 OyBpcyB3aGVyZSB3ZSB3aWxsIGNvcHkgdGhlIGZpbGVzIG9mIERJUkVDVE9SWS4KKyAgICAgICAg ICAgIChtYWtlLWRpcmVjdG9yeSBuZXduYW1lIHBhcmVudHMpCisgICAgICAgICAgICA7OyBJZiBO RVdOQU1FIGlzIGFuIGV4aXN0aW5nIGRpcmVjdG9yeSwgd2Ugd2lsbCBjb3B5IGludG8KKyAgICAg ICAgICAgIDs7IE5FV05BTUUvW0RJUkVDVE9SWS1CQVNFTkFNRV0uCisgICAgICAgICAgICAodW5s ZXNzIGNvbnRlbnRzLW9ubHkKKyAgICAgICAgICAgICAgKHNldHEgbmV3bmFtZSAoZXhwYW5kLWZp bGUtbmFtZQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZmlsZS1uYW1lLW5vbmRpcmVj dG9yeQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGRpcmVjdG9yeS1maWxlLW5hbWUg ZGlyZWN0b3J5KSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbmV3bmFtZSkpCisgICAg ICAgICAgICAgIChhbmQgKGZpbGUtZXhpc3RzLXAgbmV3bmFtZSkKKyAgICAgICAgICAgICAgICAg ICAobm90IChmaWxlLWRpcmVjdG9yeS1wIG5ld25hbWUpKQorICAgICAgICAgICAgICAgICAgIChl cnJvciAiQ2Fubm90IG92ZXJ3cml0ZSBub24tZGlyZWN0b3J5ICVzIHdpdGggYSBkaXJlY3Rvcnki CisgICAgICAgICAgICAgICAgICAgICAgICAgIG5ld25hbWUpKQorICAgICAgICAgICAgICAobWFr ZS1kaXJlY3RvcnkgbmV3bmFtZSB0KSkpCisKKyAgICAgICAgOzsgQ29weSByZWN1cnNpdmVseS4K KyAgICAgICAgKGRvbGlzdCAoZmlsZQorICAgICAgICAgICAgICAgICAgOzsgV2UgZG8gbm90IHdh bnQgdG8gY29weSAiLiIgYW5kICIuLiIuCisgICAgICAgICAgICAgICAgICAoZGlyZWN0b3J5LWZp bGVzIGRpcmVjdG9yeSAnZnVsbAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBk aXJlY3RvcnktZmlsZXMtbm8tZG90LWZpbGVzLXJlZ2V4cCkpCisgICAgICAgICAgKGlmIChmaWxl LWRpcmVjdG9yeS1wIGZpbGUpCisgICAgICAgICAgICAgIChjb3B5LWRpcmVjdG9yeSBmaWxlIG5l d25hbWUga2VlcC10aW1lIHBhcmVudHMpCisgICAgICAgICAgICAgIChsZXQgKCh0YXJnZXQgKGV4 cGFuZC1maWxlLW5hbWUgKGZpbGUtbmFtZS1ub25kaXJlY3RvcnkgZmlsZSkgbmV3bmFtZSkpCisg ICAgICAgICAgICAgICAgICAgIChhdHRycyAoZmlsZS1hdHRyaWJ1dGVzIGZpbGUpKSkKKyAgICAg ICAgICAgICAgICAoaWYgKHN0cmluZ3AgKGNhciBhdHRycykpIDsgU3ltYm9saWMgbGluaworICAg ICAgICAgICAgICAgICAgICAobWFrZS1zeW1ib2xpYy1saW5rIChjYXIgYXR0cnMpIHRhcmdldCB0 KQorICAgICAgICAgICAgICAgICAgICAoY29weS1maWxlIGZpbGUgdGFyZ2V0IHQga2VlcC10aW1l KSkpKSkKKworICAgICAgICA7OyBTZXQgZGlyZWN0b3J5IGF0dHJpYnV0ZXMuCisgICAgICAgIChz ZXQtZmlsZS1tb2RlcyBuZXduYW1lIChmaWxlLW1vZGVzIGRpcmVjdG9yeSkpCisgICAgICAgICh3 aGVuIGtlZXAtdGltZQorICAgICAgICAgIChzZXQtZmlsZS10aW1lcyBuZXduYW1lIChudGggNSAo ZmlsZS1hdHRyaWJ1dGVzIGRpcmVjdG9yeSkpKSkpKSkKIAwKIChwdXQgJ3JldmVydC1idWZmZXIt ZnVuY3Rpb24gJ3Blcm1hbmVudC1sb2NhbCB0KQogKGRlZnZhciByZXZlcnQtYnVmZmVyLWZ1bmN0 aW9uIG5pbAo= --=-=-=--